From: Jim Zhao <jimzhao.ai@gmail.com>
To: shikemeng@huaweicloud.com
Cc: jack@suse.cz, akpm@linux-foundation.org, jimzhao.ai@gmail.com,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, willy@infradead.org
Subject: Re: [PATCH v2] mm/page-writeback: Raise wb_thresh to prevent write blocking with strictlimit
Date: Thu, 21 Nov 2024 16:05:31 +0800 [thread overview]
Message-ID: <20241121080531.567995-1-jimzhao.ai@gmail.com> (raw)
In-Reply-To: <5584d4d5-73c8-2a12-f11e-6f19c216656b@huaweicloud.com>
> on 11/19/2024 8:29 PM, Jim Zhao wrote:
> > Thanks, Jan, I just sent patch v2, could you please review it ?
> >
> > And I found the debug info in the bdi stats.
> > The BdiDirtyThresh value may be greater than DirtyThresh, and after applying this patch, the value of BdiDirtyThresh could become even larger.
> >
> > without patch:
> > ---
> > root@ubuntu:/sys/kernel/debug/bdi/8:0# cat stats
> > BdiWriteback: 0 kB
> > BdiReclaimable: 96 kB
> > BdiDirtyThresh: 1346824 kB
> > DirtyThresh: 673412 kB
> > BackgroundThresh: 336292 kB
> > BdiDirtied: 19872 kB
> > BdiWritten: 19776 kB
> > BdiWriteBandwidth: 0 kBps
> > b_dirty: 0
> > b_io: 0
> > b_more_io: 0
> > b_dirty_time: 0
> > bdi_list: 1
> > state: 1
> >
> > with patch:
> > ---
> > root@ubuntu:/sys/kernel/debug/bdi/8:0# cat stats
> > BdiWriteback: 96 kB
> > BdiReclaimable: 192 kB
> > BdiDirtyThresh: 3090736 kB
> > DirtyThresh: 650716 kB
> > BackgroundThresh: 324960 kB
> > BdiDirtied: 472512 kB
> > BdiWritten: 470592 kB
> > BdiWriteBandwidth: 106268 kBps
> > b_dirty: 2
> > b_io: 0
> > b_more_io: 0
> > b_dirty_time: 0
> > bdi_list: 1
> > state: 1
> >
> >
> > @kemeng, is this a normal behavior or an issue ?
> Hello, this is not a normal behavior, could you aslo send the content in
> wb_stats and configuired bdi_min_ratio.
> I think the improper use of bdi_min_ratio may cause the issue.
the min_ratio is 0
---
root@ubuntu:/sys/class/bdi/8:0# cat min_bytes
0
root@ubuntu:/sys/class/bdi/8:0# cat min_ratio
0
root@ubuntu:/sys/class/bdi/8:0# cat min_ratio_fine
0
wb_stats:
---
root@ubuntu:/sys/kernel/debug/bdi/8:0# cat stats
BdiWriteback: 0 kB
BdiReclaimable: 480 kB
BdiDirtyThresh: 1664700 kB
DirtyThresh: 554900 kB
BackgroundThresh: 277108 kB
BdiDirtied: 82752 kB
BdiWritten: 82752 kB
BdiWriteBandwidth: 205116 kBps
b_dirty: 6
b_io: 0
b_more_io: 0
b_dirty_time: 0
bdi_list: 1
state: 1
root@ubuntu:/sys/kernel/debug/bdi/8:0# cat wb_stats
WbCgIno: 1
WbWriteback: 0 kB
WbReclaimable: 96 kB
WbDirtyThresh: 0 kB
WbDirtied: 33600 kB
WbWritten: 33600 kB
WbWriteBandwidth: 148 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 416
WbWriteback: 0 kB
WbReclaimable: 288 kB
WbDirtyThresh: 554836 kB
WbDirtied: 47616 kB
WbWritten: 47424 kB
WbWriteBandwidth: 168 kBps
b_dirty: 1
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 5
WbCgIno: 1319
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 1835
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 29
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 101752 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 158
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 101756 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 2498
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 3358
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 3573
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 3659
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 3186
WbWriteback: 0 kB
WbReclaimable: 96 kB
WbDirtyThresh: 554788 kB
WbDirtied: 1056 kB
WbWritten: 1152 kB
WbWriteBandwidth: 152 kBps
b_dirty: 1
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 5
WbCgIno: 3315
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 384 kB
WbWritten: 384 kB
WbWriteBandwidth: 98876 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 72
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 554836 kB
WbDirtied: 96 kB
WbWritten: 192 kB
WbWriteBandwidth: 4 kBps
b_dirty: 1
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 5
WbCgIno: 3616
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 100308 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 4132
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 3401
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 4517
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 4846
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 4982
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 100468 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 5369
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 96 kB
WbWriteBandwidth: 75104 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 5627
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 6235
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 6192
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 6500
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 4617
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 6958
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 5670
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 1
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 5
WbCgIno: 5870
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 5025
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 7990
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 91500 kBps
b_dirty: 1
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 5
WbCgIno: 8033
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 2842
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
WbCgIno: 11129
WbWriteback: 0 kB
WbReclaimable: 0 kB
WbDirtyThresh: 0 kB
WbDirtied: 0 kB
WbWritten: 0 kB
WbWriteBandwidth: 102400 kBps
b_dirty: 0
b_io: 0
b_more_io: 0
b_dirty_time: 0
state: 1
ubuntu24.04 desktop + kernel 6.12.0
default cgroups, not configured manually.
---
Thanks
Jim Zhao
next prev parent reply other threads:[~2024-12-05 15:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-10-23 10:00 [PATCH] " Jim Zhao
2024-10-23 23:24 ` Andrew Morton
2024-10-24 6:09 ` Jim Zhao
2024-10-24 6:20 ` Andrew Morton
2024-10-24 6:52 ` jim zhao
2024-10-24 7:29 ` Jim Zhao
2024-10-26 0:02 ` Andrew Morton
2024-11-01 7:17 ` Jim Zhao
2024-11-07 15:32 ` Jan Kara
2024-11-08 3:19 ` Jim Zhao
2024-11-08 22:02 ` Jan Kara
2024-11-12 8:45 ` Jim Zhao
2024-11-13 10:07 ` Jan Kara
2024-11-19 11:44 ` [PATCH v2] mm/page-writeback: raise " Jim Zhao
2024-11-19 12:29 ` [PATCH v2] mm/page-writeback: Raise " Jim Zhao
2024-11-20 8:03 ` Kemeng Shi
2024-11-21 8:05 ` Jim Zhao [this message]
2024-12-12 12:32 ` Kemeng Shi
2024-11-20 11:57 ` Jan Kara
2024-11-21 10:20 ` Jim Zhao
2024-11-21 11:49 ` [PATCH v2] mm/page-writeback: raise " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241121080531.567995-1-jimzhao.ai@gmail.com \
--to=jimzhao.ai@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=shikemeng@huaweicloud.com \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox