From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A552BD75BC8 for ; Thu, 21 Nov 2024 07:15:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2F7126B0083; Thu, 21 Nov 2024 02:15:22 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 2A6EE6B0088; Thu, 21 Nov 2024 02:15:22 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 16E8D6B0089; Thu, 21 Nov 2024 02:15:22 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id E9DA36B0083 for ; Thu, 21 Nov 2024 02:15:21 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 826BF1C7534 for ; Thu, 21 Nov 2024 07:15:21 +0000 (UTC) X-FDA: 82809240738.29.F735719 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by imf15.hostedemail.com (Postfix) with ESMTP id DF269A0002 for ; Thu, 21 Nov 2024 07:14:25 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FpeLDZwy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732173227; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=YcaUvRzyH/madg00I7GmH+SP7e7ZxVKCft9+IH2Y1JQ=; b=NMPN5LYxekrGOPV3+pn09TZc3/fvQVmtA39MzM30SFs9DS5hMbOVkhtF0dKd62nhURejsc btEDlxJjUIz8ck7u34BfYC33Pqgc9K/228A9ib8fHEZgMBxklnarnJtGNV8tISykIcqKy+ 8MBI+76MSVUSzCGCc0zRKGCGdLL2/JA= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=FpeLDZwy; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf15.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.51 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732173227; a=rsa-sha256; cv=none; b=5fhaR0jsZKPLubrT2qfbZNqm6hW678gjFiX9pJNeHcVU0n7+Elw8jw/8jayv/bkbGEIi3/ wXrJNpZVdzYe5/ZlRrij5fpUmtbgPBQJigSfMDGyfOFGb2xFXahZHpTxyz3dwghLb6VQUb VrO3gbX9zSBfsTti+yDG+McQVoQutac= Received: by mail-ed1-f51.google.com with SMTP id 4fb4d7f45d1cf-5cfd28222f9so285088a12.1 for ; Wed, 20 Nov 2024 23:15:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732173318; x=1732778118; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=YcaUvRzyH/madg00I7GmH+SP7e7ZxVKCft9+IH2Y1JQ=; b=FpeLDZwyUAYkLH3Us7X6w7nFUq2u5J2jkuFvRyb31aJvNMKo+YabAMROFeFWSYYXYr KjE+gk15nHkW59gN9yDGiMIyYAlT7HMN523/FOrJtz110vV7LR8pQAbI+FIj3o3Y/nkt I2DhiNYshFN0NaMG4gEVl9sLnfvl9s8jgMJyrhgEnbigHJs4JZ50DNceK7DhmKdtCOub EHD3k2Pf58uvK4AxxQXZi3xq3K6BoaXW7jzYebgpHfbaLLJw9aHJtePBg7XT8DaVk8rl u9RfX+Nq3LS0uMOQJp/FYghnkV/QR6xHA91hBvTSTzv9bHmv1q+2zc6ZqhkmrKEuEbHG ym0g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732173318; x=1732778118; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=YcaUvRzyH/madg00I7GmH+SP7e7ZxVKCft9+IH2Y1JQ=; b=wsm4zWTh+xnwVRGqw1QFig6VUe2tHYO4Qf/GaSwt1cztKNQbFE0lgY7PwJgQkqInbL w38cEWixqF2kNYrSAao2FHs25gMGQ6HIlZv2nFH72CLi4KZZc4JRasiPe+jm1Pm1lpMu pNa8ooXxKKsUB9bDmrr4t3bEGrLTeYREAdBw6s0emjz3lSIm/t7p/3jVG8CyvVIJLt6M oDLW+PVz5z9o9032d9wt/7Xf1/LSB3bZdK8ZugEHT06MwHPI8ywRkMAWL2bBzI81akBN Zon2T8H/MERua6yhuVQPHQe2wJvvtFWGxwV4YL3mrn4qwySbt+8b/0dkzY2/fx7qqTMX YvYw== X-Forwarded-Encrypted: i=1; AJvYcCUxGRIHXljiVO+zxlnehLZIRjXba9AJqgLNB/PjrivFVM/1HjAQ1ftuQ/sx1WqciD9v62Ofu2QuxQ==@kvack.org X-Gm-Message-State: AOJu0YyNAPwW/5z2AoZtjCsRJtVxqZdUEoQOwsAVoYsZBPCUq4nD+t30 nazRZkSCefwMk/HtrIedBy8KO3+Md993nxZQldPe4kuUqspKN+x1 X-Google-Smtp-Source: AGHT+IEgg2aeJC6o7qEaezqq1paQqC9XyVk03Sn9Q8ggR9/x/ngPO1b3zdOpocTkXbOhyXC/w36wSQ== X-Received: by 2002:a05:6402:27d3:b0:5cf:cfa8:d6cf with SMTP id 4fb4d7f45d1cf-5cff4c34147mr5373626a12.17.1732173317958; Wed, 20 Nov 2024 23:15:17 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa4f4181818sm45424666b.82.2024.11.20.23.15.17 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2024 23:15:17 -0800 (PST) Date: Thu, 21 Nov 2024 07:15:16 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Lorenzo Stoakes , Sidhartha Kumar Subject: Re: [PATCH 3/3] maple_tree: we don't set offset to MAPLE_NODE_SLOTS on error Message-ID: <20241121071516.v2m3z5sls7j2bimz@master> Reply-To: Wei Yang References: <20241116014805.11547-1-richard.weiyang@gmail.com> <20241116014805.11547-4-richard.weiyang@gmail.com> <20241119021526.72di4fthc6wvif6a@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: DF269A0002 X-Stat-Signature: 5tgpwhuidyqnr97y5wgn8abmczdoqf49 X-HE-Tag: 1732173265-22398 X-HE-Meta: U2FsdGVkX1/kTe6IrwbA1F9REhUy+nF7tbh13105wYpZ9qBbh7pYQvgAYiKe4KLhQrQ0ksPEjtXv9/iP4Y6FB8iZnulXMA/VmBxLzw33/QyXCrOjUVYfDstEluQzwxwgVCvwkoCIGrQlLY2ziDwnAUkv6KkCYnseE5Vdgqr4mizju5gmsKNzyU95DS/dReB9POWJ5EN1a/IGJO2QcZuQQMnBg86ao9T31Wis7I22CUHapwpOUs7AC/7rifPkRIu3yAKbTV/auL+cQzUu0x8r353igStgenjlU542wvDrs9PqbxNxjrEiHGdmN3uvkCo1GmFMQyJeCrvAUJOmLkXm/6hzdXABLLVVHxfdDDIII/LFS21VeJsR5JpB20SZ2WZHJ2YYL/g9ggl3/Fy3IR7endJZf/iEtYBqF5iH0/hLW8bQLDQwnRvx6LzN8hIsVI5ObpbSra7feCmz7Hyt5NbGarj3tF8ilEq9dIpgGq5OsgACy95D+WQ2gK2ilKcGNKbxaVmrlrlO6fLUNm4DiG/INouQTFVcuOjWmUEIzj+dyppMm+MtMwCCANqnxS7XB8izf3R8P/51YnCp3uQIxKAaYzKAqsW4K40BY+NP3aHvyXmReTcurMBgzEsMGfRC+AoNlotHHQLyoyBjyfSNx+DWIZ5/NjQ6UVOtqMFIqgXnKzuY5fxnuC/QHi056/uZ5ggFHYrTnD1gRc/QZC+iwcVZ2im5GCaZQ+Ws866dWzouxksITVaIljVqpOjQdtP+5o+ZjpKnpPDkEkd783Ld12HvYZ8Fzzs4MQ1sSQWocZbxLroE/g4fwxhthNM3YOgLjdUD6UtuX2nrZpoU16y9tLEiE3ktg+Bj72ePXL1+FnFOgmemaWBNDtf89TdzOZedEcpRE7gPzHrToPMyWgCVdRJ3lv4JSlK3xIUiDJIjkIl/RJUeUUoK+UahYNi8aVF9iP5mXQpBZcwWTXg1Buv+XoQ FYGU0EBJ fIUerX5SNKX4LnQzME6ldRx/XXW2We+HLb0PZm+hZ/SucnFvmJayNgwTxzscXZIPCLsYEvLQ9X2nESXZeAfsrffBSwqg8m7ldGT8dDv5tDY4PwAtgCb+6BB2LGHb2+y5Dbuvs0uZUYh4PMP9n6YhI0ofKjDe/fgQXCikrZNHuXZjwrqj3QLRhszhSBBdXMgPo4jywJNLfpgOBnpQqUpmDsD9GPi1gjPXS86shVAQjdcKHQsa675sqVRO+mRo12dQwQ59FJz6zjQSXq70HE3bmdWWd6HFvnc/20RI2DNU/reF07FrhzqwcECajb1ESyqbKZmP+6SOL/HV62dwjFqfPq7NsGecwZYupVV6n4Fg1xT2XMfxbNOXDbLVUzVtyUck1fGZ/E5qtmOrPnaZqf++h4hWE1H6HgHfTsBnH8TKE6TrYQUNCHrlku9mZIhxGFJ45y9KNqBgZmV79KRG6IUfE52vISRi8PEyP2vFK6+eIR/nQM11P1t+PFpH87u6fISW60Zt9GayiUPwiXM3fIfcrReQtczvi2BjE9xM/WJqqjNjWngXENniiR6nHEXDa5Zcx0OZAmO8YtbSFZfI8rs9J5NlxfMAj6ACVdjL3b648KX5f+7DLOBmlr7iAS1RxbAoRMymy+235Bllse6gLwAc5/rkMt2NQA5xHVfbovGskJpSW2GNFrl/p77uFfdRoD5hUWCCj X-Bogosity: Ham, tests=bogofilter, spamicity=0.423600, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 08:58:06AM -0500, Liam R. Howlett wrote: >* Wei Yang [241118 21:15]: >> On Mon, Nov 18, 2024 at 03:50:49PM -0500, Liam R. Howlett wrote: >> >* Wei Yang [241115 20:48]: >> >> When mas_anode_descend() not find gap, it sets -EBUSY instead of setting >> >> offset to MAPLE_NODE_SLOTS. >> > >> >This is for mas_start(), which I think is not necessary anymore. >> >> You mean mas_start() would set offset to MAPLE_NODE_SLOTS on ma_none and >> ma_root? >> >> Thanks for the information, I didn't realize this. >> >> These two cases are handled by mas_sparse_area(). > >Yeah, I'm not sure that needing this lived to the released code. I don't get you clearly. What should I do next? -- Wei Yang Help you, Help me