From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id D3709D75BC8 for ; Thu, 21 Nov 2024 07:13:37 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 566D56B007B; Thu, 21 Nov 2024 02:13:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4EFBA6B0082; Thu, 21 Nov 2024 02:13:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 368BA6B0083; Thu, 21 Nov 2024 02:13:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 14B096B007B for ; Thu, 21 Nov 2024 02:13:37 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id A895B1A12A9 for ; Thu, 21 Nov 2024 07:13:36 +0000 (UTC) X-FDA: 82809235320.24.4DF5A73 Received: from mail-ed1-f43.google.com (mail-ed1-f43.google.com [209.85.208.43]) by imf17.hostedemail.com (Postfix) with ESMTP id 845F940002 for ; Thu, 21 Nov 2024 07:12:54 +0000 (UTC) Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eMeAQ1Wz; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732173011; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Rn3aQmuY3i8Aoj6W7MoY2Jt5UZflx+cBHTmbkNXentg=; b=NmxvlS1TwyRlQpq/3U3fCeMCjNpg4x2i+2xLg1Y5s9eW4ZoQWJ7II8aJOCt64fXqQh+4RW PyhbQaPdimVbLtPp7fioKKHRC6hz2IEfEpChl8igYtoYSMcexlkIwCxzvYYmU3xlx2mrTG JZweyAflHm2JwyC/bDyKe6K8d46Yn2w= ARC-Authentication-Results: i=1; imf17.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=eMeAQ1Wz; spf=pass (imf17.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.43 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732173011; a=rsa-sha256; cv=none; b=XH4jrXCZ+Oi/yLRBKC5XifV4rgoP8kTbfYfYE2bn39bVfJbuoVQrFRtnpKbLd29J29wcFF fI8xoTYhSN0uMXxV1/aDnP2Fy4Xa2spF6nEucm0iOZF9kPzJATfIEXhR8MDz7mEYbHdIgl L8FguhM3Nyte/XvXq+v6pw3stEVWh/s= Received: by mail-ed1-f43.google.com with SMTP id 4fb4d7f45d1cf-5cfcb7183deso3015560a12.0 for ; Wed, 20 Nov 2024 23:13:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1732173213; x=1732778013; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=Rn3aQmuY3i8Aoj6W7MoY2Jt5UZflx+cBHTmbkNXentg=; b=eMeAQ1WzsTdcN/EGV4Y4y9l2VdLOPkaD+d6xYWfoME3V5c9Rw+cNnLiu7xgCqYqRXv pxqJjHOoKvfa2hFxZW53LN/3V7VQCnB7c6ailERIeu0g8lg2UZHge2L28rXAom4cj2/N nNKfqKgOuNk334VW1pUMxky4CepG3bvfh4ThGgxtUKL7ixLKqZ/ZfZyzccLR/zkHD0yL gDX1pfDWgPgLJ1Vdhvx3aUdZuB/GGZmVTxQHWC2lxQ9z6C/FwIEr4K2uyBVHbY+KXFpr UNkE8qeHYCN90poh0wc/Ej6Bc+WgUytJdUVvCOi0Y+A91oH3ewSySsrJopo4g2VQPCMi KU8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732173213; x=1732778013; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=Rn3aQmuY3i8Aoj6W7MoY2Jt5UZflx+cBHTmbkNXentg=; b=OAoW3496ST5/QGOolfqjYUEI3mTalF5tRAecintY2k4LML/FR1Uf2rlYQe106J8tST 9gy3B94lpuxbtF5mFtAel9KCpBVqnGGjibHWLpDQ7OEUwMFp64BELhcp8t+qALvSNves sxs3X4YOdCmxAgoHMwzpu3rO7G45v7TB2iaOF8yB4vzr04d5UB+Km4wDUIAG++r45s4X TmRxgO5MFLskuZPwJjHP4YftkI9JL4fa0O+iG0lXcg9fOvspf4w1hYKSRZWqURKa9MMD Fi8BwdCeJpvfnxr2qgu1J8kBVUbXq2QjzI23q6upm9O0FQjSK2D6sXkxuMPPncXewp7j y1YA== X-Forwarded-Encrypted: i=1; AJvYcCV4iOXDCK7P1UN8DyE666mrVtfvPFuVF9cAGyle4ywbi6Br9zV2bqH6EDUq3t4puK2h0k3FSnfkxA==@kvack.org X-Gm-Message-State: AOJu0YztC4u51BAuqJXMpksAG7cmv5Iw5P5/OsZ2gsCqoGj9sZp85oh0 BEVMSePvfZUumB3gHbH5IBcoStu9kwxEmbYUzzBb7O6jwKX2+2es X-Google-Smtp-Source: AGHT+IE0KcZLetNX5l2Kg5GHY8MTVRidvMVAxCjF2rfd2Z8NQKsIzKv+jmeu5QMnVQjJtsxsPNzGTg== X-Received: by 2002:a17:906:4fd4:b0:a9e:65a1:fdac with SMTP id a640c23a62f3a-aa4ef96ba56mr200632766b.7.1732173212971; Wed, 20 Nov 2024 23:13:32 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa4f41536ffsm45296466b.3.2024.11.20.23.13.31 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 20 Nov 2024 23:13:31 -0800 (PST) Date: Thu, 21 Nov 2024 07:13:31 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Lorenzo Stoakes , Sidhartha Kumar Subject: Re: [PATCH 2/3] maple_tree: not possible to be a root node after loop Message-ID: <20241121071331.fj4fymnjkw2iksqx@master> Reply-To: Wei Yang References: <20241116014805.11547-1-richard.weiyang@gmail.com> <20241116014805.11547-3-richard.weiyang@gmail.com> <22ljesbnxadun2ij37qnx7gdqbl7wy6nxjjwkejo6waa473ro7@niiaqj4cj23d> <20241119021007.txauxmjakjk7ideh@master> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 845F940002 X-Stat-Signature: iyfa37q8ywp5i6hzx3unc35qnc9f3y5f X-Rspam-User: X-HE-Tag: 1732173174-844897 X-HE-Meta: U2FsdGVkX1+Bsj/1OoDVMIrAysbT36yaUwQqmJGYnGnegmcOOUR4JqPDLIwnENrr8Yk6KNojLmbiYrALLtX1KGf3Lrk3JV6sZ7U15aHkQPSUAz5yn2xWWV/v7mqTekv0TNqnhx9xt+Lw5bC7ECGW4pRzMPxnda6nhPAEHI8MBH+NW7JWqEcqklyk2LqNeRhCY7Mc7c4r/t666tgc7sXRTwBLzsumxH8DWq4FpEyUvYMM1J4vjaSeZLGU5N86ODBEPxAkrWjWjKMb00vfii9tNTrPA938H8zVvkwymmJ6C2lxY8zVBWJujmAEMrY1uO6an2wz67eyFL9gJAuKIFJbESAFOLjKc/sbPa4by777OuicqevLtEu4bJf8LemxDBdznPhGO6UOdOLBHFxb3vyV8uUqAPQEt27Z3HlQ5VMCsxiw5U/F3NJ0haBDRkv9LCSdVGC3WV5lf2E6l9Q23s0qy/IQuMwhNrzP8A6IrHBO382ymJ0BT01a5BkWlSJ3vQHwyI4z4TqSWvDOtTsGALlncHhtFFnLUkFvXxb/AmEaqzm8hB7tcWgcxYlR6CD2f+g0BH1xZVDdvhlHVkT+DtGhY0/U499vTs5DAJluRaDUlK+b4EqJWZoxTWg+pLp8WmDosJjZfQpJRxPNYfkdlrPh7/IDJJVpsJdoTzR4XoLbFYJBMeKMhBzwmlSG+2hthxJL5dL6dk/RdobLGmgd7LCjMuWW+4w44Ee6QRH0FTuipNz/eCzWwAdbp82LdKZ+Immk6s05kAfKFyHnkXf4AEhLYn0y9qmRMOKMn3UCFveTMAKe3P8VagiOQLKPm+KmeJThsCNlGArVnbAUh14OJsT44ZsCqyWarXLkk8SDSjmeLK/C/Gqn7KXaur/ltwW5ClPnxhxg0dCZXodDGUYS5zQpUqshmL369LPp6LCa0GpD4XTVETKHhLYxehPxhMtEcBBBmmpDQWzINw+SYEAJz/6 tghFrVd2 0oHcbREAg5MOhmi1AxS4yLyfwdQf3KriyjnW605e7ZpRDl//Dfp/sejoOVXP2Hvel7nGoOWS9l0rgpBoeSWEVr7XVQJsSlReV4xAHEqhXgg9On8peJ1SW3kO6lGgBhJQq8mBkNBLwVqQx6Tvn+z6flwa0zjDQX6JMQSJEcvZhY0maTHzVZjrpZ28GUkFA1omQTmNS+76xmfousrtVpPaBPwjIKQ7QZ5kmhFvYrdQ1OLLEUWdAYbQ5dDfUaap5i75FOqxK8cEQ3yFqdqfcKzRuNdWVKNgwIoTNg1zcBxLpEWRzeeqkpmEcc3xZqK4L3G1CPZQ3OIChBW1R2TkKRNBYGXyvnH9ho7o+aW39X8ZJK3Xouc+Jv4EBBa19G15x5kVctQzoqxgxWSZ9lLFlxqADZY6o2kd12KUx3tD6uzThGqZN8CuGvjAmeQtgnCVGSJTx21fgazdL/NIarTuqjBMRzy6WF+PSVoOk/rcVJ2FjV3PbJS1p5M1imNFDNW+9/B9/yhp1P+34++6/rkjKKAUFJydIb2AQF8G5bghGgPskVLJl3jZjO4VJTadVdmtKjU+nCKh/+l13FcIHvvAiTglBgO66q/etGO7FiYpVUNvVcxLnAF2ZkWU7pgv8FsJuiGqB+YGj8SLshmTeFwA/QM/+tMLmdkpfhG9cNFCIjMVHPf8zUJ6IwssRsduVGQ6fg1UtepDK X-Bogosity: Ham, tests=bogofilter, spamicity=0.003264, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 09:12:31AM -0500, Liam R. Howlett wrote: >* Wei Yang [241118 21:10]: >> On Mon, Nov 18, 2024 at 03:49:55PM -0500, Liam R. Howlett wrote: >> >* Wei Yang [241115 20:48]: >> >> Empty tree and single entry tree is handled else whether, so the maple >> >> tree here must be a tree with nodes. >> >> >> >> If the height is 1 and we found the gap, it will jump to *done* since it >> >> is also a leaf. >> >> If the height is more than one, and there may be an available range, we >> >> will descend the tree, which is not root anymore. >> >> >> >> If there is no available range, we will set error and return. >> > >> >Isn't this needed for the overflow case? That is, if there is a range >> >that ends at ULONG_MAX, then we will break from the loop on the offset >> >limit, but not check for root, return false, and continue to loop. >> > >> >> I may not follow you correctly. >> >> If there is an available range that ends at ULONG_MAX for a root node, we >> break the loop with two conditions: >> >> * the root node is a leaf node, then we will set found to true >> * the root node has children, then descend to a non-root node >> >> Not sure this is the case you mentioned. > >I am concerned of the case where there isn't a gap in the last slot of a >leaf root node. Examining it, I think we are okay. > >next_slot: > min = pivot + 1; <-----min = 0, overflow. Oh, this overflow. > if (mas->last <= pivot) { <-- still okay. > mas_set_err(mas, -EBUSY); > return true; > } Thanks. So it looks good to you ? -- Wei Yang Help you, Help me