From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 86A6FD6E2A4 for ; Thu, 21 Nov 2024 10:09:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 157C36B0083; Thu, 21 Nov 2024 05:09:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 107246B0088; Thu, 21 Nov 2024 05:09:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F11566B0089; Thu, 21 Nov 2024 05:09:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id D21E56B0083 for ; Thu, 21 Nov 2024 05:09:18 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9C37D120BD3 for ; Thu, 21 Nov 2024 10:09:18 +0000 (UTC) X-FDA: 82809678042.24.35136ED Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf13.hostedemail.com (Postfix) with ESMTP id 179D420013 for ; Thu, 21 Nov 2024 10:08:19 +0000 (UTC) Authentication-Results: imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="s6D6U00/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732183689; a=rsa-sha256; cv=none; b=4Y9apFyEde2O5auio7XO610sYNRjc8cFszwdcge+cbBq3NeoOhA240yOOkvqdhrT0j869Z uTGcL2XPKr6A31jGu4CEIpS9nlpPWG7qTK8jwFh7fbbJjJjRoSncngwE19H1mdkmRW+ReA vvGDLqhiSHMdZQ6usyF39OdzkvPBq1E= ARC-Authentication-Results: i=1; imf13.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b="s6D6U00/"; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf13.hostedemail.com: domain of brauner@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=brauner@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732183689; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1mgyLwuEWgM7IkL9LOzZSE9vNyll+TTDQVIGefuketk=; b=oLPwP9jQ4ALgt31jzBroebS9ZxEXts+wDif4FhNfxZMkOgSzi0Mny6V7tgqyAQQPOvXiuS FXPXdkCgL0IApxDx0avJcspHHtLptJBHcGmbOHitKrepl9FUVoRD6Ot4xPA7BG6UuLqbwt v4e9n/GiZsebr7bpNbDVnSXJZlDnqcY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id A9A25A402F9; Thu, 21 Nov 2024 10:07:22 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id F3C73C4CECC; Thu, 21 Nov 2024 10:09:12 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732183755; bh=1mgyLwuEWgM7IkL9LOzZSE9vNyll+TTDQVIGefuketk=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=s6D6U00/BcdKO8qTkj4TTysr0/sF/2AYfHCq4BiYuB3xVTdO8RbJzqS6jdwHw+KQ1 HvtFXHGOZ+Cb3s43eJt1Tppyn5mCgomLVY0EqeSIT2oHGVmkXu6FxTggcePoid7L+z m1TZE0Nxo2W3H6wpqoiKtel0VHFglzKU8hdsu1IR40V/8pSQoApQYwTkBdaSTaHazk AiVW5p5TYFZzLM4JjJMeaZmyXLICh/NiSOecyDv+g/+OI01hOMStN3bZ4Qu6m8vAby X52EHp9YWUDFhiD/AEmgAxZduzkTM7U1fiOzztOS1cRWHzc8B4bqYamSMZgGNL70hh mxBFxyxluomaA== Date: Thu, 21 Nov 2024 11:09:10 +0100 From: Christian Brauner To: Jan Kara Cc: Amir Goldstein , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 02/19] fsnotify: opt-in for permission events at file open time Message-ID: <20241121-satirisch-siehst-5cdabde2ff67@brauner> References: <5ea5f8e283d1edb55aa79c35187bfe344056af14.1731684329.git.josef@toxicpanda.com> <20241120155309.lecjqqhohgcgyrkf@quack3> <20241121093918.d2ml5lrfcqwknffb@quack3> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241121093918.d2ml5lrfcqwknffb@quack3> X-Rspam-User: X-Rspamd-Queue-Id: 179D420013 X-Rspamd-Server: rspam11 X-Stat-Signature: sdno8d8j688g3w5quo8d37iboxgsixho X-HE-Tag: 1732183699-6980 X-HE-Meta: U2FsdGVkX1882+gdrzY7lg+qUbeAkLSIIm86X1LM5MUIhlSRJm5PcYyTxuaOieZBKdvcX2aksZ/5EG2MX+kp+w6FgRZi0JpJcNSVU1JJHjKbkWHcpPKrWoHxVXDY5TeGLBu6Tb6n3wy1nNtRrpaV2nheVUpzk48WcHe7/ttQKDB2c4dCN+iAofItbyPl7IKbis95RVOq+wi06HscUPz5yRtDIAjZbwaDUN0HsG2Iacs/G4Z6xamxUZx+Vv2r0UsATTU4oavdx88+VVOf25aL4lN+IduiMgfbDOyhzwY6l2V40mynGYUJ2a9EY2F/8xmP7HrXTn84UCxwkyvRRsvds7HETtnF8M6cyGdr4TB66XU31UgUCAnUe9xEOWiDZTevvMXzwAMY2y+PngVXj0ZUjZVjOA9+F7cbhhaDWyRy8YJ3BN52ugNOECGRwOISXpH6+h6aLAeUi36wicRwGMTLu1ZA3taDWYK2K8gYVvYWgmWORo2nbvFZ+jEQCUWDB1lG79AA43cHhzKy5yecMgUBZCcoGMEdagQmKx3JoVYUPFL9XwhU48Ick1FL6kWnv9et3z3zUb8W0DlSNrFU8881DtLINQ6gOOhBGo3HJ2MvQPxAURM7cSd1scVFbqjiYexU8Ba80b07MiKujmdOGR0sc239q66n/PEOUGIPoG/iju2vKfTUSKZGfs5fdZV+GQ2b9hlfzAZE/dpcmHRThupePlIeoCJRQdF75ji5VymO6X9eL+P4meXC1rCTscHuSs6kn9y+j727qLtFNDzhEDpE4Mv5/2EgF2gH9+Ad/TQxQuK3LcgBOaFwebHaTj6Wsa2mHtNrKHvScd6r3Q/UJ4Jo35eiaPqofnAVsh5t+Dthp3vnFKcVuQWpg8tZ/7eANZXP5Kza91whDMj601ohJMXf2hxK7+nWr1M04E4kYBxDMRcjsgMXBFf/OtkRkijtT+eJNKuor8rvn+/sjVAvNIO zDdMyjEc cnM02uEnnDr8+1w1Aho4qOZq942/u9h5iRBuiGcDkWyMHOpczjfVVWaOfQgaMRBoxC0hRzdWvIEZrm8ztOriSG+Z5ytwHzh6wU7Y6mYzEPN7JvaCcowG5eUOYYs5PXGL9Rd2fy+rsbDog1RXJ8iQp+qTi6FabDNiA/NDshrl/mjQ7TmcyHcqRttHIoSmJoBTlBYhprZGSDhL1keWRUF4Vhf1FlyGVfUQe+efbqsZqBpUhojpeyfWtS7c5COPgBKM/tqO1Knf+9tkxtmdv/FA4rXb20sWn5Awxc/C+tnvx4OJFyTM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: > It is not that I object to "two bit constants". FMODE_FSNOTIFY_MASK is a > two-bit constant and a good one. But the name clearly suggests it is not a > single bit constant. When you have all FMODE_FOO and FMODE_BAR things > single bit except for FMODE_BAZ which is multi-bit, then this is IMHO a > recipe for problems and I rather prefer explicitely spelling the > combination out as FMODE_NONOTIFY | FMODE_NONOTIFY_PERM in the few places > that need this instead of hiding it behind some other name. Very much agreed!