From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 005F5D711C9 for ; Wed, 20 Nov 2024 17:13:31 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 91ABB6B009C; Wed, 20 Nov 2024 12:13:31 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8A2B06B00A0; Wed, 20 Nov 2024 12:13:31 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 71C5F6B00A1; Wed, 20 Nov 2024 12:13:31 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 4F9196B009C for ; Wed, 20 Nov 2024 12:13:31 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 0C781A0E79 for ; Wed, 20 Nov 2024 17:13:31 +0000 (UTC) X-FDA: 82807117176.13.096D9C8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf24.hostedemail.com (Postfix) with ESMTP id B927A18001F for ; Wed, 20 Nov 2024 17:13:22 +0000 (UTC) Authentication-Results: imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=F6pI=SP=redhat.com=jpoimboe@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=F6pI=SP=redhat.com=jpoimboe@kernel.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=redhat.com (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732122606; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MLsgbQqp6DGWmv2b4f8JaA8DAfD21/yY/+FMGx0S+QU=; b=4lD2D/bGyCaODEgwezKfpSdqLLlaxHJOENCvbRAX7AXgRpYhrGTzWVC3bJwCSQg0ZojoPi XUhXD/XORAlYzHNiwtF5klEM4MGOl6623dczZ6v5FuUWUd9zfvxyj1MeafYw7kqbqteEH0 xU4tV+Lo4NfPAMu8pNmcZMNjc/0Dr3o= ARC-Authentication-Results: i=1; imf24.hostedemail.com; dkim=none; spf=pass (imf24.hostedemail.com: domain of "SRS0=F6pI=SP=redhat.com=jpoimboe@kernel.org" designates 139.178.84.217 as permitted sender) smtp.mailfrom="SRS0=F6pI=SP=redhat.com=jpoimboe@kernel.org"; dmarc=fail reason="SPF not aligned (relaxed), No valid DKIM" header.from=redhat.com (policy=none) ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732122606; a=rsa-sha256; cv=none; b=ZZhS24R2jYMeIy7NwfuRBlhH9xj3sdv7jnBDFFaUd11mBiR9DIThCzL+7rdoT/OK/KJyia N+ELEgmP9c4EqrTmkZYKaDolz472Pd5u11UdChl7/IIK6htb3QhCKHoYqL3KKT/zpJpuub tU1a2dOUoydGu0GH3JRctw+L3clBM5k= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 544D85C4B54; Wed, 20 Nov 2024 17:12:44 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EFEAEC4CECD; Wed, 20 Nov 2024 17:13:25 +0000 (UTC) Date: Wed, 20 Nov 2024 09:13:24 -0800 From: Josh Poimboeuf To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Marcelo Tosatti , Yair Podemsky , Daniel Wagner , Petr Tesarik Subject: Re: [RFC PATCH v3 09/15] objtool: Warn about non __ro_after_init static key usage in .noinstr Message-ID: <20241120171324.a4yteg2mhkdeyymf@jpoimboe> References: <20241119153502.41361-1-vschneid@redhat.com> <20241119153502.41361-10-vschneid@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241119153502.41361-10-vschneid@redhat.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: B927A18001F X-Stat-Signature: phh3ibdg3tkhk4gajw9jt5dgwc8i1wj9 X-Rspam-User: X-HE-Tag: 1732122802-157501 X-HE-Meta: U2FsdGVkX1/GywOCFUEXcSmmBFUP0ejjQDlI/XxFVaV6dUEgUFF2DaNOhl9DUXtzipHt8bMgXIltUryP/mjV2aZ+/Zpm/+eES1rQpXlj4g1rCeByKWCAroBQu0VHBVdf23ji23NjlMjWBBymyGC0Z8/ib1Dd4C1cSMuCJgabbKMLj1PW+pW+Y0xk6axmit/19CnHWCZd5SpgzvXV/OrLEMO+WllD3Ip28vQhKs62jMifXE9UodEhXPtG+vctw+nnHTWGc8EaZ+vX4tML3svfeMGa+KMVq73qQFYQjaDRHFDp6GBUSeZiXbJdC1Y6tlNf1rjcKq0eUpD/nIU248jaZvFS1/FEgVhGXsF9yTXsGbyMvc8iHkuibUU6AYND+O2gvtOj6PLYYd39SnfpYZWqKbbhXcqKSocJW2wbe0idAj5KIvvoPeAA3wIEzgN/KD/gm3iVZTrfO7VD5JNzk3k2FSwRtXSTbrAy21i6f1y/+GNlJ3m1KeTZ8TFBdCjxq+aht4TcpbBBMR4N8hq7Jpd8kVUSz/6QBNCcRds9ITqPxdZLJiYUNv3ZpkYcGCE6PxaX2iBP8uSFOPVeSp9ZRm6IDE5GIMq3Eeai2e3g6WeLJIm4sCJ0ExcC6yWOri7qHwCYOcsmSDfr1q/p9LgwUNeSdAA+xHxqYl381Y4SJVPpD53AaZLbUwBGzjAIyA86j/OhR3pW6r5r35+HpgPwQcPHZAeUpPoUk/bfVKwaqelW6UFFAYyId2MlP9vkmIkC1qIG68C6U4MfNeMmvIDwNvxd2R5pVsIkTQ0K/vx4Yb48RG/o+ohMcZQZcxRKCrZT5rITKyMY4iWfSvlZAJVG74ez12Onhxwxus2A7GcoKwkdC8wS4DyIBx2TLCduZp5xpgSh9fzEn131cNPP1loaWUc5azgHR86YWwFnNB57Bf6vJNzuX97ENYC9UqVQjBUS9XeqvuKOd93ihN+GyfkROu5 MAFfAO7m CakktjbbnQRPjcuycgj0CcTTiedYU/FMj74Ww/bnTjoFWPpuqV4yL7fZhBNalduS41W5/KTJxeo59AmXbgeaznyT8+E5pq7rWoJuEvxCDYS+Anrg1/GXAOSAPrsVTQT+8y/Vxo+4E+Brcznp+MlobVhC0pUdaPFab0poZHB4hge1UuNR9WqGnZbYVjAvkkNXpJorFCB6QpJTU0Bu9rf0Qn69sA0ktGRH8cWgolFPmVf/CVr0XBW0rYW91kbsLE8rlF6tmCNVzYeU+BslI5oF16syY8E3ra90QX/rXVxgc09sHMu3MS6QEMP19bK6PQLc8qUBWmj3PQbbIgUFtMupKCTbQ4jTug417cGg/8xIJUygZ1bLeZo9FDDiibWjVN15zxJidTgDf9ch2GpzTSr0VfHeAeCB8pdMInJ5dST45ZF04lHNqlK5po/xgHHnhdhyuxOa9ayHrrcqupXIYaW6jdXmLnZ9EcQJQbcEnIzrrTOkbtlOhJrtaAxIb71yA69DRBEfeoLHDODH0op0jUyBmzUpjdJhTrtzSFJ2pPhj/JRC/R/RYzNxVPLYruDTs4D0ZWwv8N8CfwPv+JJM/+EO5RIXK1Q== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 04:34:56PM +0100, Valentin Schneider wrote: > Later commits will disallow runtime-mutable text in .noinstr sections in > order to safely defer instruction patching IPIs. > > All static keys used in .noinstr sections have now been checked as being > either flagged as __ro_after_init, or as forceful static keys. Any > occurrence of this new warning would be the result of a code change that > will need looking at. > > Suggested-by: Josh Poimboeuf > Signed-off-by: Valentin Schneider > --- > offset_of(static_key.type) and JUMP_TYPE_FORCEFUL would need to be shoved > into a somewhat standalone header file that could be included by objtool > itself. static_key and JUMP_TYPE_* can be moved to jump_label_types.h which can be included by jump_label.h and also synced to tools/include/linux for objtool to access. I guess objtool would have to "#define CONFIG_JUMP_LABEL" before including it to get the full definition. > @@ -3605,6 +3608,41 @@ static int validate_return(struct symbol *func, struct instruction *insn, struct > return 0; > } > > +static bool static_key_is_forceful(struct symbol *key) > +{ > + if (!strcmp(key->sec->name, ".data")) { There are some configs (and more coming in the future) which compile with the kernel with -fdata-sections. So this may need to be something like if (strstarts(key->sec->name, ".data")) -- Josh