From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CA770D711B4 for ; Wed, 20 Nov 2024 15:44:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 664D66B0092; Wed, 20 Nov 2024 10:44:53 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 614586B0093; Wed, 20 Nov 2024 10:44:53 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4B6C96B0095; Wed, 20 Nov 2024 10:44:53 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27DD76B0092 for ; Wed, 20 Nov 2024 10:44:53 -0500 (EST) Received: from smtpin10.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay10.hostedemail.com (Postfix) with ESMTP id CEAB6C0D1D for ; Wed, 20 Nov 2024 15:44:52 +0000 (UTC) X-FDA: 82806894828.10.EA86C13 Received: from smtp-out1.suse.de (smtp-out1.suse.de [195.135.223.130]) by imf04.hostedemail.com (Postfix) with ESMTP id 3BDF840012 for ; Wed, 20 Nov 2024 15:43:44 +0000 (UTC) Authentication-Results: imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JvPVwTtd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="GDl/w4KP"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZRaT9ur+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tIemCaNb; dmarc=none; spf=pass (imf04.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732117305; a=rsa-sha256; cv=none; b=ZjqcddM4suSYcOufrsazvtQwnwSi25o7AodTlYeJ0tGD8SBI23oXXpzZrejfF0jWpccnXD agE1/raIVZwkGyiIwoUTBCrOHgUCo7zsygvsTqW0rMXHFpmZ+nPTwmh84lLN7hSYcQA7ud 32v9l3k1XfoO/raJPAV6TsCoI7ikuTY= ARC-Authentication-Results: i=1; imf04.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=JvPVwTtd; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b="GDl/w4KP"; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ZRaT9ur+; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=tIemCaNb; dmarc=none; spf=pass (imf04.hostedemail.com: domain of jack@suse.cz designates 195.135.223.130 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732117305; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=Fj7fJmtXRZ0FYhZKsaGUvpP5NpR+kcXv8aPZO9BcWjs=; b=jj103hcrsmkL3Bw01iG9YK78sB523M64Bcn75KVnSvXHN/c4YMBhwXGbaZRIhYc/QYnybs 7oghMEghBASVVD+Nr9xZmrDlDP7pMjPEMzu8deZdvXhgwrBCyMpxJLEnJ+gVZMnsSCfHtQ xYuZjCNoSyLZVu8J4+nbFRO1dhHyURU= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id D890E21851; Wed, 20 Nov 2024 15:44:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732117489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fj7fJmtXRZ0FYhZKsaGUvpP5NpR+kcXv8aPZO9BcWjs=; b=JvPVwTtd+MbQta7TYhE3Ky1Ptg76578DHL7fgJRnuwS7+EsjvTqcU9i6o/WXzmJeE8/N95 JTJEubWc7cKSXekkbiWLr+8QeuQdxF+/wJiMi6nwYwC5pWCC0UzVWiJe+/xVjkJvFm102q QPn0uqXaz5J8MFw/Gyn1KBh6Ri7hPJM= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732117489; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fj7fJmtXRZ0FYhZKsaGUvpP5NpR+kcXv8aPZO9BcWjs=; b=GDl/w4KP2hGUTusRS1+ZfEgiwAUkAFE7fTbWakvs4pkVQ/H47OQoRNBfl3lIN48Yb5kSaR 2U98Oty+38009eBA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1732117488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fj7fJmtXRZ0FYhZKsaGUvpP5NpR+kcXv8aPZO9BcWjs=; b=ZRaT9ur+uK+GrsNe98Ae5xAKSdHwwjOYsXnh6vWZb1aFjfSwIzfHP/4a4g/pdKEw75/OyK zJBz4RsXJKCF3N028EuaJAmy61D/hRCHFNWsNjv68myNwsg10F19QCy9B6e6aEUCOngJlp Vhu6nqNIAHlv6S9h2ahehApZHEML1mE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1732117488; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Fj7fJmtXRZ0FYhZKsaGUvpP5NpR+kcXv8aPZO9BcWjs=; b=tIemCaNb8aws/6zZYsoCT7z2+fWPQLWYSWUcsZXfzESgYYnxicFjdPaZoU4OwfyQCt+kQR +VBn1euU5mRMU2Ag== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id C9BF113297; Wed, 20 Nov 2024 15:44:48 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id /Og8MfADPmfhSAAAD6G6ig (envelope-from ); Wed, 20 Nov 2024 15:44:48 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id 80F8CA08A2; Wed, 20 Nov 2024 16:44:48 +0100 (CET) Date: Wed, 20 Nov 2024 16:44:48 +0100 From: Jan Kara To: Josef Bacik Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 13/19] fanotify: add a helper to check for pre content events Message-ID: <20241120154448.onc2q5rsusfs4zsm@quack3> References: <657f50e37d6d8f908c13f652129bcdd34ed7f4a9.1731684329.git.josef@toxicpanda.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <657f50e37d6d8f908c13f652129bcdd34ed7f4a9.1731684329.git.josef@toxicpanda.com> X-Rspamd-Action: no action X-Stat-Signature: m9sffjc8btt8utq8hb3tujk6kg363ied X-Rspamd-Queue-Id: 3BDF840012 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1732117424-935564 X-HE-Meta: U2FsdGVkX1/Njl6NLQl0pQuHOqHP3lJy5RnkN0HwYktt6lUWiz3bmxgr03QX7V/MU6X8z/sZb0gEhAdLnEZpXxdBqGhzEgGl6vUW5Fsk5DNqfX60k42hs+ph+eyr1kTodxBo+1pA8jMA79jK9cx2687in0SI2IA0HDvmuSHgApOzAD5CusSAfqyhEF/vf/B7jsjOc0D7Qpks1NhtcI0JRNhhBBz/FGbBBY65ZXQu7pdFbysMhPxrQUQydG19qPsOd6St9/lDgXto+F/Dm4UKk7EJUAe6Ji9QYMwXRU2wdXPHZI7BQhhtLM6eQKVfzrjMAudmNteNieqx1SoVQTLJ3T/yR9N21xZ/HDerSnq8LsuMbOSIPSUT9Sgg/o/VH1E7tqst8M9DVBn6WvQa75pvFwHHunQp2v4ujSFpMti5a8D/07yIqqEfFIxc4jXUTP1CIhVx4hDPMgveK+93bsHAVlXJKXEIHfHvs7Y3VwaAt4LM7c80iCh6f1RQMzTGKzPzJEOb2M67QsUvzOK00TeoZkMkZrOX2Y2ut8M2NS9yNTJAoLwHbIE/TxFz5JDMlpGlbQSJMLb3FK4szLsn/Ik4s7XZrqHj3Kap51IWH5LvFduJlP3Ku0lkHnahnvMupLk00NdYTnVCLTeqzqwuIYu5LrfKRlVbeSzPx1YO9+TKe/YNxZOLORmor7X80XYPk1SvM/fOI0+qoHHRVcaDM+n9kL65Xhe1tbag4m2RV/mZ4KbP2H9LkbQDdvJ5bwevrlOrkrFgWSDAbkVlr/99Vjz3JWdcN6IELcRUhj0EFM3ssHcdZgQx2Zx7MV8eAYhEyEcds8ubAfAZvE4l3fGw3KCXtlxFMOK50p6h5t1sbIL2H7RJedS6H+kH7wxTF1n8vbDmb0mwjlCEqqV71o78XRbzu8ESpXIov7e+5bJtO5nDtZTOi+xYI3S/NQiirFsHgwA/gjgUDMlzDxnSAnqTeh5 subRA5+P Q9wGJ9iyJdRqKWPYrM71P9pAjQZy4gjyZKmk5Ma9rMiMm42v9LNhxsDJv1ohKJkOVBbgALeS3vC8CnSINWd7/PcGqHElTU1DFUlCNxBAgT51CmWOG14UO6b0j46fYpwOYFBrDjZ5R1n9QYifsItWFEt8p/I1bIJ2AYsMQHN4WLxz0om2P7CA10rGTPoe7zSm54fRPSeJJkN8LZwGpuGMXUt0jCxRK4LyHbK8RN/zcmdAacL2SsmvQ6xsdBu7OmPBcMhFof+i6ROanDhBLN8p5tvpeBo2C7kwLJ1IELT4h6ue3/f1fh4qJmkySGDkfik4EZH7kfvZQu+v48R5q31wsQStC9ey+j0D3sOC0uCiOjLz9lg1CDZj/2tYeqKPAXq/0TYlT08fASp3kPe7N4KuawXA8iJNHtyEbRh+WLsDERflCC5s= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 15-11-24 10:30:26, Josef Bacik wrote: > From: Amir Goldstein > > We want to emit events during page fault, and calling into fanotify > could be expensive, so add a helper to allow us to skip calling into > fanotify from page fault. This will also be used to disable readahead > for content watched files which will be handled in a subsequent patch. > > Signed-off-by: Josef Bacik > Signed-off-by: Amir Goldstein > --- > include/linux/fsnotify.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/linux/fsnotify.h b/include/linux/fsnotify.h > index 08893429a818..d5a0d8648000 100644 > --- a/include/linux/fsnotify.h > +++ b/include/linux/fsnotify.h > @@ -178,6 +178,11 @@ static inline void file_set_fsnotify_mode(struct file *file) > } > } > > +static inline bool fsnotify_file_has_pre_content_watches(struct file *file) > +{ > + return file && unlikely(FMODE_FSNOTIFY_HSM(file->f_mode)); > +} > + I was pondering about this and since we are trying to make these quick checks more explicit, I'll probably drop this helper. Also the 'file &&' part looks strange (I understand page_cache_[a]sync_ra() need it but I'd rather handle it explicitely there). Honza -- Jan Kara SUSE Labs, CR