From: Alice Ryhl <aliceryhl@google.com>
To: Miguel Ojeda <ojeda@kernel.org>,
Matthew Wilcox <willy@infradead.org>,
Lorenzo Stoakes <lorenzo.stoakes@oracle.com>,
Vlastimil Babka <vbabka@suse.cz>,
John Hubbard <jhubbard@nvidia.com>,
"Liam R. Howlett" <Liam.Howlett@oracle.com>,
Andrew Morton <akpm@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Christian Brauner <brauner@kernel.org>
Cc: "Alex Gaynor" <alex.gaynor@gmail.com>,
"Boqun Feng" <boqun.feng@gmail.com>,
"Gary Guo" <gary@garyguo.net>,
"Björn Roy Baron" <bjorn3_gh@protonmail.com>,
"Benno Lossin" <benno.lossin@proton.me>,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
rust-for-linux@vger.kernel.org,
"Alice Ryhl" <aliceryhl@google.com>,
"Andreas Hindborg" <a.hindborg@kernel.org>
Subject: [PATCH v8 7/7] rust: miscdevice: add mmap support
Date: Wed, 20 Nov 2024 14:50:01 +0000 [thread overview]
Message-ID: <20241120-vma-v8-7-eb31425da66b@google.com> (raw)
In-Reply-To: <20241120-vma-v8-0-eb31425da66b@google.com>
Using the vma support introduced by the previous commit, introduce mmap
support for miscdevices. The mmap call is given a vma that is undergoing
initial setup, so the VmAreaNew type is used.
Signed-off-by: Alice Ryhl <aliceryhl@google.com>
---
rust/kernel/miscdevice.rs | 28 ++++++++++++++++++++++++++++
1 file changed, 28 insertions(+)
diff --git a/rust/kernel/miscdevice.rs b/rust/kernel/miscdevice.rs
index 7e2a79b3ae26..4e4b9476e092 100644
--- a/rust/kernel/miscdevice.rs
+++ b/rust/kernel/miscdevice.rs
@@ -11,6 +11,7 @@
use crate::{
bindings,
error::{to_result, Error, Result, VTABLE_DEFAULT_ERROR},
+ mm::virt::VmAreaNew,
prelude::*,
str::CStr,
types::{ForeignOwnable, Opaque},
@@ -110,6 +111,11 @@ fn release(device: Self::Ptr) {
drop(device);
}
+ /// Handle for mmap.
+ fn mmap(_device: <Self::Ptr as ForeignOwnable>::Borrowed<'_>, _vma: &VmAreaNew) -> Result {
+ kernel::build_error(VTABLE_DEFAULT_ERROR)
+ }
+
/// Handler for ioctls.
///
/// The `cmd` argument is usually manipulated using the utilties in [`kernel::ioctl`].
@@ -156,6 +162,7 @@ impl<T: MiscDevice> VtableHelper<T> {
const VTABLE: bindings::file_operations = bindings::file_operations {
open: Some(fops_open::<T>),
release: Some(fops_release::<T>),
+ mmap: maybe_fn(T::HAS_MMAP, fops_mmap::<T>),
unlocked_ioctl: maybe_fn(T::HAS_IOCTL, fops_ioctl::<T>),
#[cfg(CONFIG_COMPAT)]
compat_ioctl: if T::HAS_COMPAT_IOCTL {
@@ -216,6 +223,27 @@ impl<T: MiscDevice> VtableHelper<T> {
0
}
+/// # Safety
+///
+/// `file` must be a valid file that is associated with a `MiscDeviceRegistration<T>`.
+/// `vma` must be a vma that is currently being mmap'ed with this file.
+unsafe extern "C" fn fops_mmap<T: MiscDevice>(
+ file: *mut bindings::file,
+ vma: *mut bindings::vm_area_struct,
+) -> c_int {
+ // SAFETY: The mmap call of a file can access the private data.
+ let private = unsafe { (*file).private_data };
+ // SAFETY: Mmap calls can borrow the private data of the file.
+ let device = unsafe { <T::Ptr as ForeignOwnable>::borrow(private) };
+ // SAFETY: The caller provides a vma that is undergoing initial VMA setup.
+ let area = unsafe { VmAreaNew::from_raw(vma) };
+
+ match T::mmap(device, area) {
+ Ok(()) => 0,
+ Err(err) => err.to_errno() as c_int,
+ }
+}
+
/// # Safety
///
/// `file` must be a valid file that is associated with a `MiscDeviceRegistration<T>`.
--
2.47.0.371.ga323438b13-goog
next prev parent reply other threads:[~2024-11-20 14:56 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-20 14:49 [PATCH v8 0/7] Rust support for mm_struct, vm_area_struct, and mmap Alice Ryhl
2024-11-20 14:49 ` [PATCH v8 1/7] mm: rust: add abstraction for struct mm_struct Alice Ryhl
2024-11-20 18:13 ` Lorenzo Stoakes
2024-11-21 9:52 ` Alice Ryhl
2024-11-21 12:37 ` Lorenzo Stoakes
2024-11-21 14:35 ` Alice Ryhl
2024-11-22 7:42 ` Paolo Bonzini
2024-11-22 17:41 ` Lorenzo Stoakes
2024-11-20 14:49 ` [PATCH v8 2/7] mm: rust: add vm_area_struct methods that require read access Alice Ryhl
2024-11-20 19:07 ` Lorenzo Stoakes
2024-11-21 10:23 ` Alice Ryhl
2024-11-21 12:50 ` Lorenzo Stoakes
2024-11-21 14:39 ` Alice Ryhl
2024-11-20 14:49 ` [PATCH v8 3/7] mm: rust: add vm_insert_page Alice Ryhl
2024-11-20 19:20 ` Lorenzo Stoakes
2024-11-21 10:38 ` Alice Ryhl
2024-11-21 12:55 ` Lorenzo Stoakes
2024-11-20 14:49 ` [PATCH v8 4/7] mm: rust: add lock_vma_under_rcu Alice Ryhl
2024-11-20 19:29 ` Lorenzo Stoakes
2024-11-21 10:44 ` Alice Ryhl
2024-11-21 12:59 ` Lorenzo Stoakes
2024-11-20 14:49 ` [PATCH v8 5/7] mm: rust: add mmput_async support Alice Ryhl
2024-11-20 19:46 ` Lorenzo Stoakes
2024-11-21 11:39 ` Alice Ryhl
2024-11-21 13:04 ` Lorenzo Stoakes
2024-11-21 13:04 ` Lorenzo Stoakes
2024-11-20 14:50 ` [PATCH v8 6/7] mm: rust: add VmAreaNew Alice Ryhl
2024-11-20 20:02 ` Lorenzo Stoakes
2024-11-21 11:47 ` Alice Ryhl
2024-11-21 13:08 ` Lorenzo Stoakes
2024-11-20 14:50 ` Alice Ryhl [this message]
2024-11-20 20:07 ` [PATCH v8 7/7] rust: miscdevice: add mmap support Lorenzo Stoakes
2024-11-21 10:08 ` Alice Ryhl
2024-11-21 13:11 ` Lorenzo Stoakes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241120-vma-v8-7-eb31425da66b@google.com \
--to=aliceryhl@google.com \
--cc=Liam.Howlett@oracle.com \
--cc=a.hindborg@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.gaynor@gmail.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=brauner@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=jhubbard@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lorenzo.stoakes@oracle.com \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=vbabka@suse.cz \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox