From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E3410D6C295 for ; Tue, 19 Nov 2024 20:38:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 527D26B007B; Tue, 19 Nov 2024 15:38:16 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4D7CE6B0082; Tue, 19 Nov 2024 15:38:16 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F3D6B0083; Tue, 19 Nov 2024 15:38:16 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 17A1F6B007B for ; Tue, 19 Nov 2024 15:38:16 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 9C6DD12061A for ; Tue, 19 Nov 2024 20:38:15 +0000 (UTC) X-FDA: 82804004766.27.0F7239B Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf22.hostedemail.com (Postfix) with ESMTP id BC49CC0024 for ; Tue, 19 Nov 2024 20:37:10 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bqgdvrBa; spf=pass (imf22.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732048449; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=n8N3rn8XTYssLGvNOxJ01ekVxhkzpoG5X0kuGNrntRE=; b=YndFW6P2NoUA/cFzobH22BswZbzNST/fXe3aZBOqIPQO4BShPwv2PHDtHdOWEYm22lDght McdRUyukmw+QvzT823X7atRAXDXV99ZRoXubBgGe4JxElG3RHy1tvQ6E2Zcbnf89RZoKEt C7bDmjN72m7wFyHPiZK6LgGiolyjLh8= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=bqgdvrBa; spf=pass (imf22.hostedemail.com: domain of jpoimboe@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=jpoimboe@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732048449; a=rsa-sha256; cv=none; b=5F+WQ5lSucoz6GTbcjoqbn3B9L9E/INmuLmosfwtG5PrH2ykEUJfHPlt+3dlKeQHnTNAAW /F3Yuhc9ZkjtghzFV/mTZ2NnSeJ5niM7OaKJkvrpns9cYiUfOvTAK6122Up7dU0n39CP1E JQXEizAA4ciu9uzZatwI8ebF9KKfcHc= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id DBD765C55FD; Tue, 19 Nov 2024 20:37:28 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8FDC1C4CECF; Tue, 19 Nov 2024 20:38:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732048692; bh=aZtx8D0JIDJUy4jb6paGGJ/YMK9y9mdX3qt+a6Plzbw=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=bqgdvrBaiDxMyjQzGHu5p8KD0C93igpPKRnUy5UtfEkVZeMzkIQnh6cOad/ipuMEy njpfahWj2R+Pw7cFV/WOF3ln/QTjXH6a10DMilFsgRWhnLiymRWLkgI4WHjk7UWhVO t3SicS6vDAbW1mWdeQbBEPdaPSutxU3lpYTvB+wylx3hxuogimYFLPm2J+H/cv25CB ya04g52bgAmigcw7PCCBUL/QtnTsn1pWHVHOKQZM4cor/+Kdsrr1gXdNn+XJ4IDSdd HY5mKjOk90Yh8I/NZniAmGJGWiWuzfbser0fX1fvvnhQUWi6aetB+obxHsJ8dDzcR+ 7ATtWmfHSb1uw== Date: Tue, 19 Nov 2024 12:38:08 -0800 From: Josh Poimboeuf To: Valentin Schneider Cc: linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, bpf@vger.kernel.org, x86@kernel.org, rcu@vger.kernel.org, linux-kselftest@vger.kernel.org, Steven Rostedt , Masami Hiramatsu , Jonathan Corbet , Thomas Gleixner , Ingo Molnar , Borislav Petkov , Dave Hansen , "H. Peter Anvin" , Paolo Bonzini , Wanpeng Li , Vitaly Kuznetsov , Andy Lutomirski , Peter Zijlstra , Frederic Weisbecker , "Paul E. McKenney" , Neeraj Upadhyay , Joel Fernandes , Josh Triplett , Boqun Feng , Mathieu Desnoyers , Lai Jiangshan , Zqiang , Andrew Morton , Uladzislau Rezki , Christoph Hellwig , Lorenzo Stoakes , Jason Baron , Kees Cook , Sami Tolvanen , Ard Biesheuvel , Nicholas Piggin , Juerg Haefliger , Nicolas Saenz Julienne , "Kirill A. Shutemov" , Nadav Amit , Dan Carpenter , Chuang Wang , Yang Jihong , Petr Mladek , "Jason A. Donenfeld" , Song Liu , Julian Pidancet , Tom Lendacky , Dionna Glaze , Thomas =?utf-8?Q?Wei=C3=9Fschuh?= , Juri Lelli , Marcelo Tosatti , Yair Podemsky , Daniel Wagner , Petr Tesarik Subject: Re: [RFC PATCH v3 01/15] objtool: Make validate_call() recognize indirect calls to pv_ops[] Message-ID: <20241119203808.rb2yfqbuin35iye3@jpoimboe> References: <20241119153502.41361-1-vschneid@redhat.com> <20241119153502.41361-2-vschneid@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20241119153502.41361-2-vschneid@redhat.com> X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: BC49CC0024 X-Stat-Signature: 6w5ztnkdt5r6h5e39q6n3mnjkf71hjd6 X-Rspam-User: X-HE-Tag: 1732048630-321309 X-HE-Meta: U2FsdGVkX1/zYULnmlGC8eLxBeH7RK7yIp8Jrr3jVTlLX5/B0i0R0P3ks38B01wp7cfdtnRZJ+ddwxhC90KGNfrXEEfDOib6FT1tyLCMPCJE5K5zewSlBBLmUl3hoz0hWBm8rz9ogtGSIuD0htZMFas66KhPhvaUwp4+T7EzjyINRHuOSHdI39LX1D8AwkYxA+g9ijQKvshm+BNuFr6AS7kv1mNBZIztmFzL3t6aPAj45IDR7FyjZV+xseF0FIhh/T7Gg3RPiRRs0wbawGTmFIYO4N/ecEZhuV3MImK5oK+pHgFBC4BqbpZ7AJzJAZgcToTgUlnMScA2TZC12Bb28KJjU2kr+YmXxEmOwr09UzgbuX+kO4FNvsKjaML1fE3ZfbioHH4avmwcFdz0FUoRf1i7VasBk619CBW5w64z17cB+XEryFwrjjHcH4JjT917IWhehnBgio+Uuggbfh2SltNmeHHOQA9xbvloHCQukO8wENIHl/4zaohmxHUj41OigVrKsLat7cFODoN9k6c5y6G1iE0kuI1d3Tw0/LJYGFcq+WMleFYRC+hprjEEfvOX4z6faIxjuqz4fF9IhOd/G58gz5uwqwGYkuUWg3D3z/C1HNE+VuC301zWnaTZJLONOJPGcuLuNzm0Vb1rwayJqg3xGPtiATQQV/evINOUdIrZsRHtz/pn2ndFWx5y0TmxNkCVls5RFwVZO9AKowV2aM02D1E2njxxYAEGZjg0Ur/yrN5KfLnJbLtwQ3hn5w32W94anHTYWEv8oKbInp18vh5bilm4gl3kQhKPmIcwQRfBCCWYcFxC1SNy5R8GOib+s6LBTJf0Qk6Stdq6Rtew11ryvcp/NbmS+QpZ/JPQBbTfkxyTBoeuSWKlr+ZAEeUGZb4p2sur7AYnS3rIlE0vQEKuvUqjZj+CHWY4s68DUf5xtsVYAK7T4AaVS4rAVqRvHOVN6S5Qa7OrvnQ0pA8 4AOfaibj /7yExdAhk/+K8oJI1PJQpR0HGZmEXjiL7aupfZcC6XQeZLO9xwZUyjnhV+/Cj5jW0RJzpB30txj9xGgM7qa9dCmwnNWQ5kn/CMPd4tC2Up47LWcolPqyCBwqDk/G1OLX1cY3a1MlVIJvgUrdmUjIT3J1WBHGl5/PRIUNjR2CwDNZRKL6eZybVfjRpO7Rd6tqt3ucGRRFXOx8aMa1udRPGA+rumR11t3RowhEd68A/Fek+2LqQ4GI5Zw/UZPIGyq/5kbI/6N+TBVxlWbp9iB0tnSFdGaHWaupBIWJIyCpOcLO9PKTw7t+TYIXVr+Nd417hkPlmRK9FEZuJzBAJ0L6TuIkf5X43dbiOiIAjwtCMMHYr0sUoJ85rDEX0aKT6kIgN9fHTy7RnXj+vZmll3Ohpahh0vCvfNyUJFuH0WZY/7IT/rYRAmbBVtFjfCJ987AJADU0LAxtbye1uUz1fjab+Jko5IQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 04:34:48PM +0100, Valentin Schneider wrote: > call_dest_name() does not get passed the file pointer of validate_call(), > which means its invocation of insn_reloc() will always return NULL. Make it > take a file pointer. > > While at it, make sure call_dest_name() uses arch_dest_reloc_offset(), > otherwise it gets the pv_ops[] offset wrong. > > Fabricating an intentional warning shows the change; previously: > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: call to {dynamic}() leaves .noinstr.text section > > now: > > vmlinux.o: warning: objtool: __flush_tlb_all_noinstr+0x4: call to pv_ops[1]() leaves .noinstr.text section > > Signed-off-by: Valentin Schneider Acked-by: Josh Poimboeuf -- Josh