* [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()
@ 2024-11-19 11:59 winterver
2024-11-19 12:59 ` David Hildenbrand
2024-11-19 19:13 ` SeongJae Park
0 siblings, 2 replies; 4+ messages in thread
From: winterver @ 2024-11-19 11:59 UTC (permalink / raw)
To: akpm; +Cc: linux-mm, linux-kernel, Jiale Yang
From: Jiale Yang <295107659@qq.com>
Remove 'return;' at the end of void cma_activate_area(). It's a void
function, so an ending return statement is unnecessary.
Signed-off-by: Jiale Yang <295107659@qq.com>
---
mm/cma.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/mm/cma.c b/mm/cma.c
index 2d9fae939..070399bce 100644
--- a/mm/cma.c
+++ b/mm/cma.c
@@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
totalcma_pages -= cma->count;
cma->count = 0;
pr_err("CMA area %s could not be activated\n", cma->name);
- return;
}
static int __init cma_init_reserved_areas(void)
--
2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()
2024-11-19 11:59 [PATCH] mm: Remove 'return;' at the end of void cma_activate_area() winterver
@ 2024-11-19 12:59 ` David Hildenbrand
2024-11-19 19:13 ` SeongJae Park
1 sibling, 0 replies; 4+ messages in thread
From: David Hildenbrand @ 2024-11-19 12:59 UTC (permalink / raw)
To: winterver, akpm; +Cc: linux-mm, linux-kernel
On 19.11.24 12:59, winterver wrote:
> From: Jiale Yang <295107659@qq.com>
>
> Remove 'return;' at the end of void cma_activate_area(). It's a void
> function, so an ending return statement is unnecessary.
>
> Signed-off-by: Jiale Yang <295107659@qq.com>
> ---
> mm/cma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939..070399bce 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
> totalcma_pages -= cma->count;
> cma->count = 0;
> pr_err("CMA area %s could not be activated\n", cma->name);
> - return;
> }
>
> static int __init cma_init_reserved_areas(void)
Reviewed-by: David Hildenbrand <david@redhat.com>
--
Cheers,
David / dhildenb
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()
2024-11-19 11:59 [PATCH] mm: Remove 'return;' at the end of void cma_activate_area() winterver
2024-11-19 12:59 ` David Hildenbrand
@ 2024-11-19 19:13 ` SeongJae Park
2024-11-20 4:39 ` Pintu Agarwal
1 sibling, 1 reply; 4+ messages in thread
From: SeongJae Park @ 2024-11-19 19:13 UTC (permalink / raw)
To: winterver; +Cc: SeongJae Park, akpm, linux-mm, linux-kernel, Pintu Kumar
Hello,
On Tue, 19 Nov 2024 19:59:40 +0800 winterver <295107659@qq.com> wrote:
> From: Jiale Yang <295107659@qq.com>
>
> Remove 'return;' at the end of void cma_activate_area(). It's a void
> function, so an ending return statement is unnecessary.
>
> Signed-off-by: Jiale Yang <295107659@qq.com>
> ---
> mm/cma.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/mm/cma.c b/mm/cma.c
> index 2d9fae939..070399bce 100644
> --- a/mm/cma.c
> +++ b/mm/cma.c
> @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
> totalcma_pages -= cma->count;
> cma->count = 0;
> pr_err("CMA area %s could not be activated\n", cma->name);
> - return;
> }
Looks good to me. But, seems a same change[1] from Pintu Kumar has already
merged into mm-unstable?
[1] https://lore.kernel.org/20240927181637.19941-1-quic_pintu@quicinc.com
Thanks,
SJ
>
> static int __init cma_init_reserved_areas(void)
> --
> 2.43.0
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area()
2024-11-19 19:13 ` SeongJae Park
@ 2024-11-20 4:39 ` Pintu Agarwal
0 siblings, 0 replies; 4+ messages in thread
From: Pintu Agarwal @ 2024-11-20 4:39 UTC (permalink / raw)
To: SeongJae Park; +Cc: winterver, akpm, linux-mm, linux-kernel, Pintu Kumar
On Wed, 20 Nov 2024 at 00:43, SeongJae Park <sj@kernel.org> wrote:
>
> Hello,
>
> On Tue, 19 Nov 2024 19:59:40 +0800 winterver <295107659@qq.com> wrote:
>
> > From: Jiale Yang <295107659@qq.com>
> >
> > Remove 'return;' at the end of void cma_activate_area(). It's a void
> > function, so an ending return statement is unnecessary.
> >
> > Signed-off-by: Jiale Yang <295107659@qq.com>
> > ---
> > mm/cma.c | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/mm/cma.c b/mm/cma.c
> > index 2d9fae939..070399bce 100644
> > --- a/mm/cma.c
> > +++ b/mm/cma.c
> > @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma)
> > totalcma_pages -= cma->count;
> > cma->count = 0;
> > pr_err("CMA area %s could not be activated\n", cma->name);
> > - return;
> > }
>
> Looks good to me. But, seems a same change[1] from Pintu Kumar has already
> merged into mm-unstable?
>
> [1] https://lore.kernel.org/20240927181637.19941-1-quic_pintu@quicinc.com
>
Yes, this [1] is already part of linux-next now.
[1] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git/commit/?h=next-20241118&id=1fa00a568d113db279f683f40636cf72cf73a55d
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2024-11-20 4:40 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-11-19 11:59 [PATCH] mm: Remove 'return;' at the end of void cma_activate_area() winterver
2024-11-19 12:59 ` David Hildenbrand
2024-11-19 19:13 ` SeongJae Park
2024-11-20 4:39 ` Pintu Agarwal
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox