From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2592ED6C28B for ; Tue, 19 Nov 2024 19:13:52 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id A1A166B0083; Tue, 19 Nov 2024 14:13:51 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9F1A66B0088; Tue, 19 Nov 2024 14:13:51 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8B8C86B0089; Tue, 19 Nov 2024 14:13:51 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 6EBF86B0083 for ; Tue, 19 Nov 2024 14:13:51 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 172DE1207B6 for ; Tue, 19 Nov 2024 19:13:51 +0000 (UTC) X-FDA: 82803790734.20.B93F5F2 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf26.hostedemail.com (Postfix) with ESMTP id 13096140018 for ; Tue, 19 Nov 2024 19:13:10 +0000 (UTC) Authentication-Results: imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MTtdukzZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732043563; a=rsa-sha256; cv=none; b=cYv8lMFDmanxLiTmA10LxrRI8A654mxNO+5vE6JVapqWg+le+7yuu0CtOC6NHclSssMytL 5KK4byjb7OXj3hQfyvPwvww6U1b65v4GhiCnxtR1ShlGyQT+NU2yFAFxdwDGPr4foGn/jd o9Y6ouEwWUPc+nIDHzxaWftlsWQGe6A= ARC-Authentication-Results: i=1; imf26.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=MTtdukzZ; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf26.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732043563; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=r/Rr3ZHdAG33UxHyMlS70KplDI6SjyzKnmg30dB42Vg=; b=KrQVjnHRd9f/FTl4+M4EWgHNR6mkADwAdMe7c1d8eV0wtxUbjyNSPtdExDORtY9iE4+MzY G2kAdp9xxh62DKqkc6o7v9kyn7SjV+YM6aWwNCfFXvRoKw78ztzgLFTRkNbBzt9VJoP3ad N56Ugk6z6cv/KZmhlKsJ2DqSO+43sEA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 20B62A42DFF; Tue, 19 Nov 2024 19:11:55 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 28F8EC4CECF; Tue, 19 Nov 2024 19:13:48 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732043628; bh=VEcFKydOK/gXlariFXvoqJXD5+TMm17xBu0XVyVfVrQ=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=MTtdukzZI1q2lNyJ69t15/PvCdEf+yPGFke4kFLvxCYwmauJbXkwcppBix8fBMm/t pxTL2hDjziHwuYFIYfWMDAwbT/a2nWlbulVAKEOE0JFJcIf+SRyB8YsmjRuZ//I9qU +EgN/hbJEVAkKrtAbdWWlOTX8if5VaNUtnphkiej+VHdblNXOiKGGYKGpZEI36uAwP XgxYSJP60uR/v0lTl3z+YH/3z+/V4/SROaAsBrjCdzWMUl0BUfDImXFoSl1mIfvico 5B21REFHwDoI2/YR5t97tgqmKe7z91z5uUr7ulaxi/rSvt0JwGcU6kCeF/PA6OD1hL 4WxPUB+PSBbNw== From: SeongJae Park To: winterver <295107659@qq.com> Cc: SeongJae Park , akpm@linux-foundation.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Pintu Kumar Subject: Re: [PATCH] mm: Remove 'return;' at the end of void cma_activate_area() Date: Tue, 19 Nov 2024 11:13:44 -0800 Message-Id: <20241119191344.53712-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Queue-Id: 13096140018 X-Rspamd-Server: rspam01 X-Stat-Signature: dk4qasrbcqh3dt1n1bzsdwfnzgs6e7ot X-HE-Tag: 1732043590-391791 X-HE-Meta: U2FsdGVkX18JW37To7SWC8Obw9iLcJUy6cCoQIP/7PPL2buBfLszG5M+7zVmlxLL0TaFgWWwGIIFqHUktj7B1CRUEniJi7cRPnUbsUbUbxgJT8gXpGXImuTK6Os7ornblr61EyvV1OkIqb8T6LU8rYOHTysHY7siJVDW784jfvEfZ0FAnuDMhFxFydG664ukYssj2QKJAM6n8xEqTNLpilmdoi7D5JiET+CTh2t5ZwZXFwerdM1xa/nbHYOyeSkgV0S3ojwQPk9pWkVhGfItsD9oh32+d3ZPlvyu6rV3+cxjYqZ9B+bWfM0qrVJEtTwfJX0lbEf/BIZfKSHu4gF021ZmLb+ldJ0gyw599dUMkwTRkkp9IL4ed0zDo1Hydbd0cviLzpdkvuEWB3D0VFwA9yFtA3I5Xq7yqyFiTz1xi29OUUBrWWEvBWVtzpbgl7jU7kA8cXzOinuwHOW7ro1pzavVBlm9nSWmn0XUt1r6n9S5frUDLoolnYfN7IW6SJ/INFY1NTudQv9qNaGEklkC1G7BVrCYm65TPllM3lYEDEnbKycNR3tC/r17iqPfbdqJwUuQ3/zdHK5e9cA/L+6Nci4x2Ca5vVbOZtNdQvNbuudDFIlzwvyob2xdZ02P/vvQyQwdOTFgxknTh1iZVe9r2d1Lj660+mW+wEF9RdK8xQfY99Qup6Z127vF6Qlix4NOpSNS8laCRHL9rb10u31HuLJ5UorCtYR3Hu6ruz5AJg70bRXvawiEjZ9CRoW4+MWNJyaMoJ73N48y61FFVNC1BCKl3nsVnRRGUWVzHFdinnZy20gdBn4sDYeHyenMs5tfZ2LzLjCvo0yAkZ87Hldoty23085CAiP7G8cSOhRk3DGN+iAt0iRUCEPF/XmRIo5enZxM8A4pcplOq2tg/hcGnlNwZlz4AdGdMXR71sBazlHqpkZPQ5+akuNL4OzirNWL9agOf5ukf7J7tOiEroF 9e49CDWX 3qk7yvR7zwPmhUw8PhdiN2QvL62f5RVL7qA4lCQQd6HUUK53m43KbmbMiQlJqHRnEWYus3KF/YU4vrKRyW+KOE3GcJiqhYqzdW4dsWz5IvpQzZ8jo/tu0IwieGi3RbYa89XzLPT8Y4s2a2TI10+5VbPV3mDVHYLzBK+AsPnJKiJDx9qNA0IfUrRCKiNIFgOarUMTJoXeZLhVjGhs/IOwxZsGgaXNAd8Sfv7Z/LzcqdeVAKe56w9yAqJbVXuN5cPW8PYN3Kd87uC9kcjuRujJMpZWInhoWpjiYITkAZp+7I4hp828RQBbkzcFV6IHig/QREuIx2X2S/miMymE6Vzdvb7n4JiCsZ3J/cRIj+62Yyn7v0vQ= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hello, On Tue, 19 Nov 2024 19:59:40 +0800 winterver <295107659@qq.com> wrote: > From: Jiale Yang <295107659@qq.com> > > Remove 'return;' at the end of void cma_activate_area(). It's a void > function, so an ending return statement is unnecessary. > > Signed-off-by: Jiale Yang <295107659@qq.com> > --- > mm/cma.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/mm/cma.c b/mm/cma.c > index 2d9fae939..070399bce 100644 > --- a/mm/cma.c > +++ b/mm/cma.c > @@ -135,7 +135,6 @@ static void __init cma_activate_area(struct cma *cma) > totalcma_pages -= cma->count; > cma->count = 0; > pr_err("CMA area %s could not be activated\n", cma->name); > - return; > } Looks good to me. But, seems a same change[1] from Pintu Kumar has already merged into mm-unstable? [1] https://lore.kernel.org/20240927181637.19941-1-quic_pintu@quicinc.com Thanks, SJ > > static int __init cma_init_reserved_areas(void) > -- > 2.43.0