From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EA0A8D6C281 for ; Tue, 19 Nov 2024 17:54:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5BBAD6B0082; Tue, 19 Nov 2024 12:54:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 56B856B0083; Tue, 19 Nov 2024 12:54:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 45A126B0085; Tue, 19 Nov 2024 12:54:13 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 27B8A6B0082 for ; Tue, 19 Nov 2024 12:54:13 -0500 (EST) Received: from smtpin25.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id C9F241206C8 for ; Tue, 19 Nov 2024 17:54:12 +0000 (UTC) X-FDA: 82803591612.25.6129E65 Received: from outgoing.mit.edu (outgoing-auth-1.mit.edu [18.9.28.11]) by imf25.hostedemail.com (Postfix) with ESMTP id 6879CA0003 for ; Tue, 19 Nov 2024 17:53:34 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=dnx6oMFn; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf25.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732038716; a=rsa-sha256; cv=none; b=STjipSC8bm9jkrN1u+8OAw3HoDj9KHGbLsw5DE1PYp59qUlX6A2wUDTVUA1pPs71Ju86PT vtBrOud8DSm+GGDLlJLKxbLMxQ7gOsxaseAtPbCYo0F69qdMLGgUTte7H3oak802Mp0EBS rM+Oml4Xm3Gp12Pt92tWymr+UR0mBII= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=mit.edu header.s=outgoing header.b=dnx6oMFn; dmarc=pass (policy=none) header.from=mit.edu; spf=pass (imf25.hostedemail.com: domain of tytso@mit.edu designates 18.9.28.11 as permitted sender) smtp.mailfrom=tytso@mit.edu ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732038716; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P4+3SOCenpcIKOGL/YLix12jX+t6A3qO46sLOcazePc=; b=M16m3OA79oGZcyY66E7p67nawf+EnmOcgbEWoQP9+9esjv9JYStcNDe+G1vwLlB6Cpkzp/ TMRyd2SDxTZSIGwwVL9R8Otv410p4zQgSjuEAmH8jA0qoUVLheRuP6JWaE0ItuBYteVkc0 FidmFtpP1giMGYZsHZpBuomc3mnYOIA= Received: from macsyma.thunk.org ([50.204.137.16]) (authenticated bits=0) (User authenticated as tytso@ATHENA.MIT.EDU) by outgoing.mit.edu (8.14.7/8.12.4) with ESMTP id 4AJHrtC8009481 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Tue, 19 Nov 2024 12:53:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mit.edu; s=outgoing; t=1732038839; bh=P4+3SOCenpcIKOGL/YLix12jX+t6A3qO46sLOcazePc=; h=Date:From:Subject:Message-ID:MIME-Version:Content-Type; b=dnx6oMFn4PUjWKO/r/XcdD03ZLZtFo4dDdkyqclgxqVryFTCdvNJbZLOJrearsQvF ad+KwW223NS7dv/y6MPnnMYkihCClSlr4jMIiYUwUx+paeSMHCxZMb84MXb2z7haB7 Z30HAPW5E9K7laDiv0RD28ZV/7AO355ZXwNlUOKyBQbqvarTcPWZxpY+8w87EE1obw YzKpabQBZnVONLKaiBpi39Em8R2v3GmlOEhZ35giK1XGQUKwvDBm8GLVr0kvOVqI/w 5Agj7EvTHQmpnZ4O3i+YRwzzNbTkgw/eSsPx/m7hRr994EIxPtnPSc6OXfhlq27w6h C8nJAONewAIbA== Received: by macsyma.thunk.org (Postfix, from userid 15806) id 5AA48340857; Tue, 19 Nov 2024 12:53:55 -0500 (EST) Date: Tue, 19 Nov 2024 09:53:55 -0800 From: "Theodore Ts'o" To: Mateusz Guzik Cc: brauner@kernel.org, viro@zeniv.linux.org.uk, jack@suse.cz, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, hughd@google.com, linux-ext4@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v2 0/3] symlink length caching Message-ID: <20241119175355.GB3484088@mit.edu> References: <20241119094555.660666-1-mjguzik@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241119094555.660666-1-mjguzik@gmail.com> X-Rspamd-Queue-Id: 6879CA0003 X-Stat-Signature: 1j14y99kn55cyaxs5zi8y3u8yq5ag1cj X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1732038814-194232 X-HE-Meta: U2FsdGVkX19Wdbzt6S4/d7OeKoROFPqEOPQPyj/5CD01ZrFKRn/I/cjcuWVp3vXrlCKhTK6PD8G4Hga04c6VGREwQ4SW9X07YczYD8GP1IZmKyux/iayxnbTqZ6UhsiK0y892Qg/vaiV6QptridO47HkdhlPcGjbKQA1GH4hR3gEkaKV2clvc5zh3IZ5n8mtnqT9o58GSbzIPFLD/UH55rButUP3sKW/cKbxrAe0LVWvc//CVcxTSDzERlcHekwAyxljmHPVk9io3/uKAc2ec/eixFWFg7mYDwmaJqDK/KKZ1a+GzZrxwYtVFHro28vx5aQ18HLm4rM0y9zqgJXple8hNGZMqzSZl5KYs9kXkMDOShGT6cwm2miJhuIQxu+wx+ZTROhbF0fSS80ra9qKkqmUOOnjK/G/2NH5Np0dLJiqczrDwnNAJiOPvrE7mV3kLuTUD/Gn661zd6fehQ9hdbB/7kXsWu9FN7faHZlUOYl2IolAOHBq5BYtAqh+kVYl3YtSj9VrALeNPwQFsOTtgqY8weODk3H67cDaaMsLTcYrQx690N4X+JY5CrGh4NHUOEBR0UvgTmJM/ru6w/KnKwjrJVaYfhyq+8KKHmtAAwkr4uWJS43vnY0qXoEiTY7Rr9iBTfDW2yXPqdd+yl/KKyVqnmMHQgdx0LlU8LJ2GL6TKoR4yPDY2Wow2Z4f7VL0OaVw4uLk9KSrtHKOt0A2tuk/n/7JewxqB46Td1v73jjoXP/yBichoGIi4/571GHwiVEOu8GIxsP1M2iJk4y8OfaSougd0F2Nz1sLGsZSzvPDjvI4tBbPRG9SffzI9QJoxBZdrB76fv8JOfkAW9u260gtQjNApnoIfI+ct63viyOSbb/oUPZuKy2xx/QyP1BaXX093hqa/EGXa6OirDsxXMjYQkhBWfBw57S3NtQxuXfPXtnYZGQnY4+11qJHgycyWcy1FryATBxg+xdzDxI NVKGHBOx 2qChaXvor8GGw1t2Yh5RO4UgyjCi1hrMExGZBwVi7CKb+78rMhLStHDzkNyqHTajdw1Ul9P5mxRJhRO4NYg2g9IL6NnAtVGWYpj5zoS+TPU7D42WnfVEXZb73ZQT8pQo/oDK6vee04vcPT7SAGKhkiTlE+Xq6/GrVi4B6Y0VcBlxhpYtP0t5u1oHoIc5U00EFVD/BaQ4u46GZ79ZqSBX5vk0ANg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.004586, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 10:45:52AM +0100, Mateusz Guzik wrote: > > On my v1 Jan remarked 1.5% is not a particularly high win questioning > whether doing this makes sense. I noted the value is only this small > because of other slowdowns. Do you have a workload in mind which calls readlink() at sufficiently high numbers such that this would be noticeable in non-micro-benchmarks? What motiviated you to do this work? Thanks, - Ted