From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB32D6207C for ; Tue, 19 Nov 2024 17:30:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id C8AE16B0082; Tue, 19 Nov 2024 12:30:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id C3A756B0083; Tue, 19 Nov 2024 12:30:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id B28E86B0085; Tue, 19 Nov 2024 12:30:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 932DF6B0082 for ; Tue, 19 Nov 2024 12:30:09 -0500 (EST) Received: from smtpin19.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 2D12F1606B2 for ; Tue, 19 Nov 2024 17:30:09 +0000 (UTC) X-FDA: 82803530628.19.F8E76F3 Received: from mail-qk1-f174.google.com (mail-qk1-f174.google.com [209.85.222.174]) by imf08.hostedemail.com (Postfix) with ESMTP id 7F40016000D for ; Tue, 19 Nov 2024 17:29:33 +0000 (UTC) Authentication-Results: imf08.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iJIXtnsO; spf=pass (imf08.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.174 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732037258; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=P2RZbmw8j/hv2SNzaAYY1BO4WuVS0Sj8NBeQ9Pxkopo=; b=H8ye3abo41O7LMjS4boazQjO53IvpvNWdlfnH6RF5Pg5gOAkPhyu3ob/56HoitSZyH9WAI hCjfV5e6Q/ZUGwWCCJaM+XRY3QgUpGanwhoSj3M4WoadcwK8PyblySMrz7vSOFLa18YtPR TcZbZ+B8NHR7vnKojow8GYcAfM5d/9M= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732037258; a=rsa-sha256; cv=none; b=KOHNu/fqGw2UyFNr7Z1byBJwkeNw+FvkQmZhbwFS0Ockq9AS1b9n74wp9BnER/1oFzrfSY 2rZhhcGJ1AoTdrR9oJNvrVkMPLrA8C1F5NmgzmT20u0h8kMkIAQRDUJnbsS7REf04l0Cv3 rrpkSWrcXYLSodGoLXSOrtlRuJjvFiQ= ARC-Authentication-Results: i=1; imf08.hostedemail.com; dkim=pass header.d=ziepe.ca header.s=google header.b=iJIXtnsO; spf=pass (imf08.hostedemail.com: domain of jgg@ziepe.ca designates 209.85.222.174 as permitted sender) smtp.mailfrom=jgg@ziepe.ca; dmarc=none Received: by mail-qk1-f174.google.com with SMTP id af79cd13be357-7b147a2ff04so252544285a.3 for ; Tue, 19 Nov 2024 09:30:06 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ziepe.ca; s=google; t=1732037406; x=1732642206; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=P2RZbmw8j/hv2SNzaAYY1BO4WuVS0Sj8NBeQ9Pxkopo=; b=iJIXtnsObKtk2TP/PidqMBR5RD0TKh0uJGYQGxp65dGQK+9RTpnfDhWNw9DA8TLwtZ 0/28Uc89ZFt+FWxKfLxsf7D321c8dIgukoVJS39bjSU5nj3Gk1cijWK1Jef7wmic8+H2 w1+d8E6X+Yam4TM1GY0T4WXjiafZyEBDNctUGYHKZmrz+2Wvb9y8vxhDnDagFsCp75uN i4KBsK5ShtgTDdYw9bFQKRx0gb4l1MlxcPLXcIemxz5MAbKB5jqQ+Po8GAUzpibLHQEk ZFh+ub2VSiDFI3ogvbWI++IdsGfFjY225hnNoOv/hmCe/W3SuQaF48eMpkSj8ZUVp520 exdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1732037406; x=1732642206; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=P2RZbmw8j/hv2SNzaAYY1BO4WuVS0Sj8NBeQ9Pxkopo=; b=ueY3xRG2+lPpQA8SWdPisWoMACl2qHZcIguzotveLyBfb3xaXZarnUlPPa2IkRlCKZ 9a+RqRyivZFwVs3rbv1ukoxTI8NJZsOMpi6lNEECfwr8vazyNJ1smIEThK4OUJow5kxw hOnLAT9URD4YZqsjaF9XlpJvfde1xSjgsVjWBqqW9eSlRRv4sMFUSO9y6CvHhRATw4F3 yI8SAfljQNa3YLSAPxxFTWxgu/0hs8jspEcUVTjamEwLkTFsmi6b99/Fva1DH5YnqFrg tAAVbcFXqoMJlD9Qcn8NqIRk329z7fPunpO3xSJu4x9Wtp/0TB3194KFlfMeQm3RsR4u yxwg== X-Forwarded-Encrypted: i=1; AJvYcCVkq3xh2UsqKqCHh3w+wjmBul0PxJWOac4fS0MseUgP3H/dohPzb+t0mV3b6zfwOPkW1Us8mAsEDw==@kvack.org X-Gm-Message-State: AOJu0Yy2dz/0nK+Rz8211mytNQwtBK6AVccH+S6KlQCB7hU+Z4mNk+UQ IKHAgOcYg9QI/Rj4Gk9IirEKrEY3flsB8khIsYOqMWtTvc7V4fHUHb1fZPjswRI= X-Google-Smtp-Source: AGHT+IEw2hhta4tF97+ZTqDEn97k4/qPKPWIxcDYewixCIGPDLkcCaqZGpK5GII/9x88g1PJnE+WXg== X-Received: by 2002:a05:620a:1992:b0:7b1:4330:634f with SMTP id af79cd13be357-7b362384ee1mr2344165985a.61.1732037405973; Tue, 19 Nov 2024 09:30:05 -0800 (PST) Received: from ziepe.ca (hlfxns017vw-142-68-128-5.dhcp-dynamic.fibreop.ns.bellaliant.net. [142.68.128.5]) by smtp.gmail.com with ESMTPSA id af79cd13be357-7b37a866319sm113013385a.69.2024.11.19.09.30.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 19 Nov 2024 09:30:04 -0800 (PST) Received: from jgg by wakko with local (Exim 4.97) (envelope-from ) id 1tDS3A-00000003GSP-14at; Tue, 19 Nov 2024 13:30:04 -0400 Date: Tue, 19 Nov 2024 13:30:04 -0400 From: Jason Gunthorpe To: Leon Romanovsky Cc: Will Deacon , Jens Axboe , Robin Murphy , Joerg Roedel , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?utf-8?B?SsOpcsO0bWU=?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v3 07/17] dma-mapping: Implement link/unlink ranges API Message-ID: <20241119173004.GA773835@ziepe.ca> References: <20241118145929.GB27795@willie-the-truck> <20241118185533.GA24154@unreal> <20241119090507.GB28466@willie-the-truck> <20241119135743.GB26101@unreal> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241119135743.GB26101@unreal> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 7F40016000D X-Stat-Signature: x3cafpm5wgrqpamfaawwb9te1u69c1m3 X-HE-Tag: 1732037373-5302 X-HE-Meta: U2FsdGVkX18O7N4GwPab4jxejILA7TBJwxDVZi63HI2x34kmeiWDnVZpZvDVXYKOX2sDBsptx5eL9EEn62actC9R8iOaa+i4Dgga88mP7YU6WXVUVU5PYtpUFngfFlpGI8y02D4R+4+ZNC+Gd0s4qSBA0vllG2b/56pGpLPb4h3QfxAjopPAI6lPFJFGeOnHeArlpjXJpHL2nuJjPz1ooA9F6AG7SChPe/ZZRnHZ8wouFfoYceIJzqrB/MsLuHNapLdPrEdp5vyW/JthIlr1Mr/AmXKMkLdsVLntvkGGDoJI9wZWw+1RtLbeQU3NhuqqKiUrfzSl5JZaijBTtPQPUV5ghH12fqhr9NbpYjlCre2iSMajAeChN9FCI5hAn2WRmqFMS0WyugfeEF9UbfvzaM+FMZtpVPrKLoJ1OX4Zq5uFWsbrqk+wrWCIx3hvCI3cRVB7TiQ+y1O9fS9Rm0Dm/aSxseYEPKP1U15qmQm2vFRjy514coCWwneEktZJDdm0tPAF9ina5jLtWMBmE+9jZIgVeYFwCe/C/NYr3XqET9CvdtJ0F5ajx2wVUfB2VONmP1eNzhKjbZnY5RdfRTrdsRyj1bT9b0riju0QLo8l7j1tn/5jLMr/ZkXmvroh9Hp7q4N2W6dO3gIFgNfe1OpQwMwlbT6x3qz0fG9yLxgO/oJTbylq3zJ31z9tb2ePDeVE2IBujEKc3yzYdBvVOyAJ9Tvu1g9Bm3PIy+jVhmDOmZxiAKWrAMnesSoS0TMDZ+NVn0gGb21Th+PJ8VqF/hwctBkoyQ0A85lTcC2CkV9qNpABQMopJbS73QQFxE0DZRDlG6h2zBjwaoefBv9ho7RHCnPUIIkaU2eF2tsRbngSwYD02+ObiYW1Clmkr69FLUXYWpfELXPD4F8vq5F4FQ2kEpraZzsBEPVsH/3vyG3Kr6LlTrpr4OX2pO3JZGaAgHwkS+ZU6e7djlkXF23+sAU Hw/LgDSu vZuL06PdOerVKUka8l2QNcOnVcRIBvVUYrrXeplrNhq+RxwzWY4SqQgouvT+giGrA1poqByMUYyY3LQX868SolwNYvrMkntl4hvtvoMc7jn3myCtWGihBJsy7f4PHfBIvW2coyiBL+B5oKiO0L8C1HlN+ff77fPv+2pQDPnnWwSCikersZG7w7GisY0d0yy6ic1uvSXnLHA17OzoR2xP/8J4pKFe7fy0pXEZi4LVzmULWwIAOL0bcdvunJl5xueWWtSCgctKlPptzgUQwL0oQFLvR8CWaR5YbWzvB X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 03:57:43PM +0200, Leon Romanovsky wrote: > > > dma_iova_link/dma_iova_unlink() don't have any assumptions in addition > > > to already existing for dma_map_sg/dma_unmap_sg(). In reality, it means > > > that all calls to unlink will have same size as for link. > > > > Ok, great. Any chance you could call that out in the documentation patch, > > please? > > Can you suggest what should I add there, as it is not specific to new > API, but general note applicable to all __iommu_unmap() callers? This is what I wrote: +/** + * iommu_unmap() - Remove mappings from a range of IOVA + * @domain: Domain to manipulate + * @iova: IO virtual address to start + * @size: Length of the range starting from @iova + * + * iommu_unmap() will remove a translation created by iommu_map(). It cannot + * subdivide a mapping created by iommu_map(), so it should be called with IOVA + * ranges that match what was passed to iommu_map(). The range can aggregate + * contiguous iommu_map() calls so long as no individual range is split. + * + * Returns: Number of bytes of IOVA unmapped. iova + res will be the point + * unmapping stopped. + */ Jason