From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6F05AD6207C for ; Tue, 19 Nov 2024 17:41:57 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B82B36B0082; Tue, 19 Nov 2024 12:41:56 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B32B46B0083; Tue, 19 Nov 2024 12:41:56 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A216E6B0085; Tue, 19 Nov 2024 12:41:56 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 842856B0082 for ; Tue, 19 Nov 2024 12:41:56 -0500 (EST) Received: from smtpin11.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 36CE240706 for ; Tue, 19 Nov 2024 17:41:56 +0000 (UTC) X-FDA: 82803561708.11.00B2C46 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf06.hostedemail.com (Postfix) with ESMTP id AE0FB180008 for ; Tue, 19 Nov 2024 17:41:18 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nJ8iynQA; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1732038048; a=rsa-sha256; cv=none; b=pNQQ7rO69u2OuCIIgDVpsChlZeB5IVCBF0b6t1de2cZnimrAux7rGPN+zvTCJ9qcs9l701 0xZ7yEiZR607h0Y+aT92t3lVO5/aHbxeo0Dv0yEyVKUTHPvopJoBo1VvhEpEnYuBEIX2Xi aa94aVAyUTSWMNeUi/CBOKZ0IcpIHkk= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=nJ8iynQA; dmarc=pass (policy=quarantine) header.from=kernel.org; spf=pass (imf06.hostedemail.com: domain of kees@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=kees@kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1732038048; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tIehL5Eq57WU5MDnr706m1glqC3em8l+JqMURm3NtYA=; b=jTYfwcxbPariGybuUiDgLqrJ5IcrQg6e9YknJrPxbDtRiDOPX47GHwhnquBh3/2YwOs0xg SOn+3RFPKWBW6BxJkfB5q9jQnuboBPzKh0oFrkXdj+7XIKcn0Zt6alNfWsZ6e66+lTTIgP L5DiFlPWS86kIXoRxMBN5MqXeDmyapY= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 85D9C5C4C02; Tue, 19 Nov 2024 17:41:09 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3BF96C4CECF; Tue, 19 Nov 2024 17:41:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1732038113; bh=M9+AtSHNRnbjVAZQlkaGqAJdeKVY26XckfhM9AJn6co=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=nJ8iynQAyqU+Q/0oYveULfxJRGs15OAT3MB+C0Sj52jC8zuLmn3W3bEkQppjrBv9T rYUBfp07Spp7p5776jmw5XeTeRg8DnKz8V70R3H4L6TtkXYjkW1MzODiNWoT9xGbKx S0Yc2R0yBNW5q4QATdcfbzo1l5VF/8d3u71h1TxYQJ3bIfMgj/rpluT/A0s4nPGTcv K1twv0W3P495oMIk7AsuLJXblpTPYahmGhq3GZ2loECMp9SeK41CIzHNi1oxz7onoC i2RskGTJQAbyuFKWGmc9nvlRWbQJ1bYzalDTmDtTzzNuhxH4Yet3R8mN1B5TIwGoJ9 tZGRDFStqjtWg== Date: Tue, 19 Nov 2024 09:41:50 -0800 From: Kees Cook To: Petr Tesarik Cc: Andrew Morton , Jinbum Park , linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 0/2] Fix mm/rodata_test Message-ID: <202411190941.43503D3@keescook> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: AE0FB180008 X-Rspamd-Server: rspam01 X-Stat-Signature: t3g41kfo7onhhdwmnsze4ta4tr3sai8h X-HE-Tag: 1732038078-340969 X-HE-Meta: U2FsdGVkX18jF5a86zf2AnkUKL51lOCjm0lfHJV6cGv7eom9TQmDq89Rf+WyWunWmRCemz41MAoC2Ymh59kKLO2BVc+HkpsjJNhH5dBbin2XHtsxYcnHyss+Akkp7xpXYSiWjORxn0ICrneKncc1oVWw4HQm4tIyiiDzxeRL84/vNldOsFpFH2NeAOGdcKQ/VhUrgbDNweR6w4Fq6VsmwCPs8ZLxSBkffP5OzPAOKJfKv4ZJQrC6poxJQDGAgUGAVWlZYMtlwL2/jd5HfOkQl+ykV+9gsy7MGHpJOedn/w7lgWKxfA8cxlRc9PilDw86vtoukF0hg51w1jgxBBKjKnmVdbByQdKfZn4TimqFZzFFGWzVCfwe5rIbkA5YjUVaotJ0VIKcg7I7ivl6UbvXZRkyIaQPv8FIxY1pENgYMNLkp0KU8AczGFwBn6ndQHBnrJeLa4Bf40ANUgwBNREhCTB4KfdDSUSQGw7z2Zanh/jEHVoHN/lUTyws51BUG1JsDos6FDVSWBaJZ+Om09yW2gpq0BvDQ8MxCnUnAq14jePrvkSp0bg5OvY2OpLbXCKlOuQEqaTKuLk+TQBBW4JMbMAmWMHYgxncecaUT4oOY+UApMqpQHssRjL9jfwGC8D5L/g53YXawHLbWDEGS/HASwd34IO98vrs2OnLdrX90BqKA6um8BZ5olzea0tlab2uTuW5K1q6/EcmKK1VPGHau0Lbvl7SeRQ+ZxDir6wUofufs/VhSQRbkBjTIn+Ql9NRBdScO4yB/K3cocJ1cCduxzLD4seBY8ytfKp3HBdsmjM5VZXy0WKG+m9jy8Ts3iHc4WfjWVOPD5HXQWlq9+0+ransse+0mR4xu76lsq6XSfL5vWH51yj3BDvspRkVop4u1+21IsR/kxxmPscavqeF+iEFXHJakzK5hjagwdpCE9BdhytnGT7mlaEDDYSB+G9GlgU5OuFzg8W9oa24I+U 7Pp99ROy dTRDd+dFr2/U1QCVbStYptAfA9ohKYtki/R0DtmSoDbAyiieKtfrbng3Wjx8TSS7MNDKb2Ec0RJ7aFQvK5+ZO/RAWaejTB/fxNPPHY6iOgAMIIi53/2P0KF39jj+HJm0hW28uYXL2llkj53HQx1plen15VSDdGdmlw8Te9lCIoB7Wi82vDKYR55ks2x65ryCiNlbrnFu/ihEPuTwTMo4wzb5JwZmEjAFC+o5XUVNZ/cauExdwc+T4TqB6ov/h7QqiDQ446pRo9z1Ov2hO/A8Wv2ZqrM1LleLwjlY0W9Ga6C13FtUQo5OJCftBlDreYo7aml97id0/iJ222D4wSi2wZ0n8aHlVmyOIQEhdFADwGaBVInW+qPQz49CR2k0F/bJn7e4avt4fEcKDqWwj/SHpqN2FdCv9sklWJ8x/ X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, Nov 19, 2024 at 12:37:37PM +0100, Petr Tesarik wrote: > Make sure that the test actually reads the read-only memory location. > Verify that the variable contains the expected value rather than any > non-zero value. > > Petr Tesarik (2): > mm/rodata_test: use READ_ONCE() to read const variable > mm/rodata_test: verify test data is unchanged, rather than non-zero > > mm/rodata_test.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) Nice fixes! Thanks for catching these. Reviewed-by: Kees Cook -- Kees Cook