From: Kees Cook <kees@kernel.org>
To: Petr Tesarik <ptesarik@suse.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Jinbum Park <jinb.park7@gmail.com>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 0/2] Fix mm/rodata_test
Date: Tue, 19 Nov 2024 09:41:50 -0800 [thread overview]
Message-ID: <202411190941.43503D3@keescook> (raw)
In-Reply-To: <cover.1732016064.git.ptesarik@suse.com>
On Tue, Nov 19, 2024 at 12:37:37PM +0100, Petr Tesarik wrote:
> Make sure that the test actually reads the read-only memory location.
> Verify that the variable contains the expected value rather than any
> non-zero value.
>
> Petr Tesarik (2):
> mm/rodata_test: use READ_ONCE() to read const variable
> mm/rodata_test: verify test data is unchanged, rather than non-zero
>
> mm/rodata_test.c | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
Nice fixes! Thanks for catching these.
Reviewed-by: Kees Cook <kees@kernel.org>
--
Kees Cook
prev parent reply other threads:[~2024-11-19 17:41 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-19 11:37 Petr Tesarik
2024-11-19 11:37 ` [PATCH v2 1/2] mm/rodata_test: use READ_ONCE() to read const variable Petr Tesarik
2024-11-19 11:37 ` [PATCH v2 2/2] mm/rodata_test: verify test data is unchanged, rather than non-zero Petr Tesarik
2024-11-19 17:41 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411190941.43503D3@keescook \
--to=kees@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=jinb.park7@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=ptesarik@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox