From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id BC808D4921C for ; Tue, 19 Nov 2024 06:08:26 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 160D06B007B; Tue, 19 Nov 2024 01:08:26 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 1116A6B0082; Tue, 19 Nov 2024 01:08:26 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F40EF6B0083; Tue, 19 Nov 2024 01:08:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id D67456B007B for ; Tue, 19 Nov 2024 01:08:25 -0500 (EST) Received: from smtpin20.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 5016A16015D for ; Tue, 19 Nov 2024 06:08:25 +0000 (UTC) X-FDA: 82801811484.20.86CB195 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf30.hostedemail.com (Postfix) with ESMTP id 2B5E480004 for ; Tue, 19 Nov 2024 06:06:48 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731996437; a=rsa-sha256; cv=none; b=2CbUZia6rO0vVWH/mguhws1KffUPHk7UnyJw2hjQfIhBvblgDvQlT98blIo7V1Jr22+xxN 22sftD4lrDomVUmSYxEy/wIxTpgm2NhNxJPtNWboOcwgjdq9p4hjRzmto02S08o/qdYMHU 7A7Wynp8441CJXE4PW5kpJWBSA/lKik= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf30.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731996437; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sJNor1EiCEVbz6IphH5S2xaXwJvjOzY48Cci6NtLk2g=; b=prrc3Yt8QNVr5o3oshRtey7qIMBcgoJ1Jbj31suA+o/rFaBJTVmC2YztlJfc0/ty4cPbbO ZVzsD5y+uYsiU5CuvsekxKXdSFe/AWM41D9NMyxT8iPMagXeRLxb1XZ83yfciTaPIDwnYh XKQk3Ut/kEnnWlAUqYQl0h0OUelJcSE= Received: by verein.lst.de (Postfix, from userid 2407) id 5370168D4F; Tue, 19 Nov 2024 07:08:16 +0100 (CET) Date: Tue, 19 Nov 2024 07:08:15 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: Christoph Hellwig , willy@infradead.org, hare@suse.de, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com, nilay@linux.ibm.com Subject: Re: [RFC 8/8] bdev: use bdev_io_min() for statx block size Message-ID: <20241119060815.GA7159@lst.de> References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-9-mcgrof@kernel.org> <20241118070805.GA932@lst.de> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Queue-Id: 2B5E480004 X-Rspamd-Server: rspam11 X-Stat-Signature: pb18tjtns1xngu8qs96weqbbwz33i9u3 X-HE-Tag: 1731996408-616525 X-HE-Meta: U2FsdGVkX187TEA8nL3L2FGcGc30DNO3LuEt9fKN8xAYoMKKNAdQDkI5Ia7yp9c4NHijuYWJaZpVil4i1ymo5E3JpYcsX+f7N/Crg8uTl/wDvucOW09RrDVhQ7zFl/H2sGjy7c5cBdcNZUWdvJXHBx7g3p+XNIVPa5YuGtrcAOaeRWUXmWGmWsZDnNb5dfOU335nN9NUBeE0Q3vvcn+AJ6CSD7598TZpizrRSEMeuAGPMv9eE9dEnBEx1r5YRJi0wi1ALXWFSdFLOjstSHytflF10PCtoWqYITPnr9SUOCqb0XTsMM634UP3WeHjr43wjqPjvdDmnf4Cxe6D4NtKVjODIhs0o5ekwWSM+PURO1PxoKkQlFV/jJXHf2MinmJpu4zD+Cv6vp9SovsXq1gwyAdmor4TpZBK6cYD3AQekJAzXgEP9u7tbKdryBnupzaG3MlGMIGgzJH9/XTIfdFy9MKRcH71f1SyXKY71Ms8rIZ/u3AH6+OBeztNvha+WsNR5CO2mtxYwSsKPWejy4S3Zg2MeZTk9GAzKkVoFmDU61U055j63behUFUbnH+9hEnDQdOAkhfeA9eSjrz4tsz3WPyXd5abzDeYmnX5r1XKEczLGli+mlpSm4csvsedGPSoP2xGjcrHczYr+XL0pBzrVI5etnYm0jVQba5J7zC2FTV5lSifCz4hUnCuKNbq+LFWF6DrWM2jGh/pGjUSlY8tTMJhzqajHfgiUmqb6tq/hRUfH1iQ8QMvqSs1TUL956uB0FUrECrBvNAqTgcu5YOEXSQwAqo1agJiPAkqAv50v4kZzmlnNPb2u/CbpUQa/9XLPv6JKHzyvgdAzGoU9gZqgfSJNMVoSMdzDBMKwfdF5TZqlDbVowdbN6S18OCnqlDkYnP2Jcs+0bGkGYT5RowOkh/A0fLBsInl+eARN8V+/KjHuQ8vR/v4J79JaEAlb970KcXmVmM7MMqJWsHf1Y2 ANr8fU0y SA3YHVIHvbMie8dz23zmcOt/3u9Os2f3joXsuleOYXwdPiuJq8Di/2CGvY9CPBdonRcSuVXq0m/8J0PW577ycMx1+8H6NwHxs1+3ZPoOesiSxkEOC6wb5XlNRikmKArmNjE1zX+8DsJwcLFZ0TH5SIItlV/opEWeZmOxZfvC0Ya8/jH09IeXhh1G5SnNvHwJo+3cI X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 01:16:37PM -0800, Luis Chamberlain wrote: > On Mon, Nov 18, 2024 at 08:08:05AM +0100, Christoph Hellwig wrote: > > On Wed, Nov 13, 2024 at 01:47:27AM -0800, Luis Chamberlain wrote: > > > if (S_ISBLK(stat->mode)) > > > - bdev_statx(path, stat, request_mask); > > > + bdev_statx(path, stat, request_mask | STATX_DIOALIGN); > > > > And this is both unrelated and wrong. > > I knew this was an eyesore, but was not sure if we really wanted to > go through the trouble of adding a new field for blksize alone, but come > to think of it, with it at least userspace knows for sure its > getting where as befault it was not. Huh? The only think this does is forcing to fill out the dio align fields when not requested. It has nothing to do with block sizes. > So how about: > > diff --git a/block/bdev.c b/block/bdev.c > index 3a5fd65f6c8e..f5d7cda97616 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -1277,7 +1277,8 @@ void bdev_statx(struct path *path, struct kstat *stat, > struct inode *backing_inode; > struct block_device *bdev; > > - if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC))) > + if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC | > + STATX_BLKSIZE))) Just drop this conditional entirely and you're fine.