From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EC68D60D0B for ; Tue, 19 Nov 2024 02:10:16 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 62A1B6B0083; Mon, 18 Nov 2024 21:10:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 5D93B6B0088; Mon, 18 Nov 2024 21:10:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4A1756B008A; Mon, 18 Nov 2024 21:10:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 25E0E6B0083 for ; Mon, 18 Nov 2024 21:10:15 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9394DAC9AE for ; Tue, 19 Nov 2024 02:10:14 +0000 (UTC) X-FDA: 82801212186.07.550D30B Received: from mail-ej1-f49.google.com (mail-ej1-f49.google.com [209.85.218.49]) by imf29.hostedemail.com (Postfix) with ESMTP id 62150120023 for ; Tue, 19 Nov 2024 02:09:05 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jIrQKnK3; spf=pass (imf29.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731982032; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=q5TSxUSa5mWtFQTAQEKytEUqKEYzGTMGSE4evYsqItY=; b=lLaF0/BdOps82WcsPdc+oQLLLnkQkE1ZMKkBRoW8yglSauIESFiG8N2aTK9RjzzNBZHMKm rTkYvry0MoZLuj08YkgnWsFM/vdQ3Gx87cZO/xL20kUx6G2/kUS+ur1wIDKVwX1AYCSKmO Mpn/XygrJxp9YAjMrS8/95j4SbKtoYI= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=jIrQKnK3; spf=pass (imf29.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.49 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731982032; a=rsa-sha256; cv=none; b=S9dandV/fnmHykc0pif0u7ybZWdr/Kbg2jP3Q5+dnCJvReBDFa7I4zNv+RhIOyQDJIfI+Q m9k8ZLHnnRSjh8cEBJlIIcqylKSyJr1ocXCsLxJEG5XHGaJ027wcsDMeaY738eXFg2koRp Qxnd/mfSNfYpplGT6wwG/86UooK0epw= Received: by mail-ej1-f49.google.com with SMTP id a640c23a62f3a-a99eb8b607aso53093366b.2 for ; Mon, 18 Nov 2024 18:10:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731982211; x=1732587011; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=q5TSxUSa5mWtFQTAQEKytEUqKEYzGTMGSE4evYsqItY=; b=jIrQKnK3wxQCDVaNVCkDm5qnmcIkf/b8L1sb35YttHR7sByPmMOZYVjlrX+F+HW5oa 6ymLJ5cTWwrzjA+0ry33VTJZJ0QB5LGjNN7zBg5eLl5wWcuSdqK/3YqsoqyIoz+9M0DB yRL5tYKiUZVZdEdy0my2UUkehNv7xx0yYQ+x5yrGnejvQ2NIPn1sP9JaaBFKkI4muZiq MW9fDDZ7gT+wEJJjKe+4Tz3skoZJ1PrjEGwubPlJULLRZvT/g3Ck6RH4U2FYZurQWJ8M mI1ETDZmDDL3pOcpNbTelUOAHf7EJwWIc0UzDbbEIEmX0PRFG0MzlSLTeVkXB8RVtkt2 abzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731982211; x=1732587011; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=q5TSxUSa5mWtFQTAQEKytEUqKEYzGTMGSE4evYsqItY=; b=nDUNLBvJibZjuG6VFaT2Fx7aV1F8DrN34oxnqAkmeEUeZlHJfnLml8AhmJEprxgq+1 3XgI1lfKsNUCRnueORPgUtAO/NmvuJOXGJDppOgrDzEpG2CQ1eID3mVaKvzP4Sf62Bfj Pm1RD57U1O32HX+8V8RYvytcZwSwZhnUJ3xT//nA0dbAW/1qLRPyTgRdvqzA3qLCd+oO w1oXmNVX3YtkmB+LrpuzwT18GSdC+rmZisx6ybEK8UuJLCgA6SVguDS68L9r089Z6zT1 6LfwIKfCnmZ2HVq+JO5rUt8s6uc7ZapzkxdRxOKBfYBqy51f8Ge344ihDPYO9ySpJsEJ a09w== X-Forwarded-Encrypted: i=1; AJvYcCXRgZOFOrt6+fxT6KUU8lMaZz7AyDkMAlDCeQ9IR87wXaN8h38D2cXjxkCWJM0CJFcJ1fW9SeDcnA==@kvack.org X-Gm-Message-State: AOJu0YyHkA10pKt0ysWlg5/c3wdr+CZwaQELvZSGZU29IXFHJ7onlz9w R6UwUaXWUaj/IDRpDupWPp3H92WWre8glHPePMyVZ85gsOCfk1cspPsL2A== X-Google-Smtp-Source: AGHT+IFqmXmnZ923mFoXdFan43UesGSmHnep4hJTR3Af2xEAqCd7CMC9giCkDGJbTEiC8TwC2L5WdQ== X-Received: by 2002:a17:906:eec9:b0:a9a:835b:fc8e with SMTP id a640c23a62f3a-aa483552870mr1408128966b.54.1731982210789; Mon, 18 Nov 2024 18:10:10 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20e0860casm601598466b.185.2024.11.18.18.10.07 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Nov 2024 18:10:09 -0800 (PST) Date: Tue, 19 Nov 2024 02:10:07 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, Lorenzo Stoakes , Sidhartha Kumar Subject: Re: [PATCH 2/3] maple_tree: not possible to be a root node after loop Message-ID: <20241119021007.txauxmjakjk7ideh@master> Reply-To: Wei Yang References: <20241116014805.11547-1-richard.weiyang@gmail.com> <20241116014805.11547-3-richard.weiyang@gmail.com> <22ljesbnxadun2ij37qnx7gdqbl7wy6nxjjwkejo6waa473ro7@niiaqj4cj23d> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <22ljesbnxadun2ij37qnx7gdqbl7wy6nxjjwkejo6waa473ro7@niiaqj4cj23d> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 62150120023 X-Stat-Signature: 53ujazc8on41bjis4pqyinydgmxk4hec X-Rspam-User: X-HE-Tag: 1731982145-560809 X-HE-Meta: U2FsdGVkX18emY6rwgRg0hOu2hhLsOuI2aEpAyilc7tr6JhdYkwbFLxnAiYWUWvxKnght6+nRwlgVIkRCbndap2NiIa7c3JbE3UboKkwgGjgU6C9MRmavb4hGhYFlYTGKimS9WHykizJzcs3E8sirRNtDhgcRgAM4Y/SDj/AGuLzh1zubCNX3uDe8cNKWO2l/dKDhCJr1S0xeUkUawh4ulW5zc30uc98gcMr4VW07Yvfh6lpQqdxefo6cOGb/Pt7fAjEtdAe9B/rN3PxKcb3ehh+06k1UxI4nfXNWwJJSskjKfzybnf3B00mnQ5DYYFQUHPasp0n1WYv0TrC2SAqxF6c/38mkeTDUhTcW38xos2er5940jyOTTrHOEpPrY3Bj8Kbl320aKr8MK1EGTJV/BqJwdMIdb4jGWg1gJgk2yRl2eLXbouF9VyocxB6kkPKCQ1zGOqrSCUQsxf4EgP51tNvq0Sz1NmQSGuzHZ0IzbkefHe1xHR6wABs9toaNa625qVnfB1N1YEPPegaZQfk0TaKuDnaD+0+D38nqLDv+OCIAUk54o5zAtqy+K/cLBsEkjlb8pm297JzGD418pPrFzLWifRhHKL1FBY15YI7hoeaEIZQrOtUFAF1w9iSME8OiPmHPxFyGPYk1MxJ8je8WrmgEqsgFS3hphsBrv6r2b8cQn+etMO+PGd58TlGD2Q/yIIJ3VoT8Jw7BUtCjuJFYee/2TumJjBGwPODlaFRsvR32S7YyecmNYGMY62yQg9iILmwwhboROMxcEuX8oP3Zxj4E6An/Pfn5ElsJZfRMRl+apvs6aP/d0/j3D+8d7adY82++jg73Go81DBa6WBsxxmZrIU6fzdFEG9aLk18YI46cGFkhMv6Ke89R3TvyhZ+6tZs2iiCzpYeZmsKROhWXNeloGngFw6hf84bK5P3Oc8HAhem4mSou+OQbqR0/2yPaA9jYYVrmRvZQ0ohMhm ++1wcIPs g8YdRQYLs5Ssr1P2gFICo6BEmSqEssiocNKH51dPlpEvpB8Fm1s38UuWBGDtOT00fuhep3dxJp4xjf2XxQ0bTYkp1B3FMb0pLqMJDHtQr8WIuM4g4TdNSL53Gr0sCdhX+RbEhDGdsC8U6bRAKHtS5gWpOUEtlu8SQ7Q8NQXNsS0SBZg98GD8qlpnf5K3ChgPtt4PO0IpXxfzYEwMw6Juz63sajHl1E1g4bCCWZPe3DdRuCLxHRT/DSjRJoQBQjXc6GLns2rS3md4JocpzXykB5GiBzcsiuz1za+UXoIaFePqWHCppNQs5s6HuWm8qanwZVLfnT5ZemWKCGTvbx0S5ZdOGbaQgUoFXlcp3TFuy63eKlR1RgAdjRQ4jpqENWPqNIVxq3tZPLb4WSjmf9iGB5+xOHkOIpMt4polyveKMcE38AfUdxjxc8luMIJA/V3sSkC2rITDhGxb+yQsNjKE5bTi4NulS5ij68lyVAE1Zau4bWs1Ywzy3FRWIlY8dwWw6ni+p8c7BYPwCJadq19dzpobyOG9utny3LQ8KvBkM7IZl0MaJ1HbOKyarlT+lSNM8tWtPai2jGj34gIjW17tpa0LvzMoj1M+DKQL7vafA/XWtHgPBSpVkH7o52jxU8PtrCfOgMOI4qRkoVkdqZsg/l7xXYRXpZSN9hEyXbGMjmPVDFJ14Z7kDxV52p37mwlszUK86 X-Bogosity: Ham, tests=bogofilter, spamicity=0.034781, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Mon, Nov 18, 2024 at 03:49:55PM -0500, Liam R. Howlett wrote: >* Wei Yang [241115 20:48]: >> Empty tree and single entry tree is handled else whether, so the maple >> tree here must be a tree with nodes. >> >> If the height is 1 and we found the gap, it will jump to *done* since it >> is also a leaf. >> If the height is more than one, and there may be an available range, we >> will descend the tree, which is not root anymore. >> >> If there is no available range, we will set error and return. > >Isn't this needed for the overflow case? That is, if there is a range >that ends at ULONG_MAX, then we will break from the loop on the offset >limit, but not check for root, return false, and continue to loop. > I may not follow you correctly. If there is an available range that ends at ULONG_MAX for a root node, we break the loop with two conditions: * the root node is a leaf node, then we will set found to true * the root node has children, then descend to a non-root node Not sure this is the case you mentioned. -- Wei Yang Help you, Help me