From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id EE2F6D591A9 for ; Mon, 18 Nov 2024 18:14:41 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 86F9C6B009B; Mon, 18 Nov 2024 13:14:41 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 81FE86B009C; Mon, 18 Nov 2024 13:14:41 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 6C0C16B009D; Mon, 18 Nov 2024 13:14:41 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 4A8316B009B for ; Mon, 18 Nov 2024 13:14:41 -0500 (EST) Received: from smtpin05.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id F0507A0430 for ; Mon, 18 Nov 2024 18:14:40 +0000 (UTC) X-FDA: 82800015186.05.57A6088 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.223.131]) by imf12.hostedemail.com (Postfix) with ESMTP id 4F3D340008 for ; Mon, 18 Nov 2024 18:14:16 +0000 (UTC) Authentication-Results: imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jSwXpjPJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=86ROUx0e; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ch4xaa8s; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TBDhvAui; dmarc=none; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731953588; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=md9G+/9cSr7JpPaP78XtOG3skD1kyowear2VacQB+is=; b=zj7NbGn/gTPcJAp0QzzQuSUt/3TXf8kByGj2f/SjA1Nwf6o9k5ewtRElYpqcvHGcA/En6W hcYCai4UrGTrw/L0QJQlFaO/1VjkLaL3zCdnUP1MQVesjI+wTlT79S30EuGHjCfUY/aXRR nBYTodhr0nlST9FEKkSqAfqcJO7qSpg= ARC-Authentication-Results: i=1; imf12.hostedemail.com; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=jSwXpjPJ; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=86ROUx0e; dkim=pass header.d=suse.cz header.s=susede2_rsa header.b=ch4xaa8s; dkim=pass header.d=suse.cz header.s=susede2_ed25519 header.b=TBDhvAui; dmarc=none; spf=pass (imf12.hostedemail.com: domain of jack@suse.cz designates 195.135.223.131 as permitted sender) smtp.mailfrom=jack@suse.cz ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731953588; a=rsa-sha256; cv=none; b=qr88FVKGzB05zqKvAl3GQtIMNsFEB77krBp4k5PIDcO1xEhXhQI/romnl48pqOs0wXfR7x pDaMV3qZf/3LxvGrodpE20s6TuLcZdcnzf7KQxEwaGiWYllF3GjmYwk4M8RCVgbxzHzYTl EBxCO3eXo1NZ+ch9x32KXsplOzfITO8= Received: from imap1.dmz-prg2.suse.org (imap1.dmz-prg2.suse.org [IPv6:2a07:de40:b281:104:10:150:64:97]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id 45FD61F365; Mon, 18 Nov 2024 18:14:35 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731953676; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=md9G+/9cSr7JpPaP78XtOG3skD1kyowear2VacQB+is=; b=jSwXpjPJdyP3H9kg2vP6YVPy6sMElERXItbvv/fUYhTmq8g1QZ1MsmPPS1rM66VPUFsiuG DgSiLR/2k6hkqbUQALIoW6akd29RL6r4TKRNM31LEya2loOMax9+nrDVeTI1GyiyomK8Km 55ZJ5cmjlZo0hV2bxZNAj2T7Gh91XOw= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731953676; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=md9G+/9cSr7JpPaP78XtOG3skD1kyowear2VacQB+is=; b=86ROUx0e0I30RVzHdIaRVEUbV4xjvw6UF+v1YTkUCd/zPtq5gPbd4ZY60/BgGf6j1EPT4U YIqyE0FG1oJmbeBg== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_rsa; t=1731953675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=md9G+/9cSr7JpPaP78XtOG3skD1kyowear2VacQB+is=; b=ch4xaa8s317XGBtr2Ge9VfJFvlBX/S9XN4vXUSSS5WdtF6ZpUcPhj+J8or/csizv3pct83 wE8++FlhQZG6od51OOfpRLzZ1gB19DJKnNmfEhfUwkIHXeD9hzumSoXP27EwSDIFGgUy6f jWB+fk83OpTtIQzxGH1AdOQ92t4WpQY= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.cz; s=susede2_ed25519; t=1731953675; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=md9G+/9cSr7JpPaP78XtOG3skD1kyowear2VacQB+is=; b=TBDhvAui+7AK/qG/gNQBM9MyLcvk2gO1AmzGWyykr4br2aEPuF4eZUGiytDJd91KlLHKyI ZIyKVXVcsKTdUTDg== Received: from imap1.dmz-prg2.suse.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by imap1.dmz-prg2.suse.org (Postfix) with ESMTPS id 35A45134A0; Mon, 18 Nov 2024 18:14:35 +0000 (UTC) Received: from dovecot-director2.suse.de ([2a07:de40:b281:106:10:150:64:167]) by imap1.dmz-prg2.suse.org with ESMTPSA id ZF3RDAuEO2dIPwAAD6G6ig (envelope-from ); Mon, 18 Nov 2024 18:14:35 +0000 Received: by quack3.suse.cz (Postfix, from userid 1000) id C3826A0984; Mon, 18 Nov 2024 19:14:34 +0100 (CET) Date: Mon, 18 Nov 2024 19:14:34 +0100 From: Jan Kara To: Josef Bacik Cc: kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, amir73il@gmail.com, brauner@kernel.org, torvalds@linux-foundation.org, viro@zeniv.linux.org.uk, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v8 01/19] fs: get rid of __FMODE_NONOTIFY kludge Message-ID: <20241118181434.iwsu2yqlkjyw4wkw@quack3> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Action: no action X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 4F3D340008 X-Stat-Signature: z6qtoczkstkrjb6yh87crhz398f9ha4r X-HE-Tag: 1731953656-208082 X-HE-Meta: U2FsdGVkX1+pHN+9Fe984hWNblYAj8iHW3PNlhwHw/S2J2kqtnsrDc6vQ3lOtOn5GmgDuz9tOQgYEeSeMm4ipgZUUgONSQ2G80jCcxu+GuQ8zkPwiPqFDRCt7GlMO/2WVQAAmft7c5Dmwrw4vWAxz9ZJYCktyKDTez9TTdPvKUEvf41t9WDOkoeKxRpHSe07UNQt9GDeiyQ3EEYqO4J/HBHqEYYTDrH1gowurEanvADvugecSHJy8GjDFOhkf5IOBVRmXkGKKunx+jtGxEvZi2sHaMzm2MMir+BfVdVfZ5bDSItJl+UW8lgeW0Xk3Kemli1AQ0P0v23lZ8w3q51aA/gRku7qBc4sPdqC3H1oiAfRh8wew72R03YcqcnKjPjXw+B+EqaYJnsxscFOprGJkoygzYMan7GuaIHWTqS7WOnxdKrFahRDD4a53q610pedUsi/161U/rVe1Dg82ddIDdv5+3jlrzJu+aXXhlSx6DkiKDlHwVLUrEd1bQCpNyT7EsB1XyuKGdvuDqMNJjI0fddDHmu+LqC/IVc056/rI8Nv3FILxsw8Nbmi4S57jPg5JH7bIXr+SXiDtIDJ5BehiNgu3LEACeDxKQyFyMjrvVfV/NO+5HIiOw38UsZ3X/2lUJkZJRKkD77FEPVxscZJESnmA7aIxKM/Sn7cPv+7xPYcXrnDqWSXtqMJV66bLj6KA5U40HGTl4UlRroJWFK8/zd2sjsPuWiOz+fyvC4XHY22LJJnxf2B5nGzkLMXtni1UH91oEH+BBfZyC8L1RTAlblxiQWIvLrHyh8R9Z7N300/Kn4ZhTJq/8dUXHLrJ+igO8s+UV3QvDH1BrQnKCS532j/LgEzz2S7BQryK5DnSCRjm7G3IUbx93LTL6XDStUhuqEtWLixnY4/rdfDtob7uB56SWsER4WoEUWKXHfWnnaKF0SlWYnFXpUxo7K6UDD8Uiqu6JNz12Hc1fNy+N4 8FpJvROD PN38NQJp+1+8N8iZdQ2gT3qx0eSW6AiKX4XKTfg7Q0Jef2DntxpnhwJL7oUEPkZlISU3VqSe4M1hEhSGdf4+ZPYLgXTdt9gR8KFopGWO10Uzv8B6MeGbb6lKd9+LCwIvgohdOCoZ/HpPgr0jea0JeBY+TeArVWNRJ+FhFcz8jTWI5rHHjx353pVxI+/jI0aWVzqGi4rhIJVRPqB5/irwlV+1EGzaHOsL4m57qWJR9YSiy7BOuOp2AJfT2cXJ9FE7ASrb5dwGC8NjS9hDM9Z88fPJuSHmEa+6EZjZeGFnTrbf6sRCd1pBdx92MEq+y9kVNQCAk+a5uk5hImAYpQio54xOuhTUOD188krvwh+ysQj7+aKxUI0OLYWT+y43VQlWMnCO96zDvcZYH67A1+dwy72Q/O+73/B/cn3dMfWWZJ8mCgO4xWajNbTEBhRDQoPQKWAPConJANfm/WBpRUHZVq6impw44wFej98qVUc03H2KwOxyG4NIobZD64w== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri 15-11-24 10:30:14, Josef Bacik wrote: > From: Al Viro > > All it takes to get rid of the __FMODE_NONOTIFY kludge is switching > fanotify from anon_inode_getfd() to anon_inode_getfile_fmode() and adding > a dentry_open_fmode() helper to be used by fanotify on the other path. ^^^ this ended up being dentry_open_nonotify() > That's it - no more weird shit in OPEN_FMODE(), etc. > > Suggested-by: Al Viro > Link: https://lore.kernel.org/linux-fsdevel/20241113043003.GH3387508@ZenIV/ > Signed-off-by: Amir Goldstein ... > @@ -3706,11 +3708,9 @@ struct ctl_table; > int __init list_bdev_fs_names(char *buf, size_t size); > > #define __FMODE_EXEC ((__force int) FMODE_EXEC) > -#define __FMODE_NONOTIFY ((__force int) FMODE_NONOTIFY) > > #define ACC_MODE(x) ("\004\002\006\006"[(x)&O_ACCMODE]) > -#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE) | \ > - (flag & __FMODE_NONOTIFY))) > +#define OPEN_FMODE(flag) ((__force fmode_t)(((flag + 1) & O_ACCMODE))) ^^^ one more level of braces than necessary now Otherwise looks good to me. Don't need to resend just because of this, I can fix this up if there's nothing else. Honza -- Jan Kara SUSE Labs, CR