From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3CD16D49228 for ; Mon, 18 Nov 2024 14:46:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C0956B00A9; Mon, 18 Nov 2024 09:46:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 870A16B00AA; Mon, 18 Nov 2024 09:46:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 72AF76B00AB; Mon, 18 Nov 2024 09:46:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id 4F9C56B00A9 for ; Mon, 18 Nov 2024 09:46:37 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id EEE0D160152 for ; Mon, 18 Nov 2024 14:46:36 +0000 (UTC) X-FDA: 82799489934.27.A2F126A Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 5AFB980013 for ; Mon, 18 Nov 2024 14:45:02 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gcqYJFjE; spf=pass (imf02.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731941135; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=E6C369fXebc/lJiBXk0WQK+y7FNVjbbitA7vYiVXXh4=; b=wuVHx113G+fm4wOn5/egCxUHwB8kFQFSpEzzBZF1M1fBBMhya72gR18/mmDyU+J52P7Y55 iuZ3j5qOvalIOZyTjnayYugPY/yxY/nZ2tYkTDMcDM4I6tY8Wswn124GQSvsoCpWa2Jjy8 l+clp3Tg7F1Z55661PYdT3/poLXqYGY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731941136; a=rsa-sha256; cv=none; b=DuBuPUepbNYsJ0tkQpZWWAwddVOwQHLuuqYdvVth+p1L1fpyHrmo9fJWloSHgoHUVT53/x z1CVmkv3lv0fZDUtLm2kSlCIqrd7UZTdmbBrKVUho+rMiQ+K5f8P4ZqIGaAzOCsqIWbAjM tHu1haJEn/RDdD8yOK+W8qOmN4GcPFI= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=gcqYJFjE; spf=pass (imf02.hostedemail.com: domain of will@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=will@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 02DA25C4819; Mon, 18 Nov 2024 14:45:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 2885AC4CECC; Mon, 18 Nov 2024 14:46:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731941193; bh=nNisB9deNFEifWbAA1Dvw/hHdpmPPX8zsLH5xbacxY4=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=gcqYJFjERDxmTKO3Jzdv0vArTE/dXSGOuwdgyjk2yJn/d2ltrlEq3xcV6A9UTOQQs 4fk2tk5dJmkt6KttbPce7YR877xgwmsSgBNTIhehvPSLAWTNhJeG+CoHLygfSzT2FF vwP2mTJFky9C4OAfWLy5n+S05ganaVPqDQ6hjxvnLdaX1EWpuwxWgQbbn4NLMVL+Ai OegOfG2sPWxlDxbnltGRDouKx9glSiedeWMI/9xjbdN+wzO2Ul86ef9SOlufRt1uKG qlmTelutMmqg5UjnfQf6N3ovc/FxuMiHsWW+rvK0cqbLErHhUmeNyIRWNX24IY7jCi u6pMfsD6X9UYg== Date: Mon, 18 Nov 2024 14:46:25 +0000 From: Will Deacon To: Leon Romanovsky Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, Randy Dunlap Subject: Re: [PATCH v3 03/17] iommu: generalize the batched sync after map interface Message-ID: <20241118144624.GA27795@willie-the-truck> References: <589adb3a4b53121942e9a39051ae49a27f7a074c.1731244445.git.leon@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <589adb3a4b53121942e9a39051ae49a27f7a074c.1731244445.git.leon@kernel.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Stat-Signature: 1qxiow1y3umwsh9c18du7hhqbhadzhgy X-Rspam-User: X-Rspamd-Queue-Id: 5AFB980013 X-Rspamd-Server: rspam02 X-HE-Tag: 1731941102-861997 X-HE-Meta: U2FsdGVkX19Vcd89SF/PNSSu7ffD4pqsHpDC0n8Y7rMkM31OEFL6TAvnLkRZ0i9baq5Hxg2ACx04nyfYMg5rYEQ2WnbQU2tXib9nQhGx8nidgk059tlYs06P9kgeoH2huNP3ayc8YpbWQp0iAYwLeYGEXUnRvhFgjl4lisgs45W7S7eTereTjKcsxrFCKH4xZlnbKUOueZwGCSKeB+esTUyL29LHEP85xhwK1JWdLAZBzu3LCTIXo5h1d2p1i4O1cFSL6ZBYp98DuITG+vA/SUz8DHFkKWX1Cuhan/JVuDZmr00HzymojgVqlBfY/M1VoY7wKPis/dJLd4nSWNsgQ3a8s3JZdbx8QMPd8nTtEA6Z9FTWp+MC+mVtciSYPbSWBh3LJVbdr5/i99uRAK87AO6NBEE3A3GQh9e0jpisBetuYWDimLlczvLthyZYLJyPq0Fc5e4HEmkHrhT4Y+/TZfV+jG4HHHTazAfncUL+qZm6Ta5w/R3J+Ppagi8otJp+qfEGo5IDEITur1hNeQRCrXg179bb5p+GYpYiJAJsYyUHLwz9etdPZB1ErzPqmx3FXgcqa6fANLeQ0Bl4wzsvZr5N39kHS0aAyqa5VYDHCI+r1kq5oby4znRP7fd9UXXSmb+b+YSaNMp/yc+N+rmlWpuQEfbnC6sEMlKpKjW2YwAbOTaB+cpVfmFb04tUjpT4TQdk8Qto0DWr27J89s7LVlLhRX7m28vvq16TZ3rEwGhKILxe+Y1Nkjqv1I0whA8FAVfVn16og01v6e3bCr+D0VfmZpKBz5XxNNtMsqCLev7qVz/JtBi9tktbzsmGWWX8tH6eJyQT2HOQ71Iq+DB+ZhdXEtjCqCDL2ZZHVZSDI1FDDy1obYaDZa1grsjP14/lDhNZnXBLXGKwblKlrIFnjb3oPmOChyx2RFyrbInYzIN1KbIgVgtNaRECn6k8PZ1xG9eTf1JOiqtmoUX0rGs 1cvIs9lU se0hQyIF+IJxP4QT/BBTx0QsRba4CXAwQq9XIC19xFyL4pD5e/nVP+zbRYeLRDTxdocgy/gMSlwSkn/xfP8EaQArOJ64y1TrMfTdx6TSvMhErRdMBAklWi8Oh1QppqnIqV4cMd0n9CGXDPcIpSUxa/yeFc9QkCZospShkQUnZ0LeqhsB2N5X3tgezeip+DkaRnbkpZhtqwBpyUV5Jd+vGSpwOMzi3sAeoUjPgzCOSQEorSN3C7G3V3HVntFadGC438yKiUrcNIKgaZWg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 10, 2024 at 03:46:50PM +0200, Leon Romanovsky wrote: > From: Christoph Hellwig > > For the upcoming IOVA-based DMA API we want to use the interface batch the > sync after mapping multiple entries from dma-iommu without having a > scatterlist. > > For that move more sanity checks from the callers into __iommu_map and > make that function available outside of iommu.c as iommu_map_nosync. > > Add a wrapper for the map_sync as iommu_sync_map so that callers don't > need to poke into the methods directly. > > Signed-off-by: Christoph Hellwig > Signed-off-by: Leon Romanovsky > --- > drivers/iommu/iommu.c | 65 +++++++++++++++++++------------------------ > include/linux/iommu.h | 4 +++ > 2 files changed, 33 insertions(+), 36 deletions(-) I was a little worried that exposing iommu_map_nosync() directly could expose driver bugs where the range being sync'd was assumed to be mapped, but I couldn't spot anything obvious from a quick check, so: Acked-by: Will Deacon Will