From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 66A9DD49205 for ; Mon, 18 Nov 2024 09:56:48 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id F3A948D0018; Mon, 18 Nov 2024 04:56:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id EE9D08D000D; Mon, 18 Nov 2024 04:56:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id DDA158D0018; Mon, 18 Nov 2024 04:56:47 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id B874B8D000D for ; Mon, 18 Nov 2024 04:56:47 -0500 (EST) Received: from smtpin13.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 68B93140119 for ; Mon, 18 Nov 2024 09:56:47 +0000 (UTC) X-FDA: 82798759134.13.195E733 Received: from mail-pj1-f50.google.com (mail-pj1-f50.google.com [209.85.216.50]) by imf15.hostedemail.com (Postfix) with ESMTP id 5AF83A0002 for ; Mon, 18 Nov 2024 09:55:55 +0000 (UTC) Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hizKX0qh; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731923715; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=xDxyMOW8qq4uHaUaCSJGmCcwLH0nXDKtKPK2l00TB9M=; b=JVFVLDg/uWRSRRAN82gpoUpsC/r5+AL+foJqiihE7SIiCwwVuHTeLOVmzAgkvLk3h4/F5Z +unObJnvq+Yyejk/LielUTCoJU0kTOMjhUUnwbtO/WrinCeWs8qWIBYhsmtugnlSuC3CXL mmZyUpDY51oFtmNDv2Qg/LP6WAhFvK4= ARC-Authentication-Results: i=1; imf15.hostedemail.com; dkim=pass header.d=chromium.org header.s=google header.b=hizKX0qh; dmarc=pass (policy=none) header.from=chromium.org; spf=pass (imf15.hostedemail.com: domain of senozhatsky@chromium.org designates 209.85.216.50 as permitted sender) smtp.mailfrom=senozhatsky@chromium.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731923715; a=rsa-sha256; cv=none; b=7DN7GRLSiB70v2ZdS+/ijJvBct2t1FKw19fZE6dV7wDRU2ojyz4F03K4T/2LrItwqfGUR+ opgYVYBYvYqcpyK4oicM52gBottP8yvb9zZQAcFj/LHTeOrihoMu6VrfoyVVi2wThTRiFt BikULcdVBcWK/5oTEqw0/4bDJtNgLDE= Received: by mail-pj1-f50.google.com with SMTP id 98e67ed59e1d1-2ea49a1b4c8so856643a91.2 for ; Mon, 18 Nov 2024 01:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; t=1731923804; x=1732528604; darn=kvack.org; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date:from:to :cc:subject:date:message-id:reply-to; bh=xDxyMOW8qq4uHaUaCSJGmCcwLH0nXDKtKPK2l00TB9M=; b=hizKX0qhK6w7EaI4I4aW3W8dn1q7Dxsf2faOWc4R1no7e86J50biMg+h1Hu567knG5 1+D4L0nyQ1+gXhcp+d3gVuuwks4JjMRhNtSorcM0TAhpLFX1HdtpSnqf/W9hU6J48Bn6 vpU8V8vdx77d0hPQGc96ANQJXOIifQUkswoy8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731923804; x=1732528604; h=in-reply-to:content-transfer-encoding:content-disposition :mime-version:references:message-id:subject:cc:to:from:date :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=xDxyMOW8qq4uHaUaCSJGmCcwLH0nXDKtKPK2l00TB9M=; b=aG1Apr/Vlsw4jxfy2dtuzntz9sm+hhLy3JOWqxfZ7riz9fvXAScf/onAFnFjVaKXyv uYN/JvC1KAFkVbvjKv3tY/YLSTKe9GYniOG6N2ydVce5FXn03J4Yb01j3HSe0ScLj/Ei 0SMCVaDUQTDSjmRm5ElXSc2wWfduzAxYNJtbbzPWQ8fvoBCjRL2rETmPmROPTU552hNy KimRg5L4neaRg+Gsc+s21uNrabPKH0jSHz2aLGQW5iF7k446CBXVXxiTE3ss3fxnIiVQ gRg0OH7yDm+gutCbKNYcHLMdhojao7QQycGqU9OuhPvhg5b1uoVCAeXGV2YMN6pcpYDH +65A== X-Forwarded-Encrypted: i=1; AJvYcCUOH1ggupynjOrDxbLOdbeU9kMRbCXuAKrJktyFERDZSrYq4MEaSQ/SteU90/KYEYT5umyrgOuSFg==@kvack.org X-Gm-Message-State: AOJu0Yy/0/v/ITsfJki0vr0Sa+d18c2eS8TLvrmaY+C38yrE0UA4fgWa GFA1c5diknQMKWV+E3Znd3+0dQ5im3eL0i7+2pVyt96PWAdskHIhJevNtqswzA== X-Google-Smtp-Source: AGHT+IFwPscuRl5WTyZwAWgtpFuFGwsGo+Y2Tqh53iXaIkKHWf6n0kpAE7XdrS7yorkIewCxZDW9Qw== X-Received: by 2002:a17:90b:38c7:b0:2ea:712d:9a7f with SMTP id 98e67ed59e1d1-2ea712d9de8mr4244800a91.20.1731923804004; Mon, 18 Nov 2024 01:56:44 -0800 (PST) Received: from google.com ([2401:fa00:8f:203:8826:78b8:a8fe:1066]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-2ea448cd342sm1857344a91.1.2024.11.18.01.56.39 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 18 Nov 2024 01:56:43 -0800 (PST) Date: Mon, 18 Nov 2024 18:56:36 +0900 From: Sergey Senozhatsky To: Barry Song <21cnbao@gmail.com> Cc: Usama Arif , "Huang, Ying" , linux-mm@kvack.org, akpm@linux-foundation.org, axboe@kernel.dk, bala.seshasayee@linux.intel.com, chrisl@kernel.org, david@redhat.com, hannes@cmpxchg.org, kanchana.p.sridhar@intel.com, kasong@tencent.com, linux-block@vger.kernel.org, minchan@kernel.org, nphamcs@gmail.com, senozhatsky@chromium.org, surenb@google.com, terrelln@fb.com, v-songbaohua@oppo.com, wajdi.k.feghali@intel.com, willy@infradead.org, yosryahmed@google.com, yuzhao@google.com, zhengtangquan@oppo.com, zhouchengming@bytedance.com, ryan.roberts@arm.com Subject: Re: [PATCH RFC v2 0/2] mTHP-friendly compression in zsmalloc and zram based on multi-pages Message-ID: <20241118095636.GA2668855@google.com> References: <20241107101005.69121-1-21cnbao@gmail.com> <87iksy5mkh.fsf@yhuang6-desk2.ccr.corp.intel.com> <28446805-f533-44fe-988a-71dcbdb379ab@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 5AF83A0002 X-Stat-Signature: 1grnwwojwxx5j7rs57ixjdqs39oh55ad X-HE-Tag: 1731923755-88911 X-HE-Meta: U2FsdGVkX1/8Kiertedh8wWkD+63C+oXI1tPHf41NvOuGL7NFgwZKyOw0ZHsizIBGPXbKrWb4MfewzPBG4tCKxmpngUmygw83cSc/ULU9jyInzpAIAk0Wxpo5gKRp5vp5LaRJv6enIJ5bRDS3KuNyVrmuxW/O5wa3mfQ1WtJtW9QvcrVVexrJDSnT7agkBtTX63jxBtvy1PBUQ5ljDLUy0rqwPgiaFOW6seG/80UfNgLo4R012zQm4cYiijLjXKOMvaoRq3S1RYrtxGpE/hZjeDqj2MVJuUgytkJXq85jvF+8YctpAoSDt0qv6QQTRHTc760+HoRz435Qa61PvdrIkjYDBdP+If5rsGANnqaBaVpY9yGMmKUZwSE9aEH4WvEQYti+tOIXrP7/6arjvnkYaUWwBtQg+Uoth9kbirjn9Z/aY3spqaebtb7qwsKF/MSnfmtHIW0lJZ4j2zIl5wbubAEqk8e9jwcKIJMKqOAPE94kvTaINjVF6STgJLtzxBX7qOkk/fDQgwvGHDVpLZJMa/5PXHUwAtGvqlq/+FaB/7eFw61PUKEhmb+yigEsegP1P/geBjuj3IuwvAodWeUtkfCvwSvWuYLec36SY7I/bm0hBikaK0SIJ9WktAPox8s4yVUwg6fvyIakeJOEZOxcd1nMjlyeVrPeH0WmOgF9sulF92O/AWrx+Ckga8qIDOWPGHmfmOKleHh/wsiV//6idwvhu1EZfSJyo3/36SH/9A2c4KLGq0R5rDWJdaCpOKwYf0Bch3obg99RkwonQWAxgyFgNpJCDsCwcHQ3Txk3r2Pvg+1GT7Q0TnhAvSL8gsMYD4DL75JJM2mST/i8pffhl4QXERb2C4sw26ZCKnEV448MOKFHFM6XDl4qmgHb+V9+V8a5X4kkjhh6R69GNMo4flYAwJDBOBfU/pUDN062k3V9cM8vcR6zhTouhU7lnudu9zajoOSUpbP8Hx9DeC piY6STIb PqO8ycDk47mZ4vEVmt1Z8RvIsHQPfPQUsIzunQhH5dEAdRxSpG3+GLmmcWXJ9W5EFEUU7BprFjhWtCDSWhsqU6MQ7OaX0qW/9dYlbegcMgaK0wSHkkillPWmskKoFhZDTCfPDJcFTb1KB1WXFwUopkK99ND6oJfcJwrnJUFIdz0oQp9299OUBXUWjxde9tdZNmeqYWQuOR7foVU5Jb8RijbPx4wmaeu+3ca2dm7599YykohGmyaVsWOBF1s7SuwzyXiT3RnYqMwWeLMZp0DzeBI7GoUpW5vkTa+tjVHodTbOTokw+3/c2/yAubTQjsXnf2ZovhWbg/X03uxnvo3p0JbpbgI2uYRsobIF51am7CQja3HO4y3Y2XxYf+GyyCzYngaPd X-Bogosity: Ham, tests=bogofilter, spamicity=0.000049, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On (24/11/12 09:31), Barry Song wrote: [..] > > Do you have any data how this would perform with the upstream kernel, i.e. without > > a large folio pool and the workaround and if large granularity compression is worth having > > without those patches? > > I’d say large granularity compression isn’t a problem, but large > granularity decompression > could be. > > The worst case would be if we swap out a large block, such as 16KB, > but end up swapping in > 4 times due to allocation failures, falling back to smaller folios. In > this scenario, we would need > to perform three redundant decompressions. I will work with Tangquan > to provide this data this > week. Well, apart from that... I sort of don't know. This seems to be exclusively for swap case (or do file-systems use mTHP too?) and zram/zsmalloc don't really focus on one particular usage scenario, pretty much all of our features can be used regardless of what zram is backing up - be it a swap partition or a mounted fs. Another thing is that I don't see how to integrate these large objects support with post-processig: recompression and writeback. Well, recompression is okay-ish, I guess, but writeback is not. Writeback works in PAGE_SIZE units; we get that worst case scenario here. So, yeah, there are many questions. p.s. Sorry for late reply. I just started looking at the series and don't have any solid opinions yet.