From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id DE80BD49200 for ; Mon, 18 Nov 2024 09:31:15 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4E59B6B00BC; Mon, 18 Nov 2024 04:31:15 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 4963A6B00BD; Mon, 18 Nov 2024 04:31:15 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 35D4D6B00BE; Mon, 18 Nov 2024 04:31:15 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 0CF1A6B00BC for ; Mon, 18 Nov 2024 04:31:15 -0500 (EST) Received: from smtpin29.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay02.hostedemail.com (Postfix) with ESMTP id 898A0120117 for ; Mon, 18 Nov 2024 09:31:14 +0000 (UTC) X-FDA: 82798696806.29.D871396 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by imf07.hostedemail.com (Postfix) with ESMTP id 73A3140004 for ; Mon, 18 Nov 2024 09:30:03 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VyNpprQu; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731922213; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=RaqT5/PR0BgQOxGW3Nai0cX9eMuMcYylZivp4wM14gQ=; b=S6zwljDtkA/of6mOkj5lDcCB/4qqdu7rXd/dE3sOQD0oq18rmZD+oPl5eDO0iOvXUa7JGW J0IIg+Eb0kUa620HHZnTZJkCyryjP0t28lImgJgFYXiL/cvFRa57k3m2QUF7BOdHVqwHxj Z6ZcE2Trp+uh4Kbz1PvTbOoeMNf9tAY= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731922213; a=rsa-sha256; cv=none; b=PWBZn6rm1/I554C7y4QXPLaGKIE14gwHDtdJ9n1JZT+VTceJqqxSyBhoqNrJhDS8b/ZdfJ an8SWTdiLvm0DDY2l84tT01y+F9pprpeChVGKQ/c6qsqq38GSYtAfRy7W+U8gv0anL6LL2 Yn/Mw3CKjfezC7lBI59YkDHu5nkpnp0= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=VyNpprQu; spf=pass (imf07.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.218.42 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a9e8522445dso307007866b.1 for ; Mon, 18 Nov 2024 01:31:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731922271; x=1732527071; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=RaqT5/PR0BgQOxGW3Nai0cX9eMuMcYylZivp4wM14gQ=; b=VyNpprQumnvr0caRI5CTQgDpQ8xA8TDuqYs1YZ/mo3VfSV4Yd/woZWTn1ftNtODZPA nDpoWtdoeDJlCTgr/xOeu3qIfcDreoh2B+/Ni7NYVou44M6+QPXM8fGViqsQgousVpFy ApXo5p2Q4PLpYW+XBunpFCh0C9lNLHKeAIpyJD4ta+n1/r+GEbQHvSDu4eaCa8o/8kWg SteRkuvHia+eP93rrJw8dmiik17qIZEsdC7j2a+BzGJ/y/8CB+oDMeGDgQ2OJ8XwodpI xwSEqBjVz2zBrhCzRdr8tn3bQV5IziBMSa8UkumzAhIqmTglnmEDjsvfzTwQkmpM9CWJ XEBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731922271; x=1732527071; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=RaqT5/PR0BgQOxGW3Nai0cX9eMuMcYylZivp4wM14gQ=; b=ianTZfefwsoo9zb2+GMFnyVLZJ3sPHArtxnC1Q6Y8waKSkGhDgjzzBkeMsktHbN7/i ByXGpjHEudYx1DMfNeTw5WcK/elxFUtmMz8SNyrsLRMxedmrsnBo7JdCO7aMP+NKa1Ab uOn7m+K3PLQa7h6beJtxjLFSthI5YQG0gvqhylKl/tXkyuBdTg4SpAYLX8HdMx7zf+v1 iQpAJtpnpCCljvdc/VAtaU8S5PZpJiG72o5sgQwNTD4mt/MQsMbyPDuCMCYITHEiIdAG 3NmkurOcbstE1JoK2HTDDs8iP59onfsVQgVFNRbQ1tpqUX/U2WA8UtAh0/d8DWVlWwwU uC+Q== X-Forwarded-Encrypted: i=1; AJvYcCV39tSlq6Y4Da3ucXUDC1sdxn1Q0zDRC35RlHbWdm/4mpeA1jZby3T0h9ZAVb+045gStVQhMx1buA==@kvack.org X-Gm-Message-State: AOJu0Yzq2w3zfxSSXB5BZ0wKhULja0T3DOoNwCvA3XK/Fn9s9UgdeiRY zVzT6v1+ox7Q20heU3UtJaAQQEstPbA5UoBGmcGvBhk1Nw6CIUOA X-Google-Smtp-Source: AGHT+IH3tgwN9wzwhasM49Ta6GAKV3EqBThvtgs7H10BCIwPSygIMQmhPRiOPL5im15O8X1plwoFdA== X-Received: by 2002:a17:907:d24:b0:a99:f833:ca32 with SMTP id a640c23a62f3a-aa48342149emr1139169266b.18.1731922270690; Mon, 18 Nov 2024 01:31:10 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-aa20e0452a0sm516917466b.148.2024.11.18.01.31.10 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Mon, 18 Nov 2024 01:31:10 -0800 (PST) Date: Mon, 18 Nov 2024 09:31:09 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, lorenzo.stoakes@oracle.com, vbabka@suse.cz, jannh@google.com, linux-mm@kvack.org Subject: Re: [PATCH] mm/vma: check retry_merge only for new vma case Message-ID: <20241118093109.rmfekrv65yfu735t@master> Reply-To: Wei Yang References: <20241118021823.17386-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Stat-Signature: ytwa639ox4ujkpy1mwt8iqkacentbss9 X-Rspam-User: X-Rspamd-Queue-Id: 73A3140004 X-Rspamd-Server: rspam02 X-HE-Tag: 1731922203-125517 X-HE-Meta: U2FsdGVkX1+zsLpxtTR+P0Sn3bJO1xfGaUbIQRUYcRs2xXsCbmPGqRf3PWI2sqjBkDgsCE3WOgMjiNgXjhK9pfuUmEk4pNjySgBRIQu3jIWbh1CEdVBAYWbLvq+iovxvnhYc0OVmJux1AYNBd8ME/ToXH3PCtXrrCz2MLHGB5uF1Eb6ia5ug0cAu2pnayz7YQ968+IjpI+ONwxvvHqoap/+OQ1aQQ9rHOwITPwmIz8ECGSuYpmrqeQE+bv9Ryu3/C+o3c2d58dhX9cIP1b/KPNpqxlp/eTQFGRB8zFYTZVDIHC/Qluo7ai0rPhNMqkc16lT1I8N5UU+r2IFBrPPIknUF6OBwYSOj0OiPkOUoiBgZXG8m71NyzAkiHdGmsXwKqjVEadD1HFLrzXdtbPtch4kuWz+xCO94If0ganYMwanLthrfP1kdtE+q0QEIq/q17CwJ0fqb6DtJqQe5X/IJrhoAnvB1QoTOPNEWSGO+ltfLkhyQL0XxeMZPfVcbIV5id7Eb08sLr2oRj50I4kfTDt78/zGk2wmQAmwIXg4x+nKJjAbkxVLV+9GcLA3qZ78tL4euKYHb5jwWWZGHr3Ew2zjTnJ568yuC3UtMZykfnrRpugj6Hz5Dn/PPFeHWbPa7bBChBVzj16zHJxQEJBtTgEYNkknaykDlV/rTWsNoqgyiy0G9J/jnImtJbgvFt3utB74DqC2ErrCoOHbWkDK//iOL01xrJzcD7tlFjOnzrWNH3RXDty44wrZ+WD9hLysP3Cx+4hBB7Um5cPV8jkfnsCduf9QQI8LjGzlrX6y8pozPG7KblaobBSqI9IcuyOiHoW0nqNIr3Z1wQS5pmmbjBgijzBljQB1sG5mO4oRkGzU61SENMFMRNA/TIIW+lxCz+dYwLZD9yu9YXYnhSaWEHpmrBEL5i7Wm2ywRh0Q/n8KjX3UJ9y4emNDiWrQdUOqOyZIIQlq4N3HC9t7vjpo 3jJPbC4C HGxGtbsv0wrC1omdlqDI0qoVDM1E3D0bvmRXeK7eW3IUnOXsJ9VR9KqTuxUrvgw/wfw4noNAq+0gaAC3kVorSaAe4WCyyryF5f3eQUuo11FfSsgmN+IVtYkCUwRLGTVqDPiiqGcaORgJDK1ftVO67VfRumAThs9CTlbl95bRGV+K1T2quN7tJsFaLZawrwP8W0WrHtQVseZ5/m4EMkqK3Tb90nAHgsk3rsW0UdcI9VesP2Tvj8L0JWkEsZOrwX+Wq+gUTZhlrhJYljVHm4H+cIZV0TPAHk0rfQdzmn2u4gqx9YC6Ls+XnyGS9VTCH/NDwX+CxuoSKOgHmviJSpS+7rXmEO5Vyvc2bA9DjA+GpsCCzSLPJd3uH07hswegw1ur2u5B/XSiJ9w4TBBsBg5HngIr4SLN3Hl5xgxrR+H/HejWeOY5ROyO4MzOZz0sVCytUQYhk+1uFeUE2B4fZZZeFzoU2xSb3ZFVHWhaLy36LJ4miXVBqIoxX52oqpwLC8zcYRPhv9/Q+0EGGIeYizmEqYHQKeM0GGhOBUwXXVsynz4DlklP65l6EflL30wnuwYdLaL6oa7nrTbWAduToWwecwVh1M+C4nNEDPfEG8Xk1fy6ZIN/wuuHvNJeJxZPUdhvCIR9sbZIwu+sGmNi2gHyqMtyWVIQEUMLxTz89rTj35Ufe2Ab8Ix39Ytfi8tVO8KOoHXhP X-Bogosity: Ham, tests=bogofilter, spamicity=0.017182, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 17, 2024 at 10:56:55PM -0500, Liam R. Howlett wrote: >* Wei Yang [241117 21:21]: >> Current code logic looks like this: >> >> __mmap_region() >> vma = vma_merge_new_range(&vmg) >> if (!vma) >> __mmap_new_vma(&map, &vma) >> __mmap_new_file_vma(map, vma) >> map->retry_merge = xxx --- (1) >> if (map.retry_merge) >> vma_merge_existing_range(vmg, &map, vma) > >Please don't quote code in your commit log. We can see the code in the >diff section. > Sure, maybe I misunderstand Lorenzo's suggestion in pre-previous review. Will not add these in change log in the future. >> >> Location (1) is the only place where map.retry_merge is set, this means >> it is not necessary to check it if already merged with adjacent vma. >> >> Let's move the check and following operation into new vma case. > >This makes sense, but this is a complex block of code. > >I'm all for optimisations, but there is already a bug in the code that >you relocated in your patch, and the backport of these changes isn't >even complete. > >Maybe we can give the existing code some time to soak before optimising? > Sure, when is a proper time to re-send it if everything is fine? -- Wei Yang Help you, Help me