From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1834D43FED for ; Mon, 18 Nov 2024 08:26:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0EFF76B00B3; Mon, 18 Nov 2024 03:26:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0791F6B00B4; Mon, 18 Nov 2024 03:26:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id E0CF16B00B5; Mon, 18 Nov 2024 03:26:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id BA7636B00B3 for ; Mon, 18 Nov 2024 03:26:27 -0500 (EST) Received: from smtpin26.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 3229616011E for ; Mon, 18 Nov 2024 08:26:27 +0000 (UTC) X-FDA: 82798532502.26.5E793A6 Received: from mx0b-001b2d01.pphosted.com (mx0b-001b2d01.pphosted.com [148.163.158.5]) by imf06.hostedemail.com (Postfix) with ESMTP id 67FF5180004 for ; Mon, 18 Nov 2024 08:25:50 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=pVJ5a4Sb; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf06.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731918295; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=pofVBIDpbmPXxKdXBZzlW6SKJ1mpQg5f+nyOC0P54ZU=; b=BMcYQvNTEYC/c0Lx9qhkraoXIeyHerdclh8QfpXRQO7eTsPXm0UOiRxXF6T1cuV+bBjcN6 I7drshlIfRC/ZPLQTeX68Bif0pQqymuTMfdZE4HqljqzadRLUSVFNESypL55+ZIP+UXChk MTheskeG+krXUWhkFHqsaj48fizVafw= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=ibm.com header.s=pp1 header.b=pVJ5a4Sb; dmarc=pass (policy=none) header.from=ibm.com; spf=pass (imf06.hostedemail.com: domain of hca@linux.ibm.com designates 148.163.158.5 as permitted sender) smtp.mailfrom=hca@linux.ibm.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731918295; a=rsa-sha256; cv=none; b=TOZHPGoS1lt4EY7spv7ALx8RfQcD+CSN+Q1/YCYwpcTph0NU/Z50Bt8e47t5VaPIqehbel 9uHGu8F3JUvq4nEwVizcV1gktq76v5iwhbBxymAPkT4DQ6S7YHZZ86+TW0IpOyi2p09rBI EA4A8F34QMhwjQuLYOfTsBSQL0/YkkM= Received: from pps.filterd (m0356516.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.18.1.2/8.18.1.2) with ESMTP id 4AHJiO3Y023687; Mon, 18 Nov 2024 08:26:16 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ibm.com; h=cc :content-type:date:from:in-reply-to:message-id:mime-version :references:subject:to; s=pp1; bh=pofVBIDpbmPXxKdXBZzlW6SKJ1mpQg 5f+nyOC0P54ZU=; b=pVJ5a4SbiQLc7KmL6NMVUat1TeAb+E4P6v1BT086o1mEhk asPz+d9pnH3oUetVu+XCwbjmIJgCChQ2Yg76ElBtpMc3MPIe4GEIJkdBOh3EDOTs BshLlGoNMECAtRDAXjrNjk0/DJ4p9T1LW6K46OwdwtMNuLDXUx7tw7C0oS59z+J9 QShMh32WGNHKvTgEgpik3EK5hVK4TsghRPVpOZt4uDmXgH2LYgfrkGGFgYTal2qH dz0ScnJgPbYohwDb0fe9yXNM0o6w8EzUNqyOgMmUN0w1gT6xXC0tgw+yBkjkz/Fh q242Ut9KG7OxmdBC6tktol2tQuFTw331MM4YUGlg== Received: from ppma22.wdc07v.mail.ibm.com (5c.69.3da9.ip4.static.sl-reverse.com [169.61.105.92]) by mx0a-001b2d01.pphosted.com (PPS) with ESMTPS id 42xgtt0eh7-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2024 08:26:15 +0000 (GMT) Received: from pps.filterd (ppma22.wdc07v.mail.ibm.com [127.0.0.1]) by ppma22.wdc07v.mail.ibm.com (8.18.1.2/8.18.1.2) with ESMTP id 4AI73j1E030931; Mon, 18 Nov 2024 08:26:14 GMT Received: from smtprelay05.fra02v.mail.ibm.com ([9.218.2.225]) by ppma22.wdc07v.mail.ibm.com (PPS) with ESMTPS id 42y63y27mu-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NOT); Mon, 18 Nov 2024 08:26:14 +0000 Received: from smtpav07.fra02v.mail.ibm.com (smtpav07.fra02v.mail.ibm.com [10.20.54.106]) by smtprelay05.fra02v.mail.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id 4AI8QAR549479982 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 18 Nov 2024 08:26:10 GMT Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id BD6AD20043; Mon, 18 Nov 2024 08:26:10 +0000 (GMT) Received: from smtpav07.fra02v.mail.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id A867E20040; Mon, 18 Nov 2024 08:26:06 +0000 (GMT) Received: from osiris (unknown [9.171.77.223]) by smtpav07.fra02v.mail.ibm.com (Postfix) with ESMTPS; Mon, 18 Nov 2024 08:26:06 +0000 (GMT) Date: Mon, 18 Nov 2024 09:26:05 +0100 From: Heiko Carstens To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?iso-8859-1?Q?Hellstr=F6m?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?iso-8859-1?Q?Monn=E9?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 04/21] s390: kernel: Convert timeouts to use secs_to_jiffies() Message-ID: <20241118082605.17002-A-hca@linux.ibm.com> References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-4-911fb7595e79@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241115-converge-secs-to-jiffies-v2-4-911fb7595e79@linux.microsoft.com> X-TM-AS-GCONF: 00 X-Proofpoint-GUID: QBYvLy3JNa8evFseixOVfcUMyMppMmNG X-Proofpoint-ORIG-GUID: QBYvLy3JNa8evFseixOVfcUMyMppMmNG X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1051,Hydra:6.0.680,FMLib:17.12.62.30 definitions=2024-10-15_01,2024-10-11_01,2024-09-30_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 clxscore=1011 phishscore=0 mlxscore=0 malwarescore=0 mlxlogscore=858 adultscore=0 priorityscore=1501 bulkscore=0 impostorscore=0 spamscore=0 lowpriorityscore=0 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.19.0-2409260000 definitions=main-2411180066 X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 67FF5180004 X-Stat-Signature: b1gdyxzx7zeftt1sfxqg8semitaeotkz X-HE-Tag: 1731918350-630034 X-HE-Meta: U2FsdGVkX1+Lc3WTAAIw4kdgxfJD1on3s3dae9elxN22sI+EC2wICUULjHizMM80h/A0s52c8h3g/ViXLcZt50Kq1xPtJ13o/3+ue2Gm2/Evd5YTLfbU4M2vokeKQ3UVGLeXKyyjQ0TneYg1YjTgBYR+IWrDi8sbpTW7l002ghgB+C2HWpSyaKvQT04qBZXSwTJZvjxIMPD/ae8JxP1ElDiKKJnm1ykxv5VU1fmEez5FgETpHCCj0M97f37ApD9pFq4o+CMkRNYdKqs0JikaCvFtH4HlMqGEFLAsNgHnBk25m/5lI1vTYcbQg0xcFfY3H4YdwSx7UST9W//nkup3KeXbbp7e8l1kw6MJnEe+Nfqwy+O6sVnuPXukFBs5mm4s8wQ7qUhaoW41iBOzjE3i52RDXLGzO42nNJ5Z0GHzGbUp7JSEHDoTGNeaB5hUpGthDF17hV32Ou699wFgWVSGqHSul9ThYPdH+VoJaTLKkoxi0EMffnSL0H6CCeU+txrSXvlkoF01i/M4oDGIo4YySbPKd5XzHzpwIQlHUkeaqL4VEvX22Hx6rTn6cZgEeyaHllin+zIg1rcTr1x/Dlto1XAA17xzVhVOfuT1HBNydCqZI7ls++iW0FnkyIkSsnxKYLVRA1bog+5W4J//tzLKiJ2aPHUytYLsY1EfaxA2J2x+HT89Hv/p3S0xL1eensPRGqChtgXMeQnn8EZb1sOgGcPWvrsXeY44+1c4fYEWBH/KkziUuLWVqXY6SzTFUe8ptK7AKGV7rnAqjZkITBqy6NMkPseGwV8cME3fgDOLodib/xJD/fGYQGrjrlqgnF2q8WtveH0b5642mVEyiZZZc83UwE37gseVWzfnb2/N75orgvC9ihGHe96fIfG7izljA0AdYa8SEXZefa/5ghcF0al8wdzZjQjcgWqB5LNY+MTogbQC6EvKZ9Y5LmELaxmjizdKoUj106SOiK9rWgX vJxHnxVt a7GvaBdjS20L08dffQQFkFEYLfVTl5rRtzKpiJoyQ3vLc7biuP03CVx4dLxufIubRoFwKcI4z6hWMZ0cBbfnWE6dgPlJRFfy96g9xbFnwaO4unNW58oryO5TCKUm1O0Pt83KHKfv5ug3thTE3g/sJvAfdUywkMLcodeQWSbLjU9fEC7dSEK3zCr/9QtxzBBQIIjU1ExPNzGpausQOQD9meiZDUiq/ikYHpW4nqARgpAwxoGfNThPUOsTExX7pIbEqRj3KqkNmcmYYoptmF5Uxkpa2eI4WTFB6WtIUJZlqTgTwLCWADBJRarzmyP0NpvKQpfNfjl9pPwPZWV0TgOHsFcmwYiYMdXXruzJZUCUbiOypRMMLVQbLc5cI9N8saSAFYDng X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 09:26:21PM +0000, Easwar Hariharan wrote: > Changes made with the following Coccinelle rules: > > @@ constant C; @@ > > - msecs_to_jiffies(C * 1000) > + secs_to_jiffies(C) > > @@ constant C; @@ > > - msecs_to_jiffies(C * MSEC_PER_SEC) > + secs_to_jiffies(C) > > Signed-off-by: Easwar Hariharan > --- > arch/s390/kernel/lgr.c | 3 ++- > arch/s390/kernel/time.c | 4 ++-- > arch/s390/kernel/topology.c | 2 +- > 3 files changed, 5 insertions(+), 4 deletions(-) ... > diff --git a/arch/s390/kernel/lgr.c b/arch/s390/kernel/lgr.c > index 6652e54cf3db9fbdd8cfb06f8a0dc1d4c05ae7d7..68021cb38574b122bbe3d9f70e9168305360017b 100644 > --- a/arch/s390/kernel/lgr.c > +++ b/arch/s390/kernel/lgr.c > @@ -166,7 +166,8 @@ static struct timer_list lgr_timer; > */ > static void lgr_timer_set(void) > { > - mod_timer(&lgr_timer, jiffies + msecs_to_jiffies(LGR_TIMER_INTERVAL_SECS * MSEC_PER_SEC)); > + mod_timer(&lgr_timer, > + jiffies + secs_to_jiffies(LGR_TIMER_INTERVAL_SECS)); > } Please don't add a new line break, especially not if the new line would be shorter than the old one.