From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9C833D43FE1 for ; Mon, 18 Nov 2024 07:08:13 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 1A1896B00C2; Mon, 18 Nov 2024 02:08:13 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 151206B00C3; Mon, 18 Nov 2024 02:08:13 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 018736B00C4; Mon, 18 Nov 2024 02:08:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id D64146B00C2 for ; Mon, 18 Nov 2024 02:08:12 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 93C79AC317 for ; Mon, 18 Nov 2024 07:08:12 +0000 (UTC) X-FDA: 82798334304.07.CD01B51 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf10.hostedemail.com (Postfix) with ESMTP id 2938DC0005 for ; Mon, 18 Nov 2024 07:07:48 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731913600; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=byGcN1gtN5L32wS0h0kXx70O4KN058jcURKbL6GAmtk=; b=UvJcNO2R1+dyBzV14jd3yjCy4Th+63wd6GKpsoeKB+27OSLEMrMWYCruD11g3YvU12HL9v 8zXQYP3VRPyfr7JXLKiY1uL0ZiLhBukjgcOWl8PSYLUZMeZybnhl9EFigg3ztpzs3oInQG qz5qswApR6iX90RuYQpKyAmDjSVv490= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731913600; a=rsa-sha256; cv=none; b=V3DxC9iePqFohqrdrLS7rqphxEpYTj0JypWpWEHL/iz6bDJ1loGTcklmbJLqpy/Sna60PA MTRkSiearR1oLtS4NgU9DQ8mlhVztXLeVjiVZZvubAHmziaPrWfhPSeYvgF8K9+h9yLEey routgcCgLTYLs9ac1kHSgE8Q488Rxso= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=none; spf=pass (imf10.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de; dmarc=none Received: by verein.lst.de (Postfix, from userid 2407) id 66A2F68B05; Mon, 18 Nov 2024 08:08:05 +0100 (CET) Date: Mon, 18 Nov 2024 08:08:05 +0100 From: Christoph Hellwig To: Luis Chamberlain Cc: willy@infradead.org, hch@lst.de, hare@suse.de, david@fromorbit.com, djwong@kernel.org, john.g.garry@oracle.com, ritesh.list@gmail.com, kbusch@kernel.org, linux-fsdevel@vger.kernel.org, linux-xfs@vger.kernel.org, linux-mm@kvack.org, linux-block@vger.kernel.org, gost.dev@samsung.com, p.raghav@samsung.com, da.gomez@samsung.com, kernel@pankajraghav.com Subject: Re: [RFC 8/8] bdev: use bdev_io_min() for statx block size Message-ID: <20241118070805.GA932@lst.de> References: <20241113094727.1497722-1-mcgrof@kernel.org> <20241113094727.1497722-9-mcgrof@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241113094727.1497722-9-mcgrof@kernel.org> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspamd-Server: rspam10 X-Stat-Signature: 6rsos9iyn4yciyxezjjqy5471wfndokn X-Rspamd-Queue-Id: 2938DC0005 X-Rspam-User: X-HE-Tag: 1731913668-61449 X-HE-Meta: U2FsdGVkX18Jcq91Zbsufc1VZt6bKyBrFB87DdnktAhrTmR42wonD5fYzsRzJ9qHd7jY7jn5ZJcE9SrWT7vZvsuWkij1DNl4ruHr9KtPGfhzj7ief65PsuhPziNFMIjSR2WHEpMqMsmr+CwWRwqNtw1jHxuziWhSeXPV58tTjKdhhK6waHzDkthYqOBO98wCv+Idf79QNkOg8WtJ7Afg+j0lvFefcmBT5PJSksEC3nefUSaCQjkFviX8/YQcIlhOo2BfEisj5FT1a46EZVACUErWYFa57ZSsP0ZymkblXKVB3+tECclDRz2rtHWQDFqxg0diaRKcZrhM2s+wWR0KD2N2G2tP1+8ew2vC77b1UUnve0J/sy3bvyWcCQ5WYmCo9idHiWJVnI/2mGiuJvfRcjBlpIe7Oh3R9+HzwOXR/88wRdQyY5niygTNX1TZtoxA5ydORHiXSzQnhVO4Kk98e2GoWz9fWfsu+BVthmdoqjqFNYF6O95x95DFDoLmrOTzoX5GAIZTgDLomt6MUdV++evNxOXTGhsYC28Pugava4R9J0jhX+/+COX/9qlb5Nn428UFBXFbL+nMIqoqQZC2Sn5PToVcGx9+paNmCWpc2aWVM88fczv6V5l6KdgSfu+RIM7+jDCKrGIyqMEYayRBTumOcWWV7vXk4yiIc8FLFRPErFaEJUcqfjV+WBC2EP0kXZyg0c4rSm7gW5b779lEzWBflcGTIGC+UeVpy9dGa1dkM7lOparxFam+UYkKd4AEFIEuShOEXYm3StIGy2hYoMXykZaS11VfJ/rMus7zHwuc0Zq2oKFBmWM0Z2esjM01L6ZXIzDq+mCs3oWMFxkGGoiDcY6O9PfYrVX4ZKuvGZdtVSkgLwq7u3SDn7LeFgRt3HAsihdSA0LA8A123Dou1VNf+5WQaQ5wL5UBM3mtYsEANkjBvUFC2KMaplcj3TVhlXalSFoP0uf0S+3Gv0z iZXOhxuo R3DDrvaKYVS8zFO+NXorST5DoIMd5kuE4f8OZ4Fktj6rbG1mlTPvJRG0Bn/JCzwNf3CNxBQAMuPx5WtuMLPbcY9QIyY9mR5dRH6bSWnQNcw3aa18jZW6zmYdOCg2oGhkjLjyl6v+odFm8FgPvhkR8KDrZ8P97Z5grlUb9cYVB+q4ar4owWJMmNhRIbSq17VzFYfMn X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 01:47:27AM -0800, Luis Chamberlain wrote: > The min-io is the minimum IO the block device prefers for optimal > performance. In turn we map this to the block device block size. It's not the block size, but (to quote the man page) 'the "preferred" block size for efficient filesystem I/O'. While the difference might sound minor it actually is important. > > diff --git a/block/bdev.c b/block/bdev.c > index 3a5fd65f6c8e..4dcc501ed953 100644 > --- a/block/bdev.c > +++ b/block/bdev.c > @@ -1306,6 +1306,7 @@ void bdev_statx(struct path *path, struct kstat *stat, > queue_atomic_write_unit_max_bytes(bd_queue)); > } > > + stat->blksize = (unsigned int) bdev_io_min(bdev); No need for the cast. > if (S_ISBLK(stat->mode)) > - bdev_statx(path, stat, request_mask); > + bdev_statx(path, stat, request_mask | STATX_DIOALIGN); And this is both unrelated and wrong.