From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7FDE3D68BFB for ; Sun, 17 Nov 2024 10:54:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E15A66B00A9; Sun, 17 Nov 2024 05:54:32 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DC4906B00AC; Sun, 17 Nov 2024 05:54:32 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C3EC76B00AD; Sun, 17 Nov 2024 05:54:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id A04B26B00A9 for ; Sun, 17 Nov 2024 05:54:32 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id 54973160119 for ; Sun, 17 Nov 2024 10:54:32 +0000 (UTC) X-FDA: 82795275738.09.C40E103 Received: from casper.infradead.org (casper.infradead.org [90.155.50.34]) by imf30.hostedemail.com (Postfix) with ESMTP id 5A29A80004 for ; Sun, 17 Nov 2024 10:53:00 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="biJo/NU9"; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731840630; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=OCoqRWIGHsL5rtX+IV8/Gk+P9vZjZrxcGz8V37nCfYM=; b=ut6arP0GOz/FrmIUMJru4C3Je6PDcUj69auC879UCeE3+7tDM0uNu/fLlwuF25XGS2aX13 LeqYgI6HrE4HcTxaO/E4pvQPtCbWyVD766S1v2hD+/0xVa0mnxFHbVM3dRZAcf+T/4QBNN av0j7UlmwAd9Zpp4PuJEVq4f++w35qc= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=infradead.org header.s=casper.20170209 header.b="biJo/NU9"; spf=none (imf30.hostedemail.com: domain of peterz@infradead.org has no SPF policy when checking 90.155.50.34) smtp.mailfrom=peterz@infradead.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731840630; a=rsa-sha256; cv=none; b=rF1NBTP3e7ujLKAFW7jcCYhUXt6YMaFRAel3m4TedD1g9s6wvU9apFhPeVZwK3QJx8jMPe 7cJvYfeT2Q0ndGL7huojzRQNoZ6rpXHgRlx5aVK2DQJZ2ma7zXs5EITcMtFOFoHUx2jrsO FkDaTRMakHW+FT+l5ZAPkdM4qe7gJss= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=casper.20170209; h=In-Reply-To:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=OCoqRWIGHsL5rtX+IV8/Gk+P9vZjZrxcGz8V37nCfYM=; b=biJo/NU9RX9dHQ6M+BMDgVdWs3 BYNY1QX5RiZBUXPsA5LIjrh0JMOd8ujD+dtruLrbroRPMcJrmCTlTv04Fcu5ohmEW7CUq2UzdOHTu xO87IneWWv/Tsf5KKAfiYm7TdICauytRfIkQueZXfaMpupluGJL8Byls7V/CvgKZiM1KrAaFrE+T+ KoPMCeOkC7Mzx3z1R9KOVdfIhyrN1LOqJ6cmmfcINDPEsgIUxqtw8ub7amFgYoERSsn1IPQzJMer6 UqL6mGl5GonvrvW0noc3pLtlPBa2rT2zFgiDzppWaJFztfr6o6MnuVCHT7Gq+6TVekqg0YiWiMn3Z fR61FVeg==; Received: from j130084.upc-j.chello.nl ([24.132.130.84] helo=noisy.programming.kicks-ass.net) by casper.infradead.org with esmtpsa (Exim 4.98 #2 (Red Hat Linux)) id 1tCcv7-00000001vS7-0o9t; Sun, 17 Nov 2024 10:54:23 +0000 Received: by noisy.programming.kicks-ass.net (Postfix, from userid 1000) id B4A733006B7; Sun, 17 Nov 2024 11:54:21 +0100 (CET) Date: Sun, 17 Nov 2024 11:54:21 +0100 From: Peter Zijlstra To: Alexei Starovoitov Cc: bpf , Andrii Nakryiko , Kumar Kartikeya Dwivedi , Andrew Morton , Vlastimil Babka , Hou Tao , Johannes Weiner , shakeel.butt@linux.dev, Michal Hocko , Tejun Heo , linux-mm , Kernel Team Subject: Re: [PATCH bpf-next 1/2] mm, bpf: Introduce __GFP_TRYLOCK for opportunistic page allocation Message-ID: <20241117105421.GB27667@noisy.programming.kicks-ass.net> References: <20241116014854.55141-1-alexei.starovoitov@gmail.com> <20241116194202.GR22801@noisy.programming.kicks-ass.net> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 5A29A80004 X-Stat-Signature: ueft9bknzbuyitx3ek7fekdjqcrc7soi X-Rspam-User: X-HE-Tag: 1731840780-362890 X-HE-Meta: U2FsdGVkX1/ASF1wIW7sQbRvZej5zslnowb6S54jGNF0xvmVBCs7szo5HpZKX2yjzg+pu4p3gUOhZy7vlnLsgAEatU+YM+a736LHLHEQLTrRTKOuqRlremlC+/T39jdV7k5EzMWSN7gH+eTvZAodKx6YoD+K2GkIcoX88VICNAvEbo9GWQ5354o+AMnyvll2cNJHQpDnJFvDAmC9cjHCreimju1R9qoo86XTS3iyawb4+TxZBE6zy+3JVHMzeOGW+0p4VnnJNDOH20fV3BYBcM8GF75mLTFIyWcp/3NktxEHozpIfHCYSiWHAJyqcBseXwan9c6yCppCFV5CnOTqIkE8JbfAYK2X4MC9FEZ4RWALCrqVxaRQ1G48cP5VpJdcrKk740D03sOppHhSlTPq5zJeBbXqNXh0tJxHo7lLODAHK/eRbKYGTqGAyC5kRynxi95iDdEaM8E1MTX1YCjhR3iXJU/vVgO5XoSZbmFVg6X8UYC6GuH6naSTgeSlYOSlCjqpKRqVF3tvIryPpSFGEGGoqK40nVoxFjxHn24PZOkn1nTD0hd4ywQvN/NSgYQqTObKdwEi38zLBtUGQN0fwpUmoefFxa2L6rj/ipqA4cZ8VIvz0o7ix3sBdmEV6xxorB/dP48lNgv2D85M6gLPCELCk4ZA3Kev6vp3dTmmLqvio914TgC0zlVbyKz5e+YJ4+NfnLiclwI8yaEpP8lf/WKOqglTMEmXRizrLbES9AtxV8trR1IfWP1jYFQCKKtU5LlUgPWFIgj8aePc+uePFgpWwxu0ISE6QEFCYbtsIFatXJZoYsd6SIYHAF0sGBdZs1XCMiKoJiFrfcbCvO3vBqaMMGG3dOwpXYnxm7gPYaaNhrSwYojZjOxx6X9cOnFSLD0IyBoYv4UfIrejMrpEtcWZKjLbgIQKcU6SeI4Xpe02lyZoTbSEQLEXVMQT0Hxytpz2bxn1BY/f9ds2IIL zDoYwYQO NdEkfQdrdK7Jt0pP9L8uWStuiRLRiqTqeTjHpobp8ivqN/ph0W8646RwO3HxNElV86uMMF+xBMBCshihD/F8Le8f6Zw7rQnSYfYyW6sIRKoicY9uqBKIH8z/eTDQf0/NyOmhueYOa+SLbPNQUPoiBwPLeJDYjxGH9pKiT106J5GDRbkPz0JzQkgCWeqSRkSkWlsg8m1S4WykDM1qeFiNZexHLpuukaOb2Kc/wA6haBuT0nBexVx4+4KBW8K5uAhSQSyIjMSB3Ku9ZHe3lqwniAdKc+HA4VQtpZFgk6EowYLMHuJwOiM2+RfWDRg== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, Nov 16, 2024 at 01:41:41PM -0800, Alexei Starovoitov wrote: > > The maze of ifdef-s beat me :( > > It doesn't increment in PREEMPT_RCU. > > Need an additional check then. hmm. > > Like: > if (preemptible() && !rcu_preempt_depth()) > return alloc_pages_node_noprof(nid, GFP_NOWAIT | __GFP_ZERO, 0); > > Not pretty, but should do. Yeah, I suppose that should work. Thanks!