From: Peter Zijlstra <peterz@infradead.org>
To: Alexei Starovoitov <alexei.starovoitov@gmail.com>
Cc: bpf <bpf@vger.kernel.org>, Andrii Nakryiko <andrii@kernel.org>,
Kumar Kartikeya Dwivedi <memxor@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Vlastimil Babka <vbabka@suse.cz>, Hou Tao <houtao1@huawei.com>,
Johannes Weiner <hannes@cmpxchg.org>,
shakeel.butt@linux.dev, Michal Hocko <mhocko@suse.com>,
Tejun Heo <tj@kernel.org>, linux-mm <linux-mm@kvack.org>,
Kernel Team <kernel-team@fb.com>
Subject: Re: [PATCH bpf-next 1/2] mm, bpf: Introduce __GFP_TRYLOCK for opportunistic page allocation
Date: Sun, 17 Nov 2024 11:54:21 +0100 [thread overview]
Message-ID: <20241117105421.GB27667@noisy.programming.kicks-ass.net> (raw)
In-Reply-To: <CAADnVQJm64vyeXehTVRbyFqHuuPQWgD-iBYqCChjQE+tHTbKGA@mail.gmail.com>
On Sat, Nov 16, 2024 at 01:41:41PM -0800, Alexei Starovoitov wrote:
> > The maze of ifdef-s beat me :(
> > It doesn't increment in PREEMPT_RCU.
> > Need an additional check then. hmm.
>
> Like:
> if (preemptible() && !rcu_preempt_depth())
> return alloc_pages_node_noprof(nid, GFP_NOWAIT | __GFP_ZERO, 0);
>
> Not pretty, but should do.
Yeah, I suppose that should work. Thanks!
next prev parent reply other threads:[~2024-11-17 10:54 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 1:48 Alexei Starovoitov
2024-11-16 1:48 ` [PATCH bpf-next 2/2] bpf: Use try_alloc_page() to allocate pages for bpf needs Alexei Starovoitov
2024-11-16 19:42 ` [PATCH bpf-next 1/2] mm, bpf: Introduce __GFP_TRYLOCK for opportunistic page allocation Peter Zijlstra
2024-11-16 21:13 ` Alexei Starovoitov
2024-11-16 21:34 ` Alexei Starovoitov
2024-11-16 21:41 ` Alexei Starovoitov
2024-11-17 10:54 ` Peter Zijlstra [this message]
2024-11-17 10:50 ` Peter Zijlstra
2024-11-17 10:54 ` Vlastimil Babka
2024-11-19 0:40 ` Alexei Starovoitov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241117105421.GB27667@noisy.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=alexei.starovoitov@gmail.com \
--cc=andrii@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=houtao1@huawei.com \
--cc=kernel-team@fb.com \
--cc=linux-mm@kvack.org \
--cc=memxor@gmail.com \
--cc=mhocko@suse.com \
--cc=shakeel.butt@linux.dev \
--cc=tj@kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox