From: linux@treblig.org
To: willy@infradead.org, akpm@linux-foundation.org
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Dr. David Alan Gilbert" <linux@treblig.org>
Subject: [PATCH] filemap: Remove unused folio_add_wait_queue
Date: Sat, 16 Nov 2024 15:14:46 +0000 [thread overview]
Message-ID: <20241116151446.95555-1-linux@treblig.org> (raw)
From: "Dr. David Alan Gilbert" <linux@treblig.org>
folio_add_wait_queue() has been unused since 2021's
commit 850cba069c26 ("cachefiles: Delete the cachefiles driver pending
rewrite")
Remove it.
Signed-off-by: Dr. David Alan Gilbert <linux@treblig.org>
---
include/linux/pagemap.h | 5 -----
mm/filemap.c | 19 -------------------
2 files changed, 24 deletions(-)
diff --git a/include/linux/pagemap.h b/include/linux/pagemap.h
index 68a5f1ff3301..4650416cbf6c 100644
--- a/include/linux/pagemap.h
+++ b/include/linux/pagemap.h
@@ -1267,11 +1267,6 @@ void folio_end_private_2(struct folio *folio);
void folio_wait_private_2(struct folio *folio);
int folio_wait_private_2_killable(struct folio *folio);
-/*
- * Add an arbitrary waiter to a page's wait queue
- */
-void folio_add_wait_queue(struct folio *folio, wait_queue_entry_t *waiter);
-
/*
* Fault in userspace address range.
*/
diff --git a/mm/filemap.c b/mm/filemap.c
index 56fa431c52af..b1bdd8ce7f49 100644
--- a/mm/filemap.c
+++ b/mm/filemap.c
@@ -1473,25 +1473,6 @@ static int folio_put_wait_locked(struct folio *folio, int state)
return folio_wait_bit_common(folio, PG_locked, state, DROP);
}
-/**
- * folio_add_wait_queue - Add an arbitrary waiter to a folio's wait queue
- * @folio: Folio defining the wait queue of interest
- * @waiter: Waiter to add to the queue
- *
- * Add an arbitrary @waiter to the wait queue for the nominated @folio.
- */
-void folio_add_wait_queue(struct folio *folio, wait_queue_entry_t *waiter)
-{
- wait_queue_head_t *q = folio_waitqueue(folio);
- unsigned long flags;
-
- spin_lock_irqsave(&q->lock, flags);
- __add_wait_queue_entry_tail(q, waiter);
- folio_set_waiters(folio);
- spin_unlock_irqrestore(&q->lock, flags);
-}
-EXPORT_SYMBOL_GPL(folio_add_wait_queue);
-
/**
* folio_unlock - Unlock a locked folio.
* @folio: The folio.
--
2.47.0
next reply other threads:[~2024-11-16 15:14 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-16 15:14 linux [this message]
2024-11-18 7:58 ` David Hildenbrand
2024-11-18 18:58 ` Vishal Moola
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241116151446.95555-1-linux@treblig.org \
--to=linux@treblig.org \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox