From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30C83D68BF0 for ; Sat, 16 Nov 2024 14:21:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 2FC966B00C2; Sat, 16 Nov 2024 09:21:10 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 25B9B6B00C3; Sat, 16 Nov 2024 09:21:10 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0399E6B00C4; Sat, 16 Nov 2024 09:21:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id C9EAC6B00C2 for ; Sat, 16 Nov 2024 09:21:09 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 21BB4401E0 for ; Sat, 16 Nov 2024 14:21:09 +0000 (UTC) X-FDA: 82792168872.24.87C4B21 Received: from fhigh-a7-smtp.messagingengine.com (fhigh-a7-smtp.messagingengine.com [103.168.172.158]) by imf11.hostedemail.com (Postfix) with ESMTP id 1D2E540010 for ; Sat, 16 Nov 2024 14:20:08 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=jannau.net header.s=fm2 header.b=QfzbBeD1; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="I niUWIz"; spf=pass (imf11.hostedemail.com: domain of j@jannau.net designates 103.168.172.158 as permitted sender) smtp.mailfrom=j@jannau.net; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731766720; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=NnZ+71/DdSs2iQZjBK1OW6Bj8CARVk7Y17qna5/pE2E=; b=EH//SXmGd0XliGJslxB1b5eTyngQUSZICWBLEU5C9NTkHFltnd57XH5L7GVb/APLcMrpIl gTgFZM/Y/YcI3FdkHCZgMecmybCCtK+E79VG+Re53WxJ3EiQTUwIJx8E3SR9fHXY6kE3iy 98yZLWAKlcI8XH81zIKOI2AzPNve8DA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731766720; a=rsa-sha256; cv=none; b=IVE5tmgMfimXzSvOm576tWMIm/BKZQKwOWxEQXdd5ulsDtaeCKM9ZFbAU7wTjXynojaPWE 8aFcEdSnubWTsKyEt28DSxE/yreKU721QgyFz4PhdZWWgM2BcxrAy/hJJ7gOTNfBto9L6V dvRT4zDY1deNVFQ/zsHIkfCC3vk0l70= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=jannau.net header.s=fm2 header.b=QfzbBeD1; dkim=pass header.d=messagingengine.com header.s=fm3 header.b="I niUWIz"; spf=pass (imf11.hostedemail.com: domain of j@jannau.net designates 103.168.172.158 as permitted sender) smtp.mailfrom=j@jannau.net; dmarc=none Received: from phl-compute-10.internal (phl-compute-10.phl.internal [10.202.2.50]) by mailfhigh.phl.internal (Postfix) with ESMTP id 4B05C1140135; Sat, 16 Nov 2024 09:21:06 -0500 (EST) Received: from phl-mailfrontend-01 ([10.202.2.162]) by phl-compute-10.internal (MEProxy); Sat, 16 Nov 2024 09:21:06 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=jannau.net; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to; s=fm2; t=1731766866; x=1731853266; bh=NnZ+71/DdSs2iQZjBK1OW6Bj8CARVk7Y17qna5/pE2E=; b= QfzbBeD1RW/sWNjFNlzCSXgCVpVSGop3t7yqoUBDXT/zIHbFXXZnQUTy/gClkqN0 KdkGaF1dpXHcTT9cTz4L9F2UIaoJfJyahVri7boWGXscUDwRKBJpzclLM5y/z4qx N8US60oPqTga9qfTaf8iPuubS/GpqWR6E5VtU++Tn7HlASRIEz5E+j0SoLXbHV5z FQuSKyXeJZfT3jSLiTmZrj8k6HxSHHsKiB9dtTOMbQG0kW1dxWIZfntJ4HoVucP0 /UK/F3+qEEg3PIZQr/s0YrYX1VhIxTA1QY7YtKKsyOzx0OBbDdoCNQGhmZ9m/D8t qtJcKJeN4YnXZH2QUIoSow== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:subject:subject:to:to:x-me-proxy :x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t=1731766866; x= 1731853266; bh=NnZ+71/DdSs2iQZjBK1OW6Bj8CARVk7Y17qna5/pE2E=; b=I niUWIzZSVccQU9QPJoduSkdkMzUMyph5sqPfidr+xGwaHqDPCArdbPOJR6dB0fWo y4d5aIdQnOdhOLt14C20UD87lA6isoditurhOgliQoAFPnBrzJRULnSya/68cjgx V8cwH8L2kto4utteQH70+rK1rMdvxAecGtU89+kZfPziJEdFdfsI6/IqT5E3Fz+/ OLhTCyNpFzaU8ZPGQ9UFkFF9DIG3h3ULUrnvBrj1b3KtyFrJIwLFH8U79PKSp2hT 2hPhwgITlwug6MD/6BwLYzUKNeRloyRwiN3bg41qhWoF0S0hpPiEdoMQyIeCNZxs v4Z9WQtOtn665u+aGIxQw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeefuddrvdeigdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpggftfghnshhusghstghrihgsvgdpuffr tefokffrpgfnqfghnecuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnth hsucdlqddutddtmdenucfjughrpeffhffvvefukfhfgggtugfgjgesthekredttddtjeen ucfhrhhomheplfgrnhhnvgcuifhruhhnrghuuceojhesjhgrnhhnrghurdhnvghtqeenuc ggtffrrghtthgvrhhnpeevfeekuedutedtvdffvefhvedvkefhgfevheefhfffheeftefg teffuefgveefhfenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfh hrohhmpehjsehjrghnnhgruhdrnhgvthdpnhgspghrtghpthhtohepvdeipdhmohguvgep shhmthhpohhuthdprhgtphhtthhopegrlhhitggvrhihhhhlsehgohhoghhlvgdrtghomh dprhgtphhtthhopehlihhnrgesrghsrghhihhlihhnrgdrnhgvthdprhgtphhtthhopegu rghkrheskhgvrhhnvghlrdhorhhgpdhrtghpthhtohepohhjvggurgeskhgvrhhnvghlrd horhhgpdhrtghpthhtoheprghlvgigrdhgrgihnhhorhesghhmrghilhdrtghomhdprhgt phhtthhopeifvggushhonhgrfhesghhmrghilhdrtghomhdprhgtphhtthhopegsohhquh hnrdhfvghnghesghhmrghilhdrtghomhdprhgtphhtthhopehgrghrhiesghgrrhihghhu ohdrnhgvthdprhgtphhtthhopegsjhhorhhnfegpghhhsehprhhothhonhhmrghilhdrtg homh X-ME-Proxy: Feedback-ID: i47b949f6:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Sat, 16 Nov 2024 09:21:04 -0500 (EST) Date: Sat, 16 Nov 2024 15:21:02 +0100 From: Janne Grunau To: Alice Ryhl Cc: Asahi Lina , Danilo Krummrich , ojeda@kernel.org, alex.gaynor@gmail.com, wedsonaf@gmail.com, boqun.feng@gmail.com, gary@garyguo.net, bjorn3_gh@protonmail.com, benno.lossin@proton.me, a.hindborg@samsung.com, akpm@linux-foundation.org, daniel.almeida@collabora.com, faith.ekstrand@collabora.com, boris.brezillon@collabora.com, mcanal@igalia.com, zhiw@nvidia.com, cjia@nvidia.com, jhubbard@nvidia.com, airlied@redhat.com, ajanulgu@redhat.com, lyude@redhat.com, linux-kernel@vger.kernel.org, rust-for-linux@vger.kernel.org, linux-mm@kvack.org, asahi@lists.linux.dev Subject: Re: [PATCH v9 00/29] Generic `Allocator` support for Rust Message-ID: <20241116142102.GA1484376@robin.jannau.net> References: <20241004154149.93856-1-dakr@kernel.org> <3b843e34-48f3-41ca-bd83-9bc137ca6c76@asahilina.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 1D2E540010 X-Stat-Signature: ffd59nzahde9kegqzkci95ywd5741kca X-HE-Tag: 1731766808-119571 X-HE-Meta: U2FsdGVkX19fZiVu85OM0NXlyBxxAiRtU4KaBMZtINNd3hP1aahfvOtzuVavkwOXsmsE+N69DzjP3ETbNax0/75zuDEoe5GzNQui5ozI054zGV8IsMxmbOayDmiCpkCH+S3fnxmEZBZY9Aj0iHFvNbcbMrD4oidNiwFrEynymUAMU2+vSZdgMk/Rey/gJ+l9P2XEUeMy3ozVtr3YLwocgcGam7/6Q11W8h74OmOScHt6Ty2tH+hLaaxnIMkFa4Xitz7ZP22gNYtb3LjlNe08vC397t7Q1AnHmSX6DOAUCCtmyftV9LomWwS24ZH/5swike0XOzFU8lQE8Vd5QG9iLUzspU3349nUwoYopvQC5anacOEoPovj2GD261JDx4GBkWdZTld/leY5hwwFutW/Q8wq2P6Ehz726UZZ5ySCbmXy1gWJPZZz0ur846AF81orFAHKWHwmrq4zYrhm1/Gma5llHmSr5OP+ImTGnHXvhWB/cO5GT2O68gT72I0LDnyVuIj4yTQZET45qq21A43RIekcH6W+85QJ7P6JsDUfLvDp6lYptBpvFFmouauREF6E+qI97POTdCnNqmHQYe4igJwdaJFGcJzLZczEg2qFkf9Ml3MHrvn8tOHCbALsoVEeDY9RDSKIQz7O+nTzlpiQ0c/eUK2RU4rec+tQTSw2VornjGcdWKmrpMdaZoBGlpQy0OIG60Sa+xMqU8HH6fuezU1J2t2v806rQelIsN+snW85U9K90cZbLfTOVKj5iz/HswsTyj+j88TUsdHd79WcMTS+waINK+P0GMlBSPxQHeQYC/U5mOnscoUm0IlOMQGbPPKyr36CnxHdSWSnV4u4aqH8VbNsVuwGxYZhfIe7lLm3XepcKV3yetKzM1IGjYKJvFqJDH7c20nD9u0oPYXZhwnbsSAtmIGk3nWKr77Ya02RGpvSiMsm5qZ3IO6/UCQuRr6huaJ0AHRrnN3ZV19 B5uew7oF nCUcO2jbUzxcXZv25VbP4zY6q8y8ErMydbPQNfDtZPi/lNzbr66sZUH84cqY22/UesAKPDRlJ6QzWWUlYc5ZuCYHXlZoZOmEkHR+XA8aok//SAJeI57ULMFrGYZl4YAqPSP5oXv+Jwq5XW00FTncUR/hrmVskVuEZ3enzstQ+4YaDIpYdYV4FLgFstI7ZFXvNWf0RtkUcE6NptUkl/zaQLQzFUUL3fj4gzClqOr974XmsENjAs3KewKDZahdkmwtuQ32Qv+9XvdrFBdfHC+coJGwpsbaz1JH5LP8nggG26UYuCHi7YbVafSMssKLhxcuJdwjBLxxcwhOxONsFo5f4U9hJ37OHdY0xGCP5e+D4H5WGs2WoVZx1TNHglmqJNMDtsGkHtZyxOWzfUuMcR10BzbWoxBze04O8sDywfpk5Ks5m0P2kKN2jtrkY+9ybKe8FkJ/seHouD3nRCAg= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 15, 2024 at 03:00:43PM +0100, Alice Ryhl wrote: > On Fri, Nov 15, 2024 at 12:33 PM Asahi Lina wrote: > > > > We (Asahi Linux) noticed that this doesn't support unsized types, which > > is a regression from the alloc Box. drm/asahi uses boxed trait objects > > to generalize across certain object types like render commands, so this > > breaks the driver. > > > > Is there a plan to add this back in? AIUI this would need the > > coerce_unsized unstable feature, but is there any other blocker? > > We're already using coerce_unsized for Arc, so I see no reason we > can't just add that for KBox too. Soon, we should be able to use the > derive macro [1] I proposed to do this without unstable language > features. The limitation that the RFC mentions for custom allocators > does not apply to KBox because it uses PhantomData instead of A for > the allocator field. I have branch rebased onto rust-next and Danilo's "Device / Driver PCI / Platform Rust abstractions". In addition to coerce_unsized for kbox kvec misses the unproblematic methods clear and truncate and array_try_from_vec. drain() as taken from the rust library looks like more effort considering kvec's IntoIter. Janne