From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E1D3CD68BDA for ; Fri, 15 Nov 2024 22:38:25 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 603DE6B00BB; Fri, 15 Nov 2024 17:38:25 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 58D446B00BC; Fri, 15 Nov 2024 17:38:25 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 3B7876B00BF; Fri, 15 Nov 2024 17:38:25 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 1A4AD6B00BB for ; Fri, 15 Nov 2024 17:38:25 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id ADB06AB70E for ; Fri, 15 Nov 2024 22:38:24 +0000 (UTC) X-FDA: 82789793142.30.DE83A39 Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf07.hostedemail.com (Postfix) with ESMTP id 05DC840002 for ; Fri, 15 Nov 2024 22:37:17 +0000 (UTC) Authentication-Results: imf07.hostedemail.com; dkim=pass header.d=canb.auug.org.au header.s=201702 header.b=dvqBU9n8; dmarc=pass (policy=none) header.from=canb.auug.org.au; spf=pass (imf07.hostedemail.com: domain of sfr@canb.auug.org.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=sfr@canb.auug.org.au ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731710123; a=rsa-sha256; cv=none; b=7vNc66fil2WwQvIG48aEjvnH/ptblkBdzKShM21inEZumAsZE7ImgRwhbkAS5r9WsoZN/b RyawyeG4jUyyoW+H2b/Fg/YQSAjMTTxa63zMRo7/CJuj7lrvsd2Ceg+CeL/Mkx21nJ3hxN yfi+tq5FjQj0S+2ntveJVNuSE4lR7lE= ARC-Authentication-Results: i=1; imf07.hostedemail.com; dkim=pass header.d=canb.auug.org.au header.s=201702 header.b=dvqBU9n8; dmarc=pass (policy=none) header.from=canb.auug.org.au; spf=pass (imf07.hostedemail.com: domain of sfr@canb.auug.org.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=sfr@canb.auug.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731710123; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=2Oo8tuThL69UywoHNtNWphGeN1l/Ks7ZdfhLn6nu8Ts=; b=XOYF1sbFSRLr6BT1TCygZgbbsyTkKH4XC44d1Xw5tbJimp/TcYL/pvFjrulAR5qpAsFCGX vf18v7HxIorlKRZDediOJgqscpUt28SanEL90yHK0SemDtCEMldCKqvh9laMSHBE84XwZs c+4ZbQ5+rV4w+QC4fQSJq/MJ/u/nBu4= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1731710297; bh=2Oo8tuThL69UywoHNtNWphGeN1l/Ks7ZdfhLn6nu8Ts=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=dvqBU9n8wyesGOM7wAJUVL4V50umalSR9AGyHvO50R9rHL4dRlvqV2fKiGIxclon7 dHEpXPpW9NVhcbFtMBHzRNkcGVSkeVB/y2szbGMNYINCZkHzmLDf1115Jxe24OTeOk GNv8daj8Y6W/lBqt6k/toExNrcSvGF2/nzg0QTmOQX9jzDpl13KzERpvnsypqwk14l Jr2Y6hhhHGQcduaub5tIB8ldj0pYnhXmYJw4zK368Q9lExm0iQorTgylYyIdDuEGMp WagrfQz4Kwg8LTMJpR3GyN8L1t3g91kYKCDixQ+vf1WORv4sLKKi8JfCCFjRz+Eeni +eMZUx+2BK6mA== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4XqsP22nY1z4x8v; Sat, 16 Nov 2024 09:38:14 +1100 (AEDT) Date: Sat, 16 Nov 2024 09:38:15 +1100 From: Stephen Rothwell To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?UTF-8?B?TW9ubsOp?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH 03/22] arm: pxa: Convert timeouts to use secs_to_jiffies() Message-ID: <20241116093815.5d37eb43@canb.auug.org.au> In-Reply-To: <20241115-converge-secs-to-jiffies-v1-3-19aadc34941b@linux.microsoft.com> References: <20241115-converge-secs-to-jiffies-v1-0-19aadc34941b@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v1-3-19aadc34941b@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/4rVE82Kt6y+3_PbwMmwogMj"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Stat-Signature: pabpbwr5dwnjuhnt7snzrhmpb61cxazs X-Rspamd-Queue-Id: 05DC840002 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731710237-735648 X-HE-Meta: U2FsdGVkX19QMErXFw48uMphtscGsMU4TpBfNpNyVPCcQgp8FHyVfeyn8QNs5AhLdvZGqgje4nN5NSI6S1QKMsKyihML8UfYHNx1dbZ2vHnP4+oVGcws2DLi3WG+kZdVlNnIWW86nmKdxv1aLZ7iYMhP4EkVB7CVV1KVPwRuKsgtsMowvFGB8EQSF2jgdpIdEKDHBYwxTgBWh5esxwohgAnZuGHOFT+IytTrbdHIIebCFIOKueAl7WQvuAgS/lel2zMVNm6SGIi/851bBQD+7Zfc+N9hS9tsiwdrm4DaHPNkrn/lOQEJPIsLyNho97vWpxkDZKDnVwFvn82sWwlOA4u11NnYgTyk35lgPObMLkrXv5p+oXxusmwqczb4AwA3W+HUI0GSNajPhLrNtJ3WP6ppm9Z1AcyzsYnJBfc/MLINXmd9zSMK1ZObrvEiZmhQXh5cY6uNmfUCtQT+aJS/3VNu3LGlEiQDdKgeHzthu0576ClhgJT+nEYWs7o7cwwchPDR0eZsAQkbn9IIRD2oHuhEMpeF//PAPJFCcQDiHGSVsWBsVhijEuWBxx2rucaii5Vkvq/suwrrxYXILYfBcxSZNtGuWzl4FGjjChzEAiw30Vb3g0ck8946SKz+TOYAeoBDBQ6O/ZRKa+uTBCTTYHZQoRh4mB8DHb3MCFFrQKD+ErsM9P+gbZ4SR/b5FvMnjxadDOLQVNGy5imHaIK9oCvPnq44gZqPO0SxBVDgCPQJ7AE5+yElr+NLJFUmd3mKCW8Vr+8jINkxERhlxwj1ybv+A3T3kYBaiwWYcPv4rmM2MHFXrKPN4hV3yOVp9iFY8Ap45uEMJUINRxAqsumzACpCaXMkWQhPy0SgUFRyT9KUA07+g6g3VJAUkkAQYqDgK2N0yE4iK+/fIGBj3Khc+kPaf4j4G1h1aVvDu8T11SEss+vj3aBTYbrjyic0UFn+d2DOtrDNBT1nmwRaZYe +Wqvi3YF Ad5VwYlxqklmt4qRyjiGwjd0O+sgLU86UgtVYIWjRbHlEdc38LVoQ3CeZSi2+B2ODBVHObELODIvTEh1XrEbzl3aIbn5P0M0oZWBjYd+LKZSrl6WZiURm7kn26H5rLBKHQiLmQkHW0FthsTKGQFB/r9/rKZ332QFOPhSzCnFwNJBvND+5mEC82etmq6FPI5F48vcqGKJrjFL1kEXfSWut4wsGV8vRzxwwdRSJkqWS+a927DFprZSZcOvFRJ3MkERyDmk6q7sWIau73UrC0Vpi+Sp4EHF6Y/IftMP8RO8f2XIRHrPHWc2TQppw969g/bSbxp2lWl1rMzXc+/71AafbTGrHCb1yJIhbdOB3xiTUAWSiS7QvDU1um8BoTxdXkKj7IYAMEIxE6czniwprApz/XnrMCA+aTOscXeKxdR1axdxHAjiGjGCoCH+862Y9RhpqJI7hPp1bz25eu9mbdI9amKPbVjZI24K8l/zawjVlEyycnNQnVC9QfM0CiuPRX71iKT2kgGXna95ZH9/RwzX0qJSddQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --Sig_/4rVE82Kt6y+3_PbwMmwogMj Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Easwar, On Fri, 15 Nov 2024 21:22:33 +0000 Easwar Hariharan wrote: > > -#define SHARPSL_CHARGE_ON_TIME_INTERVAL (msecs_to_jiffies(1*60*10= 00)) /* 1 min */ > -#define SHARPSL_CHARGE_FINISH_TIME (msecs_to_jiffies(10*60*1= 000)) /* 10 min */ > -#define SHARPSL_BATCHK_TIME (msecs_to_jiffies(15*1000= )) /* 15 sec */ > +#define SHARPSL_CHARGE_ON_TIME_INTERVAL (secs_to_jiffies(60)) /*= 1 min */ > +#define SHARPSL_CHARGE_FINISH_TIME (secs_to_jiffies(10*60)) = /* 10 min */ > +#define SHARPSL_BATCHK_TIME (secs_to_jiffies(15)) = /* 15 sec */ It might be nice to keep the alignment of the comments here. --=20 Cheers, Stephen Rothwell --Sig_/4rVE82Kt6y+3_PbwMmwogMj Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmc3zVcACgkQAVBC80lX 0GyUXgf+Ii9yOHf1vRadjfzExIFyJR4I0mG1VXDEBH24ASdL/jVIFlfW31h/JIe9 7JJFAL5Aa+C8Xw22mmq/8e0wbWCe+DqEq+SLtggkTN8kHtwf7Glda0a/aIix0pNM s9nQXwrTFFvaCt2ocRmPUcm7K/jwiG3YxWawYBvIoSF9l/TfQXwD4LBbP2glFEL2 BkTvGG0/asLCHZK2LHwDsWsZ5XskgJmmQfbYEdygcm9C3bP40tFYUM22B6iEYNez WKquyY7lAmwUJQsIAWZig/PKPz8e6uux6ghIdGbwFC0ezQqIOAz8ZqllWy1Dpa87 vCjZSu4lRCFBg5npBBL5wIOagKFSCw== =vmyn -----END PGP SIGNATURE----- --Sig_/4rVE82Kt6y+3_PbwMmwogMj--