From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 71F66D68BDB for ; Fri, 15 Nov 2024 22:35:19 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id EDE236B00B6; Fri, 15 Nov 2024 17:35:18 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id E8D2C6B00B7; Fri, 15 Nov 2024 17:35:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D05FC6B00B8; Fri, 15 Nov 2024 17:35:18 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id AF4456B00B6 for ; Fri, 15 Nov 2024 17:35:18 -0500 (EST) Received: from smtpin15.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 6D19A1A0681 for ; Fri, 15 Nov 2024 22:35:18 +0000 (UTC) X-FDA: 82789785624.15.D274D5C Received: from mail.ozlabs.org (gandalf.ozlabs.org [150.107.74.76]) by imf10.hostedemail.com (Postfix) with ESMTP id 7DF92C0009 for ; Fri, 15 Nov 2024 22:34:55 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=canb.auug.org.au header.s=201702 header.b=TBKjQ+jw; spf=pass (imf10.hostedemail.com: domain of sfr@canb.auug.org.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=sfr@canb.auug.org.au; dmarc=pass (policy=none) header.from=canb.auug.org.au ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731710027; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=8q2Y3qiG3ZOOjZQQW66Agp5RO04F9uaeWnu9irwI8zs=; b=SwO5wqhCRKVnoHX5pXouSINzn8N6HA8sHTjZHSCd/L1uY9KEwI7TfTuUq1Ej7IYq3gnWGQ qdoSV9iR7gSW42n72Ec4R/ImOpU94pDTGJpYPGxP0sfbmiTYZzzhr4c0KbRLhXLWmknT4f U63tO9Re2IjrEgpL8TUeNLliWnnfDmg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731710027; a=rsa-sha256; cv=none; b=d3nR5TdpiA7kwEwftFxNbDm36JvjFpOux9GsyOkBH5OfsY9THy0c57Cddt/dlc0wJdAoR/ aKCTxdsM75MBXoyWEEpGG3Jzmh4OCtx9ZCS3lySPYXGi0DkmZq+xYfWGJ4+Buw5hbHWjdy FSraje10Y+b2Y/6I/DFMyPtuqat0ypA= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=canb.auug.org.au header.s=201702 header.b=TBKjQ+jw; spf=pass (imf10.hostedemail.com: domain of sfr@canb.auug.org.au designates 150.107.74.76 as permitted sender) smtp.mailfrom=sfr@canb.auug.org.au; dmarc=pass (policy=none) header.from=canb.auug.org.au DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canb.auug.org.au; s=201702; t=1731710109; bh=8q2Y3qiG3ZOOjZQQW66Agp5RO04F9uaeWnu9irwI8zs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=TBKjQ+jwynGqippSpjmesy2LJHz5G28IT7vT4TaT88JCuw46fBO3BDRAIPv6hRM7/ XbOWv6yTpIGUBOHVpD+GgH5bOcDzYCKCOUCxtFJITpudgYieUI+GdoU8psZqrHYs9B plWGzIOASib2U9DXo1e9xJXfQHkgKNH8Cirh/o/LRzKV85o+Cp3r3eBc9AZ3AQZa0F DYP1RPyQiMfC70ZKaMZkgpPnHyLFqXq1SQIh8oIfiAurmRjt4FWX01yMlsvyocz2uk oad7uD2rsh8nj5e0aZSH5jUluHbC7REOnBIrLNo1QEsXfDYgF3levquGraIQNcBhLm 5y9gdjsr1Cmwg== Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (prime256v1) server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mail.ozlabs.org (Postfix) with ESMTPSA id 4XqsKD5FnLz4x3p; Sat, 16 Nov 2024 09:34:56 +1100 (AEDT) Date: Sat, 16 Nov 2024 09:34:58 +1100 From: Stephen Rothwell To: Easwar Hariharan Cc: Pablo Neira Ayuso , Jozsef Kadlecsik , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Simon Horman , Julia Lawall , Nicolas Palix , Daniel Mack , Haojian Zhuang , Robert Jarzmik , Russell King , Heiko Carstens , Vasily Gorbik , Alexander Gordeev , Christian Borntraeger , Sven Schnelle , Ofir Bitton , Oded Gabbay , Lucas De Marchi , Thomas =?UTF-8?B?SGVsbHN0csO2bQ==?= , Rodrigo Vivi , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter , Jeroen de Borst , Praveen Kaligineedi , Shailend Chand , Andrew Lunn , James Smart , Dick Kennedy , "James E.J. Bottomley" , "Martin K. Petersen" , Roger Pau =?UTF-8?B?TW9ubsOp?= , Jens Axboe , Kalle Valo , Jeff Johnson , Catalin Marinas , Andrew Morton , Jack Wang , Marcel Holtmann , Johan Hedberg , Luiz Augusto von Dentz , Greg Kroah-Hartman , Florian Fainelli , Ray Jui , Scott Branden , Broadcom internal kernel review list , Xiubo Li , Ilya Dryomov , Josh Poimboeuf , Jiri Kosina , Miroslav Benes , Petr Mladek , Joe Lawrence , Jaroslav Kysela , Takashi Iwai , Lucas Stach , Russell King , Christian Gmeiner , Louis Peens , Michael Ellerman , Nicholas Piggin , Christophe Leroy , Naveen N Rao , Madhavan Srinivasan , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, cocci@inria.fr, linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, dri-devel@lists.freedesktop.org, intel-xe@lists.freedesktop.org, linux-scsi@vger.kernel.org, xen-devel@lists.xenproject.org, linux-block@vger.kernel.org, linux-wireless@vger.kernel.org, ath11k@lists.infradead.org, linux-mm@kvack.org, linux-bluetooth@vger.kernel.org, linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, ceph-devel@vger.kernel.org, live-patching@vger.kernel.org, linux-sound@vger.kernel.org, etnaviv@lists.freedesktop.org, oss-drivers@corigine.com, linuxppc-dev@lists.ozlabs.org, Anna-Maria Behnsen Subject: Re: [PATCH v2 01/21] netfilter: conntrack: Cleanup timeout definitions Message-ID: <20241116093458.4aa19a0e@canb.auug.org.au> In-Reply-To: <20241115-converge-secs-to-jiffies-v2-1-911fb7595e79@linux.microsoft.com> References: <20241115-converge-secs-to-jiffies-v2-0-911fb7595e79@linux.microsoft.com> <20241115-converge-secs-to-jiffies-v2-1-911fb7595e79@linux.microsoft.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="Sig_/gpyLfQXA_rG=N5QDCu3kL6w"; protocol="application/pgp-signature"; micalg=pgp-sha256 X-Rspamd-Server: rspam10 X-Stat-Signature: rbcaj45anbwmkmxde6s96sgru4r7nbex X-Rspamd-Queue-Id: 7DF92C0009 X-Rspam-User: X-HE-Tag: 1731710095-719716 X-HE-Meta: U2FsdGVkX19gQ3KWK6ZiqV4v8XO3ar1yXWkXbPTMNKntdnLjkPQLMMaPaIFyaX0pOsT6a3wniNvlnRDsr4Fl3vdUIa8HR2agOY+R4dPzp0QbryZVL8YC101rZCkNRZUF1uglLmAZgY2ZVm9Ki1SeddJ/STB8pA+lz/0ii0r6JP/pjRn8PPi99v2k48esjzO2TJF3UaKA7SsIgb94QNpMNmf2KWY6aSmh6GoOVyopbhRQMQVJPKl9iJ6t0EtMVD8IVmcdxNiw0gC2aoLCxBiIG3H3DXaz3c7yb4sPeylVLyDEQlL62cLvkSpQrbQQtRDlsPN5dKCDGG9Z8c2GEJ2qOwmip/o0SfjGHXBzfrsUAoyx0FZViYmVWkILmbIsDBBHEmBuoCKtCYoG8Hj+yEbqmYGPYEB/tx6tbu43w9NCj+qsW+jik5WU3HJANFRzNCBMQv1mpYDZ7iPOyxKlu8wPpP1fAZtoTGLouIzSoz7ikBy01/ECxIDwi5Po4B3nRzT6S3WQtwWLwrP/wGD47NmAsP0XaUms0Sa5yL0z7F8jsmFSbZT4YI8dfZpvFLbuWxxZrRNJAFQSzKk7wv2paxO9iVeGH/Z7X3/e6Mq/JV+yvqjKTY+jokLhZReDELAhPI0RUtpjLr6ZWD9U+OV1OpYg0HmjRXiuFY2otB/9JGRTU/UuDtgeCtpk8VDmWK0SPTIhGOMLgwSrISNGO2DVs6bQpyHxjZFnFlMw+IepjWHcZR78AINSyNPyhR+5zRXrDC3kZC5RBCvPNHhCV3OJ00gadIFkMLZyus6T1xvpSv65LjNUQ7jN89XxLe3uW18PE12eO6YI2ZEdirxj0I3ut3JB2wg43tjfhmyO62uGze4L9lzrN7OSb5FmnhndA0fdzPaPMUR/g7NO9qvcnO8bpZtJH2BbF5P/U4wubZipB+EbwxiiXLRgME8umySiAszY2T1W/1IUH6jwzomhHd3Azt1 0JZdJTXh 03tekZn7yJm6kDdBiLsW0bZ1rqaOzm4dEzmTJRusjcS1WfAIRqi0UVrKK+bettg4eQ+C6cPY6LSD4/63l8+6s/SRUKvZ/WPBhEZF9ydlDu7+A75//VdGaQ4AsBam6lfvOJ8XHrfaP3HCRVl/r0A3rxB311gaA1i3uyeCA8hAK46egjurY7GezcRqiU4LqB4T3rzI+1dOexe8m9V3fdmLMNlJ4fbZV4W7d0hszPzp0YU+Qxn6R0IpwZ6au/bES8AsB5CS76sk4CTxIN9g7JP03YEB7rmSqQyo7TAuSvs2sWWXaV/m95eBBNQ59Uxm6VTsWxjlap6NkRQT+mZtAV2D+nOboBrQ+YNQlkePyE3KTnV7Z0S82rB2IzxU6I+uXjSbPohqbo1vHYd0FcDZYeSeaAgozdqTgqt7c1dOgXovpv98uMt0Q9r2J9MtTJme5iKZxbOdUlrkfltIHriUze2E/wkdSFw+cMSoGnohh64jDrvRtPts= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: --Sig_/gpyLfQXA_rG=N5QDCu3kL6w Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: quoted-printable Hi Easwar, On Fri, 15 Nov 2024 21:26:18 +0000 Easwar Hariharan wrote: > > static const unsigned int sctp_timeouts[SCTP_CONNTRACK_MAX] =3D { > - [SCTP_CONNTRACK_CLOSED] =3D 10 SECS, > - [SCTP_CONNTRACK_COOKIE_WAIT] =3D 3 SECS, > - [SCTP_CONNTRACK_COOKIE_ECHOED] =3D 3 SECS, > - [SCTP_CONNTRACK_ESTABLISHED] =3D 210 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_SENT] =3D 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_RECD] =3D 3 SECS, > - [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] =3D 3 SECS, > - [SCTP_CONNTRACK_HEARTBEAT_SENT] =3D 30 SECS, > + [SCTP_CONNTRACK_CLOSED] =3D secs_to_jiffies(10), > + [SCTP_CONNTRACK_COOKIE_WAIT] =3D secs_to_jiffies(3), > + [SCTP_CONNTRACK_COOKIE_ECHOED] =3D secs_to_jiffies(3), > + [SCTP_CONNTRACK_ESTABLISHED] =3D secs_to_jiffies(210), > + [SCTP_CONNTRACK_SHUTDOWN_SENT] =3D secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_RECD] =3D secs_to_jiffies(3), > + [SCTP_CONNTRACK_SHUTDOWN_ACK_SENT] =3D secs_to_jiffies(3), > + [SCTP_CONNTRACK_HEARTBEAT_SENT] =3D secs_to_jiffies(3), You have changed this last timeout from 30 seconds to 3 (presumably just a copy and paste error). --=20 Cheers, Stephen Rothwell --Sig_/gpyLfQXA_rG=N5QDCu3kL6w Content-Type: application/pgp-signature Content-Description: OpenPGP digital signature -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEENIC96giZ81tWdLgKAVBC80lX0GwFAmc3zJIACgkQAVBC80lX 0Gw+jggAlx/FpdCsBUGWHj/3D1FyMKcJOE8x+VIKqw9c10Hqa/DPZEAcUaXlmvJJ 1NS+WrDFLS34ZiI4SbtosexC7tobHh/TkpamqrN+fG8STjNbtTVLYQ8QiWT/NCDx IeMkpH/EiSg0ow+0U1XenGHORnkKPdtLr7lxlRq1R7ylUYNZK0eDlX4r2dwmOLYg r0lFld/TwA434BDqTqj8KzVt9p1k2QiHm+LUntdk7Xu/Rlami4y/+Bahn9gmN3ji wRFxXLzm6upqhGxP5RYNyz3FB0oQgUvILDpklyPzzLTZW+L+bPkhgY5RZTFXpk9k KeR+GZcOjbCNU/RaWT8zDXVC32LJaw== =DzpI -----END PGP SIGNATURE----- --Sig_/gpyLfQXA_rG=N5QDCu3kL6w--