From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49492D68BE6 for ; Sat, 16 Nov 2024 06:06:08 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 5CCAB9C001A; Sat, 16 Nov 2024 01:06:07 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 586799C0018; Sat, 16 Nov 2024 01:06:07 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 358A19C001A; Sat, 16 Nov 2024 01:06:07 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 12F4C9C0018 for ; Sat, 16 Nov 2024 01:06:07 -0500 (EST) Received: from smtpin16.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 71D6C1A12E9 for ; Sat, 16 Nov 2024 06:06:06 +0000 (UTC) X-FDA: 82790921808.16.AF53DF0 Received: from smtp.smtpout.orange.fr (smtp-18.smtpout.orange.fr [80.12.242.18]) by imf09.hostedemail.com (Postfix) with ESMTP id 7E884140003 for ; Sat, 16 Nov 2024 06:05:32 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=mL98MjzV; spf=pass (imf09.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.18 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr; dmarc=pass (policy=quarantine) header.from=wanadoo.fr ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731736967; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=1GOO379j5kHelQgT13xeDCIW+pFPJCeiM7WSIuvag78=; b=k3C7Fx1iOeH7euNiCmCdcnWIE0tZE/nXIEdb2YPeYVmvJVoRvyyZZSt/RAmutpzCndV9Gv qP5W+5Ia3ZMfgIeTAzbpCE/Z9cXt05/d+ZpzPs227TsQI0OkOiuAb8MQyLaWfe2uyzthF3 0bW4U5eJ0k8AnZ7xbibtt+enrzWduvI= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=pass header.d=wanadoo.fr header.s=t20230301 header.b=mL98MjzV; spf=pass (imf09.hostedemail.com: domain of christophe.jaillet@wanadoo.fr designates 80.12.242.18 as permitted sender) smtp.mailfrom=christophe.jaillet@wanadoo.fr; dmarc=pass (policy=quarantine) header.from=wanadoo.fr ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731736967; a=rsa-sha256; cv=none; b=o32JojyJ5JemlSQzpfc0+LukOltJOdAFY61UqVBzpTkGBrIqcB24lmLJyGu2IbbYy2dtvD fG/OtFYOfYvsmRNqPB9+wZWNyRkWGTIkfN7Rm+CeIG/4RQsbxTGNTP7gh60SCLzMoWLiYe owo7YYl8r2ULYntR8xni9xO6uvlwcEM= Received: from localhost.localdomain ([90.11.132.44]) by smtp.orange.fr with ESMTPA id CBwItlkEVyQmhCBwItrt0n; Sat, 16 Nov 2024 07:06:02 +0100 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=wanadoo.fr; s=t20230301; t=1731737162; bh=1GOO379j5kHelQgT13xeDCIW+pFPJCeiM7WSIuvag78=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=mL98MjzVZSShtzisX9zbjDjIb7KE72buAzIx9jorkgCEIlxacBGBiKDqnznYupede vEhaEvssP8Otw+abSwd4UipThVl5qw3v6w8RixuAXgrl/p9FBRiYmldRfZZljgK0OD FX0UB9px2S9OjhfpAHnQggpK1elWNH8UBNVIvO5x+AsAiYtyf4oGwInz8jFtqh7DDu OMNwG4GURPpChqfcVzLVhpacwz+NEqWf9xIvmwF/gxmCGy7nRrRkaf4TeGrlu6c0Ll o9NHONgP90fIf7c6ZsyFFLJ/v2i9NFywx5+jxHfxBiA3eBfpU5DKAu5obNXbrUQywu rI95zY+eQlUcg== X-ME-Helo: localhost.localdomain X-ME-Auth: Y2hyaXN0b3BoZS5qYWlsbGV0QHdhbmFkb28uZnI= X-ME-Date: Sat, 16 Nov 2024 07:06:02 +0100 X-ME-IP: 90.11.132.44 From: Christophe JAILLET To: eahariha@linux.microsoft.com Cc: James.Bottomley@HansenPartnership.com, Julia.Lawall@inria.fr, agordeev@linux.ibm.com, airlied@gmail.com, akpm@linux-foundation.org, andrew+netdev@lunn.ch, anna-maria@linutronix.de, ath11k@lists.infradead.org, axboe@kernel.dk, bcm-kernel-feedback-list@broadcom.com, borntraeger@linux.ibm.com, catalin.marinas@arm.com, ceph-devel@vger.kernel.org, christian.gmeiner@gmail.com, christophe.leroy@csgroup.eu, cocci@inria.fr, coreteam@netfilter.org, daniel@zonque.org, davem@davemloft.net, dick.kennedy@broadcom.com, dri-devel@lists.freedesktop.org, edumazet@google.com, etnaviv@lists.freedesktop.org, florian.fainelli@broadcom.com, gor@linux.ibm.com, gregkh@linuxfoundation.org, haojian.zhuang@gmail.com, hca@linux.ibm.com, horms@kernel.org, idryomov@gmail.com, intel-xe@lists.freedesktop.org, james.smart@broadcom.com, jeroendb@google.com, jikos@kernel.org, jinpu.wang@cloud.ionos.com, jjohnson@kernel.org, joe.lawrence@redhat.com, johan.hedberg@gmail.com, jpoimboe@kernel.org, kadlec@netfilter.org, kuba@kernel.org, kvalo@kernel.org, l.stach@pengutronix.de, linux+etnaviv@armlinux.org.uk, linux-arm-kernel@lists.infradead.org, linux-block@vger.kernel.org, linux-bluetooth@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-rpi-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-scsi@vger.kernel.org, linux-sound@vger.kernel.org, linux-staging@lists.linux.dev, linux-wireless@vger.kernel.org, linux@armlinux.org.uk, linuxppc-dev@lists.ozlabs.org, live-patching@vger.kernel.org, louis.peens@corigine.com, lucas.demarchi@intel.com, luiz.dentz@gmail.com, maarten.lankhorst@linux.intel.com, maddy@linux.ibm.com, marcel@holtmann.org, martin.petersen@oracle.com, mbenes@suse.cz, mpe@ellerman.id.au, mripard@kernel.org, naveen@kernel.org, netdev@vger.kernel.org, netfilter-devel@vger.kernel.org, nicolas.palix@imag.fr, npiggin@gmail.com, obitton@habana.ai, ogabbay@kernel.org, oss-drivers@corigine.com, pabeni@redhat.com, pablo@netfilter.org, perex@perex.cz, pkaligineedi@google.com, pmladek@suse.com, rjui@broadcom.com, robert.jarzmik@free.fr, rodrigo.vivi@intel.com, roger.pau@citrix.com, sbranden@broadcom.com, shailend@google.com, simona@ffwll.ch, svens@linux.ibm.com, thomas.hellstrom@linux.intel.com, tiwai@suse.com, tzimmermann@suse.de, xen-devel@lists.xenproject.org, xiubli@redhat.com Subject: Re: [PATCH v2 02/21] coccinelle: misc: Add secs_to_jiffies script Date: Sat, 16 Nov 2024 07:05:40 +0100 Message-ID: <20241116060541.5798-1-christophe.jaillet@wanadoo.fr> X-Mailer: git-send-email 2.47.0 In-Reply-To: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> References: <20241115-converge-secs-to-jiffies-v2-2-911fb7595e79@linux.microsoft.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7E884140003 X-Stat-Signature: mw3mbmiihuiqqx6btrqy8usoewkrud1t X-Rspam-User: X-HE-Tag: 1731737132-185275 X-HE-Meta: U2FsdGVkX1/cAQXyP4l4TOy87QhxSi96pgNscZTl2bxEhiGJ/zZaB3K5DVKovMIgwIKwZB2OqOKbb8YJKfLQVRv6uWvs/UFXVCEup1rYyMMaID7OGTTW/hRAbj3cbIVSgb75H99Md1NXpLN9PAIf6hSI0fe073XgRL+2NLHiBQ6V/46+p0/WelGeyYEa6XFDZBdhJ3rjQKxLHc2X4vJvbDlUrWwXKv58D1NAM41+h+1oNxQcHMGNrNuhcSlUXj4Cc54+02SDEyNX7R2PRS7LvT0yqZ14YCOk7bY0DlOoT2n18sYwbE4BR0magt2ru+sWx/3peDl+sdqAAYG+Y2Cxea0jCtYYtTtXU5dpCsl8vHLGhLAACG/wg590fCpOvMmYv5URjM8UKAmJVAT7uecnsU2ArLlwtLfBwt2evaOkpqVgypTkYlFlehR+OGeBa6tk8Izd29fzBIYRE52C/npWHUIG0+3zqfXatS52hOHdNp+NVmYBBjv722/Fyl8nfTQY04jNZZ2uDC1Wnd7srN3IDiWPDHeLVNBnND85Gg23RcmsERyvxpenTMDfyVeEGbLPppY+H6ufzEePPx0epcBWtQHzHg8cRkmg0cCpsmpYszYnhrAi/RTeQyWc0gPbcPsVIE7MmLO0eeIObH77pmyN3oXuM8c8qONhe13MjHtYTeSDhi3q2pAIdvOLlwYHeA17QFVcqgl+DTmC60e16dIMFg5qr//wysuoWQzEJpBdOndTw0KU2FjKXcX/wLyI4ufVqLktjKGNNlS1uR0+mjSrBWvSSoz4gJ3+w7zOLnYKdJN4FCAc1JbLloMr0Pu3DV6GAFnqujZQcgkw9bV7m4vF1WPv8oJM1Zb8AW4vOMW54H0SWLjsifSHfNF4yjTsZzLjSpxq6Qx9iV+Cf0JD6/dbzgnLAqDxrXfBxIi/9fdIBPx041EQhqKkUCGm60ieIMXIhS9JGHw4T7gGn3QZZec cMF6qZPG 0E6SjvtF1W8deNz/FYlMtE9jN073NgPln9unEBnmCkKOR+8G3aaffaRkRNJMNg6bCjz5rTSNWltih1niaUQpQCbnFbPjdh9LhI2zk2s669RP3grN0XWT6BFOS12D1iCC8pEWUMGgBsFGVzO7YRnvVxBo84sngymbzCrYfYJir4jvsJlTppn9UcVh+zyiSBZmfvF43toh1Nw2xbcm7B2urfBNzKT/5Sm3FJLD4p6UJC8wIRibqWD0IfqrgeLdg8Ea3DMegYfrX1h1KBkfXo5GtSBsApxRlimkfGuE7HDcrs8KFjUM5fCKGinOu8AB6uakhel2kXplWvlZyzu8aPipc9ibQ6yrBrS0+UwjUyzxztXgh1yjYjq+7PKZ0XPZZD8ySV4+XRn3oUftsC80bYWFMtQ1mMjX7QjpK+EQXQ2MGsubPcs2ep21AU0Tb14jtXzkWgkS0Nq3pMAFa5Jz81YsAGJY5WQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.237422, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Le 15/11/2024 à 22:26, Easwar Hariharan a écrit : > Suggested-by: Anna-Maria Behnsen > Signed-off-by: Easwar Hariharan > --- > scripts/coccinelle/misc/secs_to_jiffies.cocci | 21 +++++++++++++++++++++ > 1 file changed, 21 insertions(+) > > diff --git a/scripts/coccinelle/misc/secs_to_jiffies.cocci b/scripts/coccinelle/misc/secs_to_jiffies.cocci > new file mode 100644 > index 0000000000000000000000000000000000000000..af762b1c0aac8f044f21150bfaafd9efc834ee87 > --- /dev/null > +++ b/scripts/coccinelle/misc/secs_to_jiffies.cocci > @@ -0,0 +1,21 @@ > +// SPDX-License-Identifier: GPL-2.0-only > +/// > +/// Find usages of: > +/// - msecs_to_jiffies(value*1000) > +/// - msecs_to_jiffies(value*MSEC_PER_SEC) > +/// > +// Confidence: High > +// Copyright: (C) 2024 Easwar Hariharan Microsoft > +// > +// Keywords: secs, seconds, jiffies > +// > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * 1000) > ++ secs_to_jiffies(C) > + > +@@ constant C; @@ > + > +- msecs_to_jiffies(C * MSEC_PER_SEC) > ++ secs_to_jiffies(C) > Hi, @@ constant C =~ "000"; @@ * msecs_to_jiffies(C) also spots things like msecs_to_jiffies(1000) I'm not sure that coccinelle is enable to capture part of the regex to automate the removal of the 000 when converting from ms to s. Just my 2c, CJ