From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CA72D6DDD7 for ; Fri, 15 Nov 2024 07:14:53 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 8C8626B007B; Fri, 15 Nov 2024 02:14:52 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 878B46B0082; Fri, 15 Nov 2024 02:14:52 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 73FF66B0083; Fri, 15 Nov 2024 02:14:52 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 56FE96B007B for ; Fri, 15 Nov 2024 02:14:52 -0500 (EST) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id CB5471613B6 for ; Fri, 15 Nov 2024 07:14:51 +0000 (UTC) X-FDA: 82787465460.06.2A480FF Received: from mail-lj1-f178.google.com (mail-lj1-f178.google.com [209.85.208.178]) by imf10.hostedemail.com (Postfix) with ESMTP id D604CC0008 for ; Fri, 15 Nov 2024 07:14:29 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iaJEK+Js; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731654758; a=rsa-sha256; cv=none; b=PtMpM3ivJqwkZGEXRKQB/avc1n9ub101/uUb0WfIInmtbXDozaK275umFC6g1kUi0wGAZt jZq0NaXy4rZqwJSdwAKFllMWXnueYeDOaUducbGxIV1CrRCbQR+b+hkBm1mHO4ygDTSP1C bFBjVQQEgHJDQSQif2wEZE7Wo+n4HwE= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=iaJEK+Js; dmarc=pass (policy=none) header.from=gmail.com; spf=pass (imf10.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.178 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731654758; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tCSZIfVvAxQDL7aS8fPTwPSS4kT4m6f2HO16FJ19sd8=; b=7eXkHbPFuEDko8e5xYjsqlbXHWdLAjrf5KxD2LIeK4Orzw2XV0pxmKS0ftxB55hpmwiW5I JSN8iNhvX2k7m1JphYCg1GYpq2qePc2/Ca/xMmQXdYpBbE2icszU9gp7gKpXoE4WsA7P8Y aHt2hyfmwCio8D16toY2uBXH1dOPMSc= Received: by mail-lj1-f178.google.com with SMTP id 38308e7fff4ca-2fb6110c8faso13661991fa.1 for ; Thu, 14 Nov 2024 23:14:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731654887; x=1732259687; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=tCSZIfVvAxQDL7aS8fPTwPSS4kT4m6f2HO16FJ19sd8=; b=iaJEK+JslwFAdVPpKCG+98ovUDei/c5+YOAsezZtkjKoN+iLuFaQnUVE00EETexWCn oJSzQEUEFjuCpAVMqIx8nzasIs6XKMSAkGjdGdbGFVjx03wkXjw4jKToVmkpnlUBsXtt zlTaamI+oJg8kn0dTLxz7VXEwfsxTCALliJ2cj5/8HFUqO4OHNkBr9E6SMhTBGt9dGdI 2IgT1/ebcHevl+7Mv/Dxj0BlKa8K9dzub8/I+YLDyMO1tF2X0Td/10+4e5aQRnQcM13R d855x+Dr71KLXWaLVxuv2VdOygDKZmHJatfEF5nn1PIL67FPsPnjx/slV+Y1B8/mO1xI GkGg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731654887; x=1732259687; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:cc:to:from:date:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=tCSZIfVvAxQDL7aS8fPTwPSS4kT4m6f2HO16FJ19sd8=; b=pdzbqFbSZJ0WlinmrkLylGT+UM8JESYM3oxrPhWo1EtEoGsZ6bFauV7ZzgBbKznaV+ b5nUcQ0EVNJhWwVEgJ55jfGys5v/LkuJ0MWZbL6yyrQysxiwrXYiS0wTfnJ85eJu8aEf CAfYd3kDe3u5eN3S41C1v0JBc/MYbFrh0RHYFI0440xXl2MO1OiDBOPUCMmE6+RdCmBj oyF5nQbV+CPnwLV3dkXuw5oM1OjWQ0e6JU/QRgAk5tkGe77kIXmzkaad2CCTTZ0dTRCE DWtl3vE1Q4ZahmblrAVB48MLbivieHIbybpnWT3S46Rg3V8VF7VBpLgspfb7ehwFYVs4 UJTw== X-Forwarded-Encrypted: i=1; AJvYcCVdXBtJn9Wusx9KEZNpqIIw31YPjXh/WUjsuX7yYtsMGtPUywU75bkSkKk2ZgdgrtbXSrRS0XYYCQ==@kvack.org X-Gm-Message-State: AOJu0YxqjYKh0NTO4o0F1/pahUfDUUoKA/34W/CQCqIfnyqG675DJn0G 7l5fTJvnNnNjuegKBJuqWGjEBVNUC0DhbaGA19HJZeLBzxvlb4Lx X-Google-Smtp-Source: AGHT+IEYJTJZ4AkQd5RAXoCoFivbsntQ05lv6Qvna/InPjCupFHDdTCMv2LD0kHb7L/icWDC/cOUkw== X-Received: by 2002:a05:651c:511:b0:2fb:55f0:2f7b with SMTP id 38308e7fff4ca-2ff609bdf12mr7040201fa.35.1731654886705; Thu, 14 Nov 2024 23:14:46 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf79b9e168sm1362002a12.21.2024.11.14.23.14.44 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Thu, 14 Nov 2024 23:14:44 -0800 (PST) Date: Fri, 15 Nov 2024 07:14:44 +0000 From: Wei Yang To: Sidhartha Kumar Cc: linux-kernel@vger.kernel.org, maple-tree@lists.infradead.org, linux-mm@kvack.org, akpm@linux-foundation.org, liam.howlett@oracle.com Subject: Re: [PATCH 4/5] maple_tree: break on convergence in mas_spanning_rebalance() Message-ID: <20241115071444.o5iwkvwpur2lmcnt@master> Reply-To: Wei Yang References: <20241114170524.64391-1-sidhartha.kumar@oracle.com> <20241114170524.64391-5-sidhartha.kumar@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241114170524.64391-5-sidhartha.kumar@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Queue-Id: D604CC0008 X-Stat-Signature: qm1h45mf5yn57xp35yk5tokqitcps64j X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731654869-348392 X-HE-Meta: U2FsdGVkX1/Xrlv4rwb0uDS+/ZCEHlLrVBkT9xG+B2BERKYEfjIpEEjMXabMJp7BowEYtQMqdFJWtBtJjaT+HYD6MYTk4wlMurV7RFMm99CUHkBh0+wdjcMdVv66KZTCk43JexgRqhjjoOKv0hBTSDL6zGhMLbeamRnFBIA3L0UYX79hZtKQkT6d4JphcBb2OIfZpEEkiNYYvRJPHZ82S5aCQ8PkcH4dMtVubY3LTVg0LMIGT1ICeXyIudt+gkE4MwNaYRiL2dXf0GQfP/Dsr3bdRGxC1djVwMG6UsC36t7AUW0Rf2IgsYUVpbEXYFjxrB9Seu9SdSRPiPzMrCCPIu0orOB5zAYtimhc7J6fCh6OLc4kqRokSRvhdaM8oyao3hbEzZVpu5Pcvt5zIRCxyH+lMjDt7oTUj9EnPjN6km1hd7PhpL9QARr/wQoV9lhr8fkhGQ75GH6MvNmx7dU5vMkOhSmrzDSYsEE5D/nNbogXW4YYOqHIKzpmIdmMm/t5QpRHQ+uvRag0L0bJBN/MIxw493InS+E1xzsK7f0jg0HIuHQl9KpOZjw9NHqmq6wPZjgVJhUxyHntck8yQS7ESAwume0NqdB347Kvu5ulRqQ4D4kawM5sPjJJXyryQgHEc5c80a5/+vJUSgkqxreEqRTVxBEpr2pTaz7uyiy7i+5ZKTR6+rQDwlJB5hdNq4jEyRHiPtVLpgBqa31S3DkTSYmHyiOTZdOo8IsotAbSvQD/+4NrBT/MxO+ZGX/p7BsufZOMyVWF+FaMrbzvMa7uZbqIYuTkpFVy5zmkjcSayQRD+ESARD8x3o1Rq/nRYURf6sM1yB/8y6SCjEASRsVV6NRHSZaVozGNV7HcO+zcUepaUGxPZpwbZtefrvsS0qJquL6GI6oMv1YsOIt837s0JQ72uQ8Gm7relHqxd8B/jFGP6XiLqfZqYJdAoMAMlNUcJZ/YPW/rOb4nxVGg2oe khfBXdCf Q4iYezCKP0hYxrIwpjks2Hi1NaLLCx0d7oj020U+w7fsqgOpvq68CsP2J8VyTWP2OLIe2HIbliWEAkm8Ao3GSynx9gHxpCrbzzPI1fu7C8RDKuU8yQEc9HOhEonL+mVlUTFM+AgFTAaHgnVv6+/jXTnGCDzbToVq0LQ1P3kb4aVEbTGvIKRFjAJejHdH9cZdGTp5mNnsDfPtBBdmlkQIVIHtTLrjxI6xcoYZbe2zfIjvm69keKK0Or3EcROTYyk/S7UKthTiNjrqm+Z67W0mmDqSePmZaiOJvs/a4hWxbxsDr78SrRld2Te5e+SwVScmJuPAoxPZLSsOpDWk2DjU6ZHDeBGTRgr2/n5E+Gko/KQRlsmtE5kpbqo7KHmxC9lWxhAiHTFADbiBpilfungl37oLr+arz9VPKrJXcyzstOGGOwDp2hDOmlbT3ndIgYc69HSViLQK23Eaw18BtWdIXHH4sQ27YxYFLY5fJh0tt4U/dC06lY36blMp4h9POnOZ5X4V3KTgCv9FpZAaAex+rkosaqgp0D36UHZ0Qehe951U/G14uG5gE8JidHmfCEkW/mCoa3xlkZTUr6hLjSJ/RBAHwC7huYwdim7/gJRWx5P8kayxG/d9l3kE/LmEOsvu+3UhX7yxCi0bsg4M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000264, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 14, 2024 at 12:05:23PM -0500, Sidhartha Kumar wrote: >This allows support for using the vacant height to calculate the worst >case number of nodes needed for wr_rebalance operation. >mas_spanning_rebalance() was seen to perform unnecessary node allocations. >We can reduce allocations by breaking early during the rebalancing loop >once we realize that we have ascended to a common ancestor. > >Suggested-by: Liam Howlett >Signed-off-by: Sidhartha Kumar I am just about to send a similar patch :-) Reviewed-by: Wei Yang -- Wei Yang Help you, Help me