From: Harshvardhan Jha <harshvardhan.j.jha@oracle.com>
To: akpm@linux-foundation.org
Cc: harshvardhan.j.jha@oracle.com, linux-mm@kvack.org,
stable@vger.kernel.org
Subject: [PATCH 5.4.y 1/4] mm: clarify a confusing comment for remap_pfn_range()
Date: Thu, 14 Nov 2024 07:34:40 -0800 [thread overview]
Message-ID: <20241114153443.505015-2-harshvardhan.j.jha@oracle.com> (raw)
In-Reply-To: <20241114153443.505015-1-harshvardhan.j.jha@oracle.com>
From: WANG Wenhu <wenhu.wang@vivo.com>
commit 86a76331d94c4cfa72fe1831dbe4b492f66fdb81 upstream
It really made me scratch my head. Replace the comment with an accurate
and consistent description.
The parameter pfn actually refers to the page frame number which is
right-shifted by PAGE_SHIFT from the physical address.
Signed-off-by: WANG Wenhu <wenhu.wang@vivo.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Reviewed-by: Andrew Morton <akpm@linux-foundation.org>
Link: http://lkml.kernel.org/r/20200310073955.43415-1-wenhu.wang@vivo.com
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>
(cherry picked from commit 86a76331d94c4cfa72fe1831dbe4b492f66fdb81)
Signed-off-by: Harshvardhan Jha <harshvardhan.j.jha@oracle.com>
---
mm/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/memory.c b/mm/memory.c
index f8d76c66311df..238064ef73ae8 100644
--- a/mm/memory.c
+++ b/mm/memory.c
@@ -1921,7 +1921,7 @@ static inline int remap_p4d_range(struct mm_struct *mm, pgd_t *pgd,
* remap_pfn_range - remap kernel memory to userspace
* @vma: user vma to map to
* @addr: target user address to start at
- * @pfn: physical address of kernel memory
+ * @pfn: page frame number of kernel physical memory address
* @size: size of map area
* @prot: page protection flags for this mapping
*
--
2.46.0
next prev parent reply other threads:[~2024-11-14 15:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-14 15:34 [PATCH 5.4.y 0/4] Backport fix of CVE-2024-47674 to 5.10 Harshvardhan Jha
2024-11-14 15:34 ` Harshvardhan Jha [this message]
2024-11-14 15:34 ` [PATCH 5.4.y 2/4] mm: fix ambiguous comments for better code readability Harshvardhan Jha
2024-11-14 15:34 ` [PATCH 5.4.y 3/4] mm/memory.c: make remap_pfn_range() reject unaligned addr Harshvardhan Jha
2024-11-14 15:34 ` [PATCH 5.4.y 4/4] mm: add remap_pfn_range_notrack Harshvardhan Jha
2024-11-14 15:51 ` [PATCH 5.4.y 0/4] Backport fix of CVE-2024-47674 to 5.10 Harshvardhan Jha
2024-11-15 5:27 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241114153443.505015-2-harshvardhan.j.jha@oracle.com \
--to=harshvardhan.j.jha@oracle.com \
--cc=akpm@linux-foundation.org \
--cc=linux-mm@kvack.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox