From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 49B4BD41C3A for ; Thu, 14 Nov 2024 05:11:56 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9481D6B0083; Thu, 14 Nov 2024 00:11:55 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 8F8616B0085; Thu, 14 Nov 2024 00:11:55 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7BFEE6B0088; Thu, 14 Nov 2024 00:11:55 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 5ECB26B0083 for ; Thu, 14 Nov 2024 00:11:55 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay07.hostedemail.com (Postfix) with ESMTP id C5AA0160161 for ; Thu, 14 Nov 2024 05:11:54 +0000 (UTC) X-FDA: 82783526154.09.E6153B8 Received: from mail-vk1-f177.google.com (mail-vk1-f177.google.com [209.85.221.177]) by imf29.hostedemail.com (Postfix) with ESMTP id 959921202A3 for ; Thu, 14 Nov 2024 05:10:53 +0000 (UTC) Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=XljkAbGQ; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731561049; a=rsa-sha256; cv=none; b=BqF1eFBAg3RT6hFPDQqRqLWla8NTpDW7/EL9vV7dGp7IhkO1KvcnQn/NFbEKj6F0LVELgx h5UBUBXOzjn3jM6MolIC5F+8MMzj6uPoJOnbenX8h2EKlnJBi8Nmm0XL2gAl9yQibZ9l8W GwElNF2V7E9kKf66wtHXthIE5oFXUGU= ARC-Authentication-Results: i=1; imf29.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=XljkAbGQ; dmarc=pass (policy=none) header.from=cmpxchg.org; spf=pass (imf29.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.221.177 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731561049; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=c3dcKoL4WLruIcooV2HPhh0m8G1xsVHw+IHF3MibMAg=; b=5XnMeLEZtRvW4++pyfQyq9fkJ0HUIPPk7KSwuipEirRUfjOtdkKZxBozEZrPFNQGk2WGBt N7X+DCqEskfRbRhu5aUk+dfdS4x4kzhne75qt3Rqo1WJcSRkykO5aInPgJ+S96flGB/p00 I0aQNNTNgVvZqHxeethMz+ytusY8+cs= Received: by mail-vk1-f177.google.com with SMTP id 71dfb90a1353d-512259c860eso115789e0c.2 for ; Wed, 13 Nov 2024 21:11:52 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1731561111; x=1732165911; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=c3dcKoL4WLruIcooV2HPhh0m8G1xsVHw+IHF3MibMAg=; b=XljkAbGQ2l7jh+MZoSsViiS/h5rq5QF9ftOnNE0/U+dEYdeWEhe+8rsdHncdBZ0lIn erVImI29r15L+TyvsNzSXc9xtIlC7r8vrpsYMx0W1lMUq50ql00o1XRvbQloA2YlwwAC 8NsezdyyDAMKvXL0nt+4XkORSuN92O/6E3UetNqH9G6t1DgE1793hJNN6V7mFjL1+SOh KDDJqAoxoJLmIED8cjpR9g+wdo5rbnpD3HiYgQ6Qb8DAHiy0maPieLoxy7DrtlHpxGe6 tN1WMYVuTLr9U3oxnAUxWJsmrC7IX1c1RYlhcCE2suoFI8SVcfd+VFVMEeAwxhG9CixN tjVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731561111; x=1732165911; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=c3dcKoL4WLruIcooV2HPhh0m8G1xsVHw+IHF3MibMAg=; b=I3TasCTZBwgujNNfkiiBF7NIXMuXP3t3AWIWnwo472x8wwttNnFii3mEfO/wcBwVRq QJkJ2zdHm3OmPJQvD8mfILXBf7PCIbdh3PBRWnY7IdQn7fLbQOektmYoG3YOnjAFZUOu DZ275qjIsycf4U9Aq6IOVW2cRdJzPY5mrewrKN1SM/ez1SQECH43cM0+zkrrFG2xDLCv MuGG8bzgiZajRRptP8sHfTLOmnNLGQwOKxdiuBxBE+7cfKICDF0+G4bVLBbHAWgDppEN ovnSdOV1shzD2qm0LzXCtJdrqAtxGcbAk0wSTTc1FL8HUUoKzdoNHv+6NgzEvUlIX6ln mL5A== X-Forwarded-Encrypted: i=1; AJvYcCWP6JFFdg5Yqh5Wc1a7+SkQVDcSGISX9HowNV0FbXNiazc/cAXeyN10cNKe4nbXoLpsKss0kl2KyA==@kvack.org X-Gm-Message-State: AOJu0YzHx8/j3M2UsURIt4RlfJpiah3+GzD55l9PNK167bwSBy/ddday U6MUeCQMZP4N9oae9HZzQFLrOybUMQhv1DPil/Pf9fhKS176p6/v7EvevUthPF0= X-Google-Smtp-Source: AGHT+IFZ4DfAibLftq1VV4x/hGd1Ryn4sDGwR8BGeWjB+nopbPLzJbUpHSkdTXZpWmAsl6A62+QQpQ== X-Received: by 2002:a05:6122:1797:b0:50f:fe39:a508 with SMTP id 71dfb90a1353d-51454328779mr6314099e0c.11.1731561111549; Wed, 13 Nov 2024 21:11:51 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4635a9e9824sm1505441cf.26.2024.11.13.21.11.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 13 Nov 2024 21:11:50 -0800 (PST) Date: Thu, 14 Nov 2024 00:11:49 -0500 From: Johannes Weiner To: "Sridhar, Kanchana P" Cc: Nhat Pham , Yosry Ahmed , "linux-kernel@vger.kernel.org" , "linux-mm@kvack.org" , "chengming.zhou@linux.dev" , "usamaarif642@gmail.com" , "ryan.roberts@arm.com" , "Huang, Ying" , "21cnbao@gmail.com" <21cnbao@gmail.com>, "akpm@linux-foundation.org" , "Feghali, Wajdi K" , "Gopal, Vinodh" Subject: Re: [PATCH v1] mm: zswap: Fix a potential memory leak in zswap_decompress(). Message-ID: <20241114051149.GC1564047@cmpxchg.org> References: <20241113052413.157039-1-kanchana.p.sridhar@intel.com> <20241113213007.GB1564047@cmpxchg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspam-User: X-Rspamd-Queue-Id: 959921202A3 X-Rspamd-Server: rspam11 X-Stat-Signature: ssh7uas631i5wsawn6w3o43fr5b6j895 X-HE-Tag: 1731561053-282245 X-HE-Meta: U2FsdGVkX19IeqpdHmBPbC51Xa6wK8G9JI0L79FfUGcnIA1VI/y/lF2qOWnEj3gPa5i40fXCrDAQn7MqO7MK2I/JkkKka2tusLjY4nT80qnHPBaL0ZhPZ6XS2k4QbZJEoADP2qolxUbBsXFZwinMGsE+XdgL2N0GAglGGEY7ikoFQhkHjhC6bfJEPXYpRmk606qqEKLHiAcWsN2VINR7fQJNl2bUxPO8dEpFP2ngNvOVniqOfL4pbqIzz47IDh5eCD08TkemjwP1I0ce0dLW6TBRHOWZEULw27LVO9flfw5giixiMxcyompdNyuvJqjzgAfdZvwiwZdjP54Ybukuq9IaGJShavta1EqkeXBQI8K4RSDnKmX5xUbh/8ureOIGJOfrA8gdC17aEvtoh8ZTpCNwPM1xpraIA7eytUkTEAwE2zubfQSBcOPx2KyCsxrniuK4EaNJ/jJdgJm4t1kgvtzM0UQfEBeMnVhlM2TvQVI02PWSeR/A1PHKKNFvHzp49bUSa0n+o14LiGHP51xUaH5wH2yMunxy7J2QRfsND1yBDhTowWllg8mHpz1tFUCyMBaOiTFEelA2GdzJirD+7ZgRJ12hSfdY5UCfpQfZDgX5x6DG9XNb/2ICLT3DvGgKYs/HpgNlhlaU9F9X0t3N2G00aI0mxkCICT+IbWq9TU0RBIEFCZ4Cf/FVFN+tTbbNyFH3n5XBzZTve2sZdA3Ac/m8CVltqYK7L4DG6Uo91XyadbAsSHxjVho8ibY2iLAxeuF34eL85/wuCXh2mPcmzdB1LhKiQboha1Ge0amaSFnWID0Oczpy7o7aAQ1De+7bmjpIujcvLBdb336bgCe7acI6nQTnDtU7KKDNfXR9xfJ5KHETRYtd7lYauxJPvHk0DjE/g/jTV1zzH4rlrkxbURTg8c/3vfSl4V52S10aNRDDszWbeyLFC6FoadHzk6BXcrAAM2dHtNgngOYYd0w ECGpxBL/ bwBrDfc7bWERW2O1M1G/Gq9hhOcOHuwYQiMImKhP4xpZXmMeUd09WnYbmJlkRuEiMqTM2FY2asRALvXr1dMYKa70MPmx2aDh++HusD3Yggmw3mYii/61glPTNp5Z+E+MKF9JR1eBGlpAsYuhDKNzP0OIHKpZ0/QgVVCQ5lTst0I04uRc6IpVlmb8sXwGntQxbNV24RU8r8yTV8AkP+7KD+2wx8QRx23YHFUzvUvg24q49qQKhsjQsK+bHQ03xT1S2GNAtYzG3ehQymBMpb+p8p0DjtgUnaRjaQO5R/V3GmpT5kRDqTMSnly6vHGubJZHwcGJ9OnlPS6NeAhvkm6onlm85JwIDJyQWrlsDMRA8yPHx5OEaRLuO/4RkJhnhB5x12P5EMUltvnDsckFP2Gl7LdgqUUfBVDLOAyQQghE7JMZ6autHAYvPjzLaD25QOdOe0i65qlxW8qMCmQm1CNVNUOcSwGbbEnriIFxpUiyD4DJX6Bw4mJaKnVA/DnfUfTCVxs6ZafWiZXRM9yzrYptdEEEXvkroo0XdlFgKNUXKwTFBxl4= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, Nov 14, 2024 at 01:56:16AM +0000, Sridhar, Kanchana P wrote: > So my question was, can we prevent the migration to a different cpu > by relinquishing the mutex lock after this conditional Holding the mutex doesn't prevent preemption/migration.