From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 17B2AD637D5 for ; Thu, 14 Nov 2024 00:53:28 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 87D496B0099; Wed, 13 Nov 2024 19:53:28 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 7DF3E6B009A; Wed, 13 Nov 2024 19:53:28 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 658A96B009B; Wed, 13 Nov 2024 19:53:28 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id 43F946B0099 for ; Wed, 13 Nov 2024 19:53:28 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id DFAF5140782 for ; Thu, 14 Nov 2024 00:53:27 +0000 (UTC) X-FDA: 82782874860.09.AA9FE16 Received: from mail-ed1-f54.google.com (mail-ed1-f54.google.com [209.85.208.54]) by imf11.hostedemail.com (Postfix) with ESMTP id ED1474000C for ; Thu, 14 Nov 2024 00:52:31 +0000 (UTC) Authentication-Results: imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H6EkBC8i; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731545411; h=from:from:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=EOSxIVh8suzOr8jnAUPSC6DJ3ZdDSMh1y4IcjsvlsBo=; b=pRsp/BvAglGXIawPaOx1YW/fb2hWNbfSs4OlJzr6j/DZljW2FEsBuAxiNoW88N43vwkHW8 Z8S9C9VslfcvdxAUH6Nl62Oj7PVU9iOsKUUwtKLOYFmWZOTA2C1KTsZitfmGk1xpCp9Ow2 8Jilv+nYJbnKAkRVNjIYRl6lkRKRcNs= ARC-Authentication-Results: i=1; imf11.hostedemail.com; dkim=pass header.d=gmail.com header.s=20230601 header.b=H6EkBC8i; spf=pass (imf11.hostedemail.com: domain of richard.weiyang@gmail.com designates 209.85.208.54 as permitted sender) smtp.mailfrom=richard.weiyang@gmail.com; dmarc=pass (policy=none) header.from=gmail.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731545411; a=rsa-sha256; cv=none; b=MVQab470bBjMZ7KM+sGd8BFnIHzcV83ytp0gsA8a1Zj3cTymHEVIy9W3tBIxp+vx3ec2oB 7jJuAOituBsPpr08mTr6o2oE0ykdI0cdawioMDBziBCqbL0SPNctlC10bIu1lj/1gWIFPU bviWPnDKxVLVCAZ0eTblSQMogif1eBQ= Received: by mail-ed1-f54.google.com with SMTP id 4fb4d7f45d1cf-5cece886771so61798a12.0 for ; Wed, 13 Nov 2024 16:53:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1731545604; x=1732150404; darn=kvack.org; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=EOSxIVh8suzOr8jnAUPSC6DJ3ZdDSMh1y4IcjsvlsBo=; b=H6EkBC8i/YPAJ2VUyropTFdBDVIRyWBbuQMnaSKZ/Cd07HCgge/RgSMgyPIMfhBukF SUFtHxUdF4GRVkU3Xp7UmuXlapUYVBNQgySnL4ao8Dx06I/a8Or8b0hFBLWyaIVY1Y0Q fAhbClHc5A0/6FS7uMsjVsu4fm7guUpLGzjhas1tRy1lVGmqyIZdCXtXT7rsCtYCGPsW l+8SwXIAdTRgAeYMXd9ueVtLevSqqukgbhi3xJLxKgsjyhUV4lKKY811ZeWCPkrnaR/S 6aU+ZQH/LtTTRcaaSqH9HT8rMOUN1e03UO3m36VvrxNkUSZ5MxLRMTtsMp3VQj/2NdeN YR+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731545604; x=1732150404; h=user-agent:in-reply-to:content-disposition:mime-version:references :reply-to:message-id:subject:to:from:date:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=EOSxIVh8suzOr8jnAUPSC6DJ3ZdDSMh1y4IcjsvlsBo=; b=P767SgFhb97axk4OrSLFTugVAZeLBkSc5tLmORlZ6+8l+MyvXy+bC1GKwNDEQ7jEy6 bys3DPdPA8g83FFZdiBUs+mcVRPF1TdmiDvBK+juXilG6s+vksAP4XfgoDZD5VgX85K3 uynEKMpoXs3g6I1mI1BkutHh+skCHab3HQcnaGB4eLBM945kl2D880kQ8EQ9/MyVaRns QJ02aKKdEaj+HGSKJ8yGsC0t7wXg06PbLx+mGvf4WcZXwOhKV+iNCCjONL27O4f5Eyvl 8UshDedK2dSY74H2AJ6FIxd+JMsrwl6vDwcMWUajfogpD3B/AxHqpqf33TIgyOKyP8Ie 9FIA== X-Forwarded-Encrypted: i=1; AJvYcCWbR00kNI+Kao2r/3Uabr46WPBwgkeh33E0oMjGeJReURNZeAvy/M7MVnU+eY6oqXJKfwgJIXvlnw==@kvack.org X-Gm-Message-State: AOJu0Yy8szhfC8ig3tc/ZvPHTym00OajrfzhqdQqveRHqMCBVaWy0TlV lVWnxQHddnPNjVyqpKZLPdthJ3IjywaquOa/rl09ILAL5M40mvx0 X-Google-Smtp-Source: AGHT+IHEu5tR9SHUvhg++pqrQE+ExcgQ0u3DI5VuCzbEvIK2K9lN6ZJGnUT0H4hxGdjwMXzKwaFm9g== X-Received: by 2002:a05:6402:358d:b0:5cf:7449:7a16 with SMTP id 4fb4d7f45d1cf-5cf754df826mr1367116a12.6.1731545604041; Wed, 13 Nov 2024 16:53:24 -0800 (PST) Received: from localhost ([185.92.221.13]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5cf03c4f0bdsm7713019a12.56.2024.11.13.16.53.21 (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Wed, 13 Nov 2024 16:53:22 -0800 (PST) Date: Thu, 14 Nov 2024 00:53:20 +0000 From: Wei Yang To: "Liam R. Howlett" , Wei Yang , akpm@linux-foundation.org, maple-tree@lists.infradead.org, linux-mm@kvack.org Subject: Re: [PATCH v3 0/3] simplify split calculation Message-ID: <20241114005320.dkjvvqw44hwxgbx5@master> Reply-To: Wei Yang References: <20241113031616.10530-1-richard.weiyang@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: ED1474000C X-Stat-Signature: hjw9yxkqieh5ajk8ccinbetu5y4akd41 X-Rspam-User: X-HE-Tag: 1731545551-629709 X-HE-Meta: U2FsdGVkX18Hkb5RjZEnjhzWEq9N0ll3qfqqY2iM1XxvbEwmA31s4umLk1LV9L8mL4icktLhJO0L9EX0WasYzlseqZdk9c/GQjT3RBZo3qo4rz3KA2Mf6tzPTxV38bp7qNAJuaTbHclyxdI+2HV79HaDYK7qpuZA8XFB6fl8hbjymbs9VHaQyIUihJJkTYJkGicDOhcESTf0fgV1PmXHEwPyYw5x/TIAT1B7A+9X9hwg9qsnkKrPf/eP5g3YEeNWOsAC33/SUaiuFbC+B5dh0G3Bf9Wfr73vh1rXWSijPsq0Dal8TGOg/bmlhADF9DoYaInZ8ln8+VNfqgb3QaFeWKVBWFFgWDZzDPnFONuAFjRGuVnvHOcwhEJmlT2Dk2FK6gT0SXew+/HFB+xhNI9pqBpLLI0Lf4FbsMmXIHfxxoksF/tDp7omcRHbJJGO7uKKhjNIFvGLCzH3UoyS1zMC4ro0vcvYmAkD1kYQhyigF4POGUlqKWI21xSRELIasDmZ3yGzhUPARIiQSpaP7DSKXw+3lzJYsG+DE2DaW/W7+du10+EW2iG8XQeCDsEEB2kQ2myqF8CEi8yRnWJy+Yp7roN0QV28FHMxm4zPhyQ7idDttmq0QVvcKFogCH8c4+Ho+DL0+SQQs6kjTFVBplTuARuuY3Zv84M35SrTzaDkekbndvyETRJ3v9gHE7xcY9/dUSUNYkVQ+A70xn7e0keIYMvbM6yQJPUNDdW1Ufn+vFM00il/v6oDvyDA7ELJDjZzD4Kcqucyz9bQMrs1AwKXAm2HFKBfcxLokZ6nI2hDzy5RbJN+qRiQBB+eUHQm0uFT/UbnrUculutgc5Pw1YTJSDP+Sm8+nWuuPggz6hRPtE61ucFI2IZn21fJiz6952L8g6zEFSHiZhRoULemHDvLJh2Mx/VtOsG8c+yybnU0vnB+MG2c3BRZ+LLXIZKA4mY9zPOTHtUEhFj+5CCzeAY wOhsjNzk Gvin/9TlW+tV7WqerKkCP7mx1QfiXQQnImqVPoOqqKK6jj2MMgj25QETcZTnSRM4d8TC+fEJbntdh+t3qLrgrRsIKb80j6HQhGtAtwB1ZeytaVIeUEG1pnB2Rlo3BSeNJX9fv1TvUX+Vr6zPxe3nUcWUEGlVCYZrkqYJtzL5HB0urbfUPKyHCu/6VDIUpS7Ac7kucV+f3Xh1d5I2P18QUt+fDn9LGRVkIaOjjrsjmtI8K5J8fn8sS/0/+QE867m+G65+b9FDS7zqKI7l3f2DTwYwaNvQCcSw1RgWGGU6YqGa0QMCh22t7zE/K2AF6FRTRYH4fEiMuooqlVGUeUHXfLAy2GXathd9ILqReCBKPKPh+YTQNWkUOU04IxPbE3xjGvjxT7ehWnQ3SG8ED18F7qGCZMJirjQQbf01foP8jQc8oKVuC0pV13LZJL05MM5A1zE2tOaZ4xchTtg9uDgpZOFVJHKxKwduiRwy62owYlVxdHYSrM6Rbyrja0PQjZvzrB6pH9cDFtrboDCRFu7QVyUjh0MYfu9503nluiWlpKq2TaZ0anYMxB0V8yuTS18AzGtK8lJ3c7HDzY1Z3qZSKHHgiGuqd9McntFKFuC/6/MiGFivYPb2XFLDG4Edj3cwCyVLe82fon6YL5zKYMw+zNEeGc1bp51wzz1CH X-Bogosity: Ham, tests=bogofilter, spamicity=0.002093, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 01:39:37PM -0500, Liam R. Howlett wrote: >* Wei Yang [241112 22:17]: >> In version 1 [1], we found current split would result into deficient node. >> >> By discussion, current implementation would lead to jitter problem. > >I don't recall it leading to a jitter, I was concerned about that but I >don't think this leads to jitter. > Sorry for my misunderstanding. > >> Since this >> is a rare case in real world, we decide to simplify the split calculation. >> >> Patch 1: simplify split calculation >> Patch 2: add a test case to check deficient node >> Patch 3: validate deficient node except for root node >> >> [1]: https://lkml.kernel.org/r/20241020024628.22469-1-richard.weiyang@gmail.com >> >> Wei Yang (3): >> maple_tree: simplify split calculation >> maple_tree: add a test check deficient node >> maple_tree: only root node could be deficient >> >> lib/maple_tree.c | 25 +++++++------------------ >> lib/test_maple_tree.c | 28 ++++++++++++++++++++++++++++ >> 2 files changed, 35 insertions(+), 18 deletions(-) >> >> -- >> 2.34.1 >> -- Wei Yang Help you, Help me