From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 962E1D637AE for ; Wed, 13 Nov 2024 20:31:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id E2DDC6B0093; Wed, 13 Nov 2024 15:31:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id DB5DA6B0095; Wed, 13 Nov 2024 15:31:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C56D96B0096; Wed, 13 Nov 2024 15:31:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A50D56B0093 for ; Wed, 13 Nov 2024 15:31:20 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 2CFB41C6974 for ; Wed, 13 Nov 2024 20:31:20 +0000 (UTC) X-FDA: 82782216300.14.13D324F Received: from zeniv.linux.org.uk (zeniv.linux.org.uk [62.89.141.173]) by imf25.hostedemail.com (Postfix) with ESMTP id E1D10A0005 for ; Wed, 13 Nov 2024 20:30:46 +0000 (UTC) Authentication-Results: imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Dp0lW7Bq; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731529701; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=uBOk39HO5marrjmAPTj5btVGIMvjnKV9Fn7MUaxbEpk=; b=eYdSM0US1VJ77fjWfj/W71jfw1aqd4BHywayZqfarr7XDvn4k6adQ5RqdfyidZSS/lDlZL lA0C90lCClcNMicSYgpMB6LAWD8oC1mq614iZ3c3N4/IpgfCntaJF53zplt4d0WKj5XBq4 F3HIY/EvWVOh08ROvgMtQVDOC0n6xqM= ARC-Authentication-Results: i=1; imf25.hostedemail.com; dkim=pass header.d=linux.org.uk header.s=zeniv-20220401 header.b=Dp0lW7Bq; dmarc=pass (policy=none) header.from=zeniv.linux.org.uk; spf=none (imf25.hostedemail.com: domain of viro@ftp.linux.org.uk has no SPF policy when checking 62.89.141.173) smtp.mailfrom=viro@ftp.linux.org.uk ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731529701; a=rsa-sha256; cv=none; b=8IW0gbHlOq4f9nJ0vmo+hx+LZSUiVYXXaedSRxyDe65MV+VGZUGo+bMFS7nzRxtrA31GdA 08hwkPvFi4hvdoEIHc9VlppS0o9iLybb/ZSVQ2Z4i4BUpFuZCiwwFqG4cCrohENs4kIPhr 0NUJViIMbWklf+0jaYypfGpWaZHZsGM= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=linux.org.uk; s=zeniv-20220401; h=Sender:In-Reply-To:Content-Type: MIME-Version:References:Message-ID:Subject:Cc:To:From:Date:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description; bh=uBOk39HO5marrjmAPTj5btVGIMvjnKV9Fn7MUaxbEpk=; b=Dp0lW7BqSOlcJA51VtHwe564wV bnUOR8BBbkRAur4PjGE1BSuYnNSS+FYXd0XvM31Y4dxBkG78PBnOo5/eO0CMOC9muhV7t1SEvK+p3 sjYerInIF1c7dYfxq38gWEnFTp+VLqXD+AVuxrgIB0k8CS997hVB//fBUYl5W53mWINzHZAsPkOZO IPxEFvpNqy7eFQ3WepBlIahA4uLon9res3epmB4ywsx/CuS6ec9v5sdGZKDy3VLT085LtjwVhDzQK 0odxif7J3+KG0flpwujrcodDpBSPXi5I/dMR2gCQ2tpy/eFCTK8RG2gSdAgNB0eaYybdb/XH5qnSe qk9i9eTw==; Received: from viro by zeniv.linux.org.uk with local (Exim 4.98 #2 (Red Hat Linux)) id 1tBK1A-0000000EctM-2Gpv; Wed, 13 Nov 2024 20:31:12 +0000 Date: Wed, 13 Nov 2024 20:31:12 +0000 From: Al Viro To: Amir Goldstein Cc: Linus Torvalds , Josef Bacik , kernel-team@fb.com, linux-fsdevel@vger.kernel.org, jack@suse.cz, brauner@kernel.org, linux-xfs@vger.kernel.org, linux-btrfs@vger.kernel.org, linux-mm@kvack.org, linux-ext4@vger.kernel.org Subject: Re: [PATCH v7 05/18] fsnotify: introduce pre-content permission events Message-ID: <20241113203112.GI3387508@ZenIV> References: <141e2cc2dfac8b2f49c1c8d219dd7c20925b2cef.1731433903.git.josef@toxicpanda.com> <20241113001251.GF3387508@ZenIV> <20241113011954.GG3387508@ZenIV> <20241113043003.GH3387508@ZenIV> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: E1D10A0005 X-Stat-Signature: izntyt8zrz8hyn3oocqmataomtmqii5d X-Rspam-User: X-HE-Tag: 1731529846-376749 X-HE-Meta: U2FsdGVkX19AokEk3E++QXkp33SKfmcdilKTXGASTr3bU6Pj/eYiITsdynpuOSlNepmn5NGLe5Z7M3qm1pB6XyuB4pIjJtYpPnx2ndV08LobJyNBjPYcB1/J50o6uK3gFSZf3h5X20QQJqT+a+kxYo8IQO8hNvVMs77q04XR5umELWEWZiSjNVrtnAhRkrxE6S+Zt2CcsdoK+6O3pvdY/8Er2BWbnqgRX1fkooVUtlLxeQPR9LIJgcgENHm6veapKCJSVDUA9n76W4lKy+W2FXXMF/Lx4VNuzedE4CQoUj3jRXJHWLLfYZHNvpSHzxCwBN9G5iO5gStFJPlaZqyzFXJT9aZGj++vCaiBTCmy6jErEQgTK3UC0dX2ryd7SHirS0KLH2ya0LPajhv0yYriSgMf0yKlPbZyY4yz84Eg36WzfGPm9YowTZaljmtB3JT8C3HblS1oBQOctPWD2Eu0X7X/X0J0QQIaVaGQxeXgdHMEd6EM5FDvP8iJftmNmqtRfDIxnNj8PvjkGUpvi6zjsnIKoDLnnrVP2DOUWPb+PIT0vc1LZWSC+Ini2CQEeAdd8ON76nT8bXD87bwG3GANsVFARGdBKbm5I2XnJvE1oNFmsVzCgChMdM8eOrnpyYHU6Vjqb76JTp07nYkm6tGuzmp9fGhVMpIDUlFu1xeVJppYNzY8Mpb3ecrhNfpqEhOvYyK04uihv59Pif2ENP+8xDR3VN0aNfIOJANr3qJoGJdPuUyTiOAHxILXK1nnF1JlxqmJCkMHyocsvA+StNztNItP7euEzZFsnaXKgFwEE8612ENT/QerspgtuXpKo/ujr5VryemPE8voOQGLZ4ulCodvofxGxC4bbyBeK4EIGv03r6JzrO79kcToCq+wp8+QIcsMGRpOhuLZ2Rp9WO1gCfV2MV/w96d+80SKS0QkGihU7TWvfKnFV+mpXfrgXskYjOMv2sjV7xqd1XU/Qyl g4+JbXqT tMdQQIqqCvoqvaKyubeBW0ZNWODHXSO4Pez0tCLGGoZtgIQXnbd+tKpRPujWO6Z7LvvCbSfTaB1YBFubZ1asuvNOq2M8b119q1aNFLCbfv4HwPSndkdA+FQWU5ZyL9MAbSrSJVGjUuOSb6pnXV5Os6v9OMwZxJiQak8zRHKHEmczD71EipRy7Cx8k7jc8ZqUxTNW4QxXxA1XR7dpmSUuVUsiyZ+Moq+C05x8WZ+Ras2SCX8AtKfLPBhcXPCT+Lnj+8AyXTeX77hHY8qJvhli3NWeNiOiMqNYdt8U0eurcdXQ0txNrdhcghLdn6VlsSwaYsp9uOinr1x4rGPA8FPtIdANi7ejLGsrc51X1G4vGNFTAdt7DyjzNupjNICnQ+Tb7c+/o1b4A0RCLYWJQmaN6ilKSBMkcdw3GR8gjs2k9gH+h/eO+D9omB3jKz+hVduXe2e2X X-Bogosity: Ham, tests=bogofilter, spamicity=0.000081, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 13, 2024 at 03:36:33PM +0100, Amir Goldstein wrote: > I would make this a bit more generic helper and the comment above > is truly clueless: > > /* > - * we need a new file handle for the userspace program so it > can read even if it was > - * originally opened O_WRONLY. > + * We provide an fd for the userspace program, so it could access the > + * file without generating fanotify events itself. > */ > - new_file = dentry_open(path, > - group->fanotify_data.f_flags | __FMODE_NONOTIFY, > - current_cred()); > + new_file = dentry_open_fmode(path, group->fanotify_data.f_flags, > + FMODE_NONOTIFY, current_cred()); Hmm... Not sure I like that, TBH, since that'll lead to temptation to turn dentry_open() into a wrapper for that thing and I would rather keep them separate. > > - fd = anon_inode_getfd("[fanotify]", &fanotify_fops, group, f_flags); > > + fd = get_unused_fd_flags(flags); > > s/flags/f_flags ACK - thanks for catching that one.