From: SeongJae Park <sj@kernel.org>
Cc: SeongJae Park <sj@kernel.org>,
damon@lists.linux.dev, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, kernel-team@meta.com
Subject: [RFC PATCH 2/5] samples/damon/wsse: implement DAMON starting and stopping
Date: Wed, 13 Nov 2024 08:26:21 -0800 [thread overview]
Message-ID: <20241113162624.48973-3-sj@kernel.org> (raw)
In-Reply-To: <20241113162624.48973-1-sj@kernel.org>
Start running DAMON for the process that user requested to estimate the
process via 'pid' parameter, when 'y' is passed to 'enable' parameter.
If 'n' is passed, stop running DAMON. Iterating the DAMON monitoring
results and estimating the working set side is not yet implemented. It
will be implemented by the following commit.
Signed-off-by: SeongJae Park <sj@kernel.org>
---
samples/damon/wsse.c | 35 ++++++++++++++++++++++++++++++++++-
1 file changed, 34 insertions(+), 1 deletion(-)
diff --git a/samples/damon/wsse.c b/samples/damon/wsse.c
index 5912f15181c8..119ac8a2c901 100644
--- a/samples/damon/wsse.c
+++ b/samples/damon/wsse.c
@@ -27,15 +27,48 @@ static bool enable __read_mostly;
module_param_cb(enable, &enable_param_ops, &enable, 0600);
MODULE_PARM_DESC(enable, "Enable or disable DAMON_SAMPLE_WSSE");
+static struct damon_ctx *ctx;
+static struct pid *target_pidp;
+
static int damon_sample_wsse_start(void)
{
+ struct damon_target *target;
+
pr_info("start\n");
- return 0;
+
+ ctx = damon_new_ctx();
+ if (!ctx)
+ return -ENOMEM;
+ if (damon_select_ops(ctx, DAMON_OPS_VADDR)) {
+ damon_destroy_ctx(ctx);
+ return -EINVAL;
+ }
+
+ target = damon_new_target();
+ if (!target) {
+ damon_destroy_ctx(ctx);
+ return -ENOMEM;
+ }
+ damon_add_target(ctx, target);
+ target_pidp = find_get_pid(target_pid);
+ if (!target_pidp) {
+ damon_destroy_ctx(ctx);
+ return -EINVAL;
+ }
+ target->pid = target_pidp;
+
+ return damon_start(&ctx, 1, true);
}
static void damon_sample_wsse_stop(void)
{
pr_info("stop\n");
+ if (ctx) {
+ damon_stop(&ctx, 1);
+ damon_destroy_ctx(ctx);
+ }
+ if (target_pidp)
+ put_pid(target_pidp);
}
static int damon_sample_wsse_enable_store(
--
2.39.5
next prev parent reply other threads:[~2024-11-13 16:26 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-13 16:26 [RFC PATCH 0/5] mm/damon: add sample modules under samples/damon/ SeongJae Park
2024-11-13 16:26 ` [RFC PATCH 1/5] samples: introduce a skeleton of a sample DAMON module for working set size estimation SeongJae Park
2024-11-13 16:26 ` SeongJae Park [this message]
2024-11-13 16:26 ` [RFC PATCH 3/5] samples/damon/wsse: implement working set size estimation and logging SeongJae Park
2024-11-13 16:26 ` [RFC PATCH 4/5] samples/damon: introduce a skeleton of a smaple DAMON module for proactive reclamation SeongJae Park
2024-11-13 16:26 ` [RFC PATCH 5/5] samples/damon/prcl: implement schemes setup SeongJae Park
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241113162624.48973-3-sj@kernel.org \
--to=sj@kernel.org \
--cc=damon@lists.linux.dev \
--cc=kernel-team@meta.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox