From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1B747D41C0A for ; Wed, 13 Nov 2024 06:52:50 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9C2886B00B7; Wed, 13 Nov 2024 01:52:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 972456B00B8; Wed, 13 Nov 2024 01:52:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7C4D06B00CA; Wed, 13 Nov 2024 01:52:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 5B02D6B00B7 for ; Wed, 13 Nov 2024 01:52:49 -0500 (EST) Received: from smtpin23.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 11DF5A086E for ; Wed, 13 Nov 2024 06:52:49 +0000 (UTC) X-FDA: 82780152756.23.C994939 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf22.hostedemail.com (Postfix) with ESMTP id 53FABC0024 for ; Wed, 13 Nov 2024 06:51:54 +0000 (UTC) Authentication-Results: imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pSQlZt1W; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731480704; a=rsa-sha256; cv=none; b=Bdb+U9jM8rxMzJ6kvpqA1L1vX1rT28SC2hQ+xwzWrXsrvzNvD5t/VWyiAzq8pBtt/LhqAZ T0qRjd4OUo8uiVdAL/c0CWoAqIARS15AaPrsT1J4MhjururOYAYBsJQ6UifYcSsPgjr5Cp una4eMbKdJ8hSPEr8bkDNM61oJpXrqw= ARC-Authentication-Results: i=1; imf22.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=pSQlZt1W; dmarc=none; spf=pass (imf22.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731480704; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=U2vB+01RTK8AvNJhmJ9rKgn9h+oBDOH9xIu6f6Kc5eM=; b=54dGi9KsqiZGBpb8AJpBXozQhhtExG+c5MItcX3X8Zyl0jiZ661KO407y5sU3scI6/QzGX dM2ywz1NkwCRWl0BE5+ICHwNayXIIhNV2IHsifbBFiQanYRa0pOIuNkw5pnHmMZXvVwIxh TTava0EXI31/s5jKGmhglxvBrOmBoGA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 6E5C9A40410; Wed, 13 Nov 2024 06:50:52 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id BE6B4C4CEDF; Wed, 13 Nov 2024 06:52:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1731480766; bh=xOpcl2VEYuCAnW+x7NWomeilL+Xx2LUb6LUm1ijdC00=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=pSQlZt1WbgDhVKpE1A9GMSjJDjfDqOR/P0Lg6FEI2p4tqRQmkRR1qle8LaC9uDRPU 6Om0S9Cm6kof/BkO8gQBWiMJYxPRrffbBKf9gIOVsYvCDh7cJaZ5L9LFrnFwY6M/Ng VcwbODd2YhVwvW4Q85DRF5rt/pT2UjOYtqCcCuPU= Date: Tue, 12 Nov 2024 22:52:45 -0800 From: Andrew Morton To: Ritesh Harjani (IBM) Cc: linux-mm@kvack.org, linuxppc-dev@lists.ozlabs.org, Sourabh Jain , Hari Bathini , Zi Yan , David Hildenbrand , "Kirill A . Shutemov" , Mahesh J Salgaonkar , Michael Ellerman , Madhavan Srinivasan , "Aneesh Kumar K . V" , Donet Tom , LKML , Sachin P Bappalige Subject: Re: [RFC v3 -next] cma: Enforce non-zero pageblock_order during cma_init_reserved_mem() Message-Id: <20241112225245.52d0858536c6fb9ba4a683c0@linux-foundation.org> In-Reply-To: <87h68bnbko.fsf@gmail.com> References: <054b416302486c2d3fdd5924b624477929100bf6.1728656994.git.ritesh.list@gmail.com> <87h68bnbko.fsf@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Queue-Id: 53FABC0024 X-Rspamd-Server: rspam01 X-Stat-Signature: r6kq59izk6mi3w68sz81dgsw5goho9f5 X-HE-Tag: 1731480714-200830 X-HE-Meta: U2FsdGVkX1/eMEeVo5eJZPU1CD3n79OHJEXMS9xpR1qdbTHJXVmo2pNq/ulM1iHiLaFUCPu1Kl4oL+0j4OppAx+8DOzuo2MRNvIVOEXVhJGwbLo2i7Q4kTRJ9sgjTqdGVjCtFurWql8VEzQJU0dmQYSwabyta+3S31qBOpt9xNjDxi3obej0l6LMOeUIxd4ZIqDgmth7Exc1SKschfltZFv9X3B2ZXXZ6Ls2pKS0UqaHpeedXhPrA51gIvWsUzTxHaDn2v1tSJsLpd5J/edq3BduqNDAlAA6qSvepIzl9fyNx++FqmyCUVnF+4QG5LpbxjWEbvhlAkxsFZCpLe1lPeL5D7/7nj8sfiz7ZwxbHprMvcdmz1f/Vy3G/FdyYU0l4VfcMuf2G5ER/uakf9hh2oB3t1gb/nPd7HikAkP0LN4DIb8kLSTeKKqXSLM49T06ExXRcH/GKudu+ZM3Ull8Swo2dYVBICLRsJo9ShPA3kFB0rMn4J0xbx0Q84Ct/1ip4XTPIKp9/DKb9sdbwBDAQpLSIyP0ICGGMsjLlmqPcWCBtK17RUyGwNi0cagXnuhQyNqF3Wj0yZnrmsi4ggUyd0bethIbQUPf+SAVERDwDsY17lFHl3syxpkuYth1lPqbnqIuujooByUF8Luy968pLllrvhXHpIbdt7bsdSH1p6k6kVBac2vxH0dC/kKzAejH4zFzoBGScP+NidN5XxmEqEoaDmwso4tnU4c+IF+s16qYmCgwoK9uof+nREm3YAYI4/GzMcESO9zijSDVCVSWflthULOXTKZUmgTl+Wgc9jQ7WjZ3P16nkefLE62Gvk0SrqXcM7uA3SuEd0qy6Zcwbp2njriHwL860VHOcSV/EaiSFxHSn0fD92eVdDBRloN2UufBirXlO2dpav7xRhmNi6uuPkCN7f0UDd6TTFuAucRJhXHIPoJToszX4PlmnZcGVX5kFZroYjLXEBv5BoL RMDpLPSV o0U2Iw51WLHJ6fjdB2L2HkLZ7xsDHbtzkh48HHQHtwinYxMWzJhQ7oppf+FlM+lIe9D09PWGhsnr+WlTvkRspqEYgcF19afYlFlFDmvWxNNbOUylOe3BU6XLMUTxyDjEPlp037reIQVOd6SfGrvT47uOslWKupUj9rE4xGyf55I12R8RX0U+qoGQ+2ibX0HZuDpalJowxg1tzpMl5ZBmWsV61XQRMphpyx7NKCS/0kZcULdeFAEHnlot8SUtk0nZ1SgbMIUDJ6LcOAyDO+e1HqRk6SO/e20bV94ONA2kLPE7oNBmYxoC3NUn3hqBorNTQTpKlThuOb5lQeXAn227w/ROKvPvEptdABWzOaM91rPuIOqCXosPcdjCqUIH1cVVWcfga88bxrJQ+4JT1rIdAQpiydHmy39BM1v9ZzdqhPNTKtFt4EWcG8GJEehRe26OoyMva X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, 13 Nov 2024 07:23:43 +0530 Ritesh Harjani (IBM) wrote: > "Ritesh Harjani (IBM)" writes: > > > cma_init_reserved_mem() checks base and size alignment with > > CMA_MIN_ALIGNMENT_BYTES. However, some users might call this during > > early boot when pageblock_order is 0. That means if base and size does > > not have pageblock_order alignment, it can cause functional failures > > during cma activate area. > > > > So let's enforce pageblock_order to be non-zero during > > cma_init_reserved_mem(). > > > > Acked-by: David Hildenbrand > > Signed-off-by: Ritesh Harjani (IBM) > > --- > > v2 -> v3: Separated the series into 2 as discussed in v2. > > [v2]: https://lore.kernel.org/linuxppc-dev/cover.1728585512.git.ritesh.list@gmail.com/ > > > > mm/cma.c | 9 +++++++++ > > 1 file changed, 9 insertions(+) > > Gentle ping. Is this going into -next? I pay little attention to anything marked "RFC". Let me take a look.