[PATCH] mm/damon: fix order of arguments in damos_before_apply tracepoint

[PATCH] mm/damon: fix order of arguments in damos_before_apply tracepoint

[Akinobu Mita]

Since the order of the scheme_idx and target_idx arguments in TP_ARGS is
reversed, they are stored in the trace record in reverse.

Fixes: c603c630b509 ("mm/damon/core: add a tracepoint for damos apply target regions")
Cc: SeongJae Park <sj@kernel.org>
Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>
---
 include/trace/events/damon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/trace/events/damon.h b/include/trace/events/damon.h
index 23200aabccac..da4bd9fd1162 100644
--- a/include/trace/events/damon.h
+++ b/include/trace/events/damon.h
@@ -15,7 +15,7 @@ TRACE_EVENT_CONDITION(damos_before_apply,
 		unsigned int target_idx, struct damon_region *r,
 		unsigned int nr_regions, bool do_trace),
 
-	TP_ARGS(context_idx, target_idx, scheme_idx, r, nr_regions, do_trace),
+	TP_ARGS(context_idx, scheme_idx, target_idx, r, nr_regions, do_trace),
 
 	TP_CONDITION(do_trace),
 
-- 
2.34.1

Re: [PATCH] mm/damon: fix order of arguments in damos_before_apply tracepoint

[SeongJae Park]

Hi Akinobu,

On Wed, 13 Nov 2024 00:48:28 +0900 Akinobu Mita <akinobu.mita@gmail.com> wrote:

> Since the order of the scheme_idx and target_idx arguments in TP_ARGS is
> reversed, they are stored in the trace record in reverse.

Thank you for finding and fixing this!

> 
> Fixes: c603c630b509 ("mm/damon/core: add a tracepoint for damos apply target regions")

Can we also add Cc: <stable@vger.kernel.org>?

> Cc: SeongJae Park <sj@kernel.org>
> Signed-off-by: Akinobu Mita <akinobu.mita@gmail.com>

Reviewed-by: SeongJae Park <sj@kernel.org>


Thanks,
SJ

[...]