From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 39029E7716D for ; Thu, 5 Dec 2024 15:23:01 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 4C5226B0120; Thu, 5 Dec 2024 10:19:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 051386B00C5; Thu, 5 Dec 2024 10:19:18 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 5567E6B00B7; Thu, 5 Dec 2024 10:19:12 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0017.hostedemail.com [216.40.44.17]) by kanga.kvack.org (Postfix) with ESMTP id A8C6D6B00DC for ; Tue, 12 Nov 2024 10:30:02 -0500 (EST) Received: from smtpin01.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 4241FA02F4 for ; Tue, 12 Nov 2024 15:30:02 +0000 (UTC) X-FDA: 82777826502.01.EBA97A2 Received: from m16.mail.163.com (m16.mail.163.com [220.197.31.2]) by imf03.hostedemail.com (Postfix) with ESMTP id 1C2EA20015 for ; Tue, 12 Nov 2024 15:29:39 +0000 (UTC) Authentication-Results: imf03.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=Bii2dlgW; dmarc=pass (policy=none) header.from=163.com; spf=pass (imf03.hostedemail.com: domain of a929244872@163.com designates 220.197.31.2 as permitted sender) smtp.mailfrom=a929244872@163.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731425271; a=rsa-sha256; cv=none; b=06HADw0ojBvabDykf2+cCMY8z5JnZQgfhGZhucp7Armj2u2wtPjV4sRPgNIFekCAWxYURP XE0UKn643wHF2rn8zc4qt7K9+8sy4We0etzwjH0i06lrBqsBKzJhp1eJhCfUjq3bRhDOG/ tZ82tpmn+ke1Zl+MFv6iTxxmoULNqKU= ARC-Authentication-Results: i=1; imf03.hostedemail.com; dkim=pass header.d=163.com header.s=s110527 header.b=Bii2dlgW; dmarc=pass (policy=none) header.from=163.com; spf=pass (imf03.hostedemail.com: domain of a929244872@163.com designates 220.197.31.2 as permitted sender) smtp.mailfrom=a929244872@163.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731425271; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=oqXVSMKA4Orhx7BCmHgBiLA8Z4Chd8Eu/NrdlWlTDtw=; b=OfXusLf/h+gL+coUUM9ltyXMeZ7rNNXmkEvEtbfurEAQQmLnepIrjLJxtvyxsAcUvRl1/j 2ODuvhulhJgWDttZN323XClMj3w6q/itxNcGrOPhqVG5XfdUynkmXuBAPhEDg7ipdVle91 sMcGWm+jjTjd77DYkGXN9avZ9bLjd0o= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id:MIME-Version; bh=oqXVS MKA4Orhx7BCmHgBiLA8Z4Chd8Eu/NrdlWlTDtw=; b=Bii2dlgW5flCWZPzXEEXG r+5L7/p9MHORB3ZymOBVZC4Ivq2XhT5EbjQN+UFP1je2noNQH5O5VZ3qIM+B0UVt SuPAudRalxtv/k8u8pwLzupizku5X2P8xe90xs1UPOt5BhoyxdG/l6ZIj1WHYo+D 72eH09/IzfICkUd0gPE/7g= Received: from localhost.localdomain (unknown [111.0.233.109]) by gzga-smtp-mtada-g1-1 (Coremail) with SMTP id _____wD3P6w0dDNnFW2RAw--.8675S2; Tue, 12 Nov 2024 23:28:53 +0800 (CST) From: wang wei To: tabba@google.com Cc: ackerleytng@google.com, airlied@gmail.com, akpm@linux-foundation.org, david@redhat.com, dri-devel@lists.freedesktop.org, jgg@nvidia.com, jglisse@redhat.com, jhubbard@nvidia.com, keirf@google.com, kirill.shutemov@linux.intel.com, linux-mm@kvack.org, mail@maciej.szmigiero.name, maz@kernel.org, muchun.song@linux.dev, nouveau@lists.freedesktop.org, pbonzini@redhat.com, qperret@google.com, quic_eberman@quicinc.com, roypat@amazon.co.uk, rppt@kernel.org, seanjc@google.com, simona@ffwll.ch, vannapurve@google.com, will@kernel.org, willy@infradead.org, wang wei Subject: Re:[RFC PATCH v1 06/10] mm/hugetlb: use separate folio->_hugetlb_list for hugetlb-internals Date: Tue, 12 Nov 2024 23:28:49 +0800 Message-Id: <20241112152849.10369-1-a929244872@163.com> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20241108162040.159038-7-tabba@google.com> References: <20241108162040.159038-7-tabba@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-CM-TRANSID:_____wD3P6w0dDNnFW2RAw--.8675S2 X-Coremail-Antispam: 1Uf129KBjvJXoW7KryxGF4xCw1xXrW7Cry8Zrb_yoW8WF43pF yqga4DKr48Wr9rWw1xAw45ArWSgFy8Zw4YyryS9343ZFWfKryxCan3CF15GFW8Ars8Cr12 9w4v9F98J3WUCFDanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUjbIjqfuFe4nvWSU5nxnvy2 9KBjDUYxBIdaVFxhVjvjDU0xZFpf9x0JU2_MsUUUUU= X-Originating-IP: [111.0.233.109] X-CM-SenderInfo: jdzsmjiuuylji6rwjhhfrp/1tbiLgOVpmcza3OdMAABs+ X-Rspamd-Queue-Id: 1C2EA20015 X-Stat-Signature: 9q63cfzu916uyoja6d3pip8x7zxnp3ri X-Rspam-User: X-Rspamd-Server: rspam05 X-HE-Tag: 1731425379-398398 X-HE-Meta: U2FsdGVkX1+whD3ELrBi+90/hKSmW+aL4E8cmzRVWhc+kCyQXUdR5oa0HxI3kDzkvQu6tscw9H3ABKmItMs26/9GupwmMOSLgmW5MraT4r1G2lgNJduBA899izaVx6jSVrFsQvzXFw8uqyi8dIjdLHxT+wUS9+27e6/lTg/Wtt4MG94Fr68GR9kObhpdVBjXcOO+CrWKomYvX7q+WuRbAy3tQX3dkJA4nSf/oDOO6GcZOkxX/ijtibStDFiwQlh3yEsAIJGAFd+2K3Exv5cw1J+J5UbobIu8+tncQ0sFV9WJEl+9/TxLKPYW7vxZoxFuSnYcLMDbZ+and5e08bS0Gn03YuoY+rQNQkfTQlCnlfRaQ1fLfF0+6hW/qMOHmZmAbxg7sHQ9T0pa+OdzcJDgEKuJ7wHD9pptfMFYi+1YJF9Dk7y6pe3VK3hm+VmJnu43lnU5ZfwUyO04xdsY1E1dotcTlAkL5bJ2PdDzAvCbn9TR6mjXh9iTDhvyLDJgAhKGdibUJziv4AGpX+NSldExERY0CjPjXcShEWH33Y8RcEvOEH5qpuNSREjGurzroMavHWVd75EvPk9SlbQzZwPsyzsZA362cCgvmPlt3kLGynSgS4lGvSq+OIATzh9AYkf39Goq4iI/c46Da1dEC1YTtX+74vH0AusAcS4cneNtvBiYcbfpJY4wEYcuNM659J+oLsXiccQlBST1FRc0WUYSVQUT/nGoOnbOY09mQj3TVZoJAw+xW+qjFg27xuJJZaPrYi+Xd3u3Ju4OqvCIiddACRj9h+ezJ/s8zQuiuGMRzLV31v8MU33WKe58tpl1/aNjouCQs4LdINmRxQ0GkC5KMgQiRl09YNQLnkP8tflzJ7Mpjidn7eSml4iF4HWtU/6IwAfViuZExeQOxMo0ySkftHGHR5NzVNZPzF9ZT6wnJpuUoucLU7i+tIUktBfK8qxM2CN5kbF4WvpySOJwNk5 efqyBBoy bfFh6kt4XyiWg93lzNrlO09LsHN943cLTky0ZqjmzrOFN/Pjd2Qm5aYOyLS2W64YF6ghbv37nFT/yXZHSarlQ2gWOzJdAOnAd+rbQc130e3Wj9E4vTEChIIzs6xkgqfpqtuish0rBuxFTu0LcSiiHubAq1U1+AdUhcR0o+11d7Os0/BvPUZhmtOzeYTT8hjxIvuWgaZzhGh1s9NVVJSowvcYM+ntqwD6h9slHhwKxRScdlYyWnUDdsbXsgAumVKecCV3VukZN6MjblN9OBgmC1Eq77WsLpSoP+YeD0Vo0YyYtLfJtRUzfHpdIfphUehedNUMqOeHgrdT2s1xa/oXofgplR6GNlelfipyfRQbCl+nfhnYU3EvJNu38KqMfDemGzxIobgUH7sqlG/IzCgMfPj3RVsBbp7ax+2gPy+sv34hLOGqQ2rsKYffngdrN6NNX3aHpbiEigASflYZn/iAMrkpI3M2TTQo6e1FO5vzNj5HD9IyditYKWPpVbbqOP82oP0zKOUUjK2IpBDatrVmIJTgTXze4fXSPMl4qpQsz3mL5OAs= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Signed-off-by: wang wei --- >diff --git a/include/linux/mm_types.h b/include/linux/mm_types.h >index 80fef38d9d64..365c73be0bb4 100644 >--- a/include/linux/mm_types.h >+++ b/include/linux/mm_types.h >@@ -310,6 +310,7 @@ typedef struct { > * @_hugetlb_cgroup: Do not use directly, use accessor in hugetlb_cgroup.h. > * @_hugetlb_cgroup_rsvd: Do not use directly, use accessor in hugetlb_cgroup.h. > * @_hugetlb_hwpoison: Do not use directly, call raw_hwp_list_head(). >+ * @_hugetlb_list: To be used in hugetlb core code only. > * @_deferred_list: Folios to be split under memory pressure. > * @_unused_slab_obj_exts: Placeholder to match obj_exts in struct slab. > * >@@ -397,6 +398,17 @@ struct folio { > }; > struct page __page_2; > }; >+ union { >+ struct { >+ unsigned long _flags_3; >+ unsigned long _head_3; >+ /* public: */ >+ struct list_head _hugetlb_list; >+ /* private: the union with struct page is transitional */ >+ }; >+ struct page __page_3; >+ }; >+ > }; > As far as I know, increasing the size of folio maybe decrease the revenue of HVO, do you measure it? > #define FOLIO_MATCH(pg, fl) \ >@@ -433,6 +445,12 @@ FOLIO_MATCH(compound_head, _head_2); > FOLIO_MATCH(flags, _flags_2a); > FOLIO_MATCH(compound_head, _head_2a); > #undef FOLIO_MATCH >+#define FOLIO_MATCH(pg, fl) \ >+ static_assert(offsetof(struct folio, fl) == \ >+ offsetof(struct page, pg) + 3 * sizeof(struct page)) >+FOLIO_MATCH(flags, _flags_3); >+FOLIO_MATCH(compound_head, _head_3); >+#undef FOLIO_MATCH > > /** > * struct ptdesc - Memory descriptor for page tables. -- 2.25.1