From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31118D42BAB for ; Tue, 12 Nov 2024 16:46:10 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id BB7516B00EA; Tue, 12 Nov 2024 11:46:09 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B40A06B00B4; Tue, 12 Nov 2024 11:46:09 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A08DE6B00EA; Tue, 12 Nov 2024 11:46:09 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 792136B0085 for ; Tue, 12 Nov 2024 11:46:09 -0500 (EST) Received: from smtpin18.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id 74AF31A040E for ; Tue, 12 Nov 2024 16:46:08 +0000 (UTC) X-FDA: 82778019534.18.D8E25E7 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf02.hostedemail.com (Postfix) with ESMTP id 075768001F for ; Tue, 12 Nov 2024 16:44:46 +0000 (UTC) Authentication-Results: imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sw5tfxPQ; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731429823; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=qQiywUc0wzYBbDNOmIFi3yD13hsk1Nt9QFq+VLPi14c=; b=Hi26JZiYnh9bUQlCNhXx+lEGL3SbCZe4BBCplluAsI1RLBl4A/y5geIs2wsxMqD9ZLrXtc CacfrceCVdlJiQ+QUfVz6oiH0+9OKIV8WGcYZYE1Jyc5B2ANTdU5SRtzNLofQd2twskGU/ 8zS5En+gbB1cgYAjYyvZs4CQUu/o6TA= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731429823; a=rsa-sha256; cv=none; b=6GedCH86+PlcORd7ZnKA6zmTVWennnK7r4cKBSbyrxg7Mb+Z+g/5bFKV9U82shFd3ooPta FJic1Wsd5HsGrA0R0BgPhyuRbLiTnYaUJuk+FoHZEv2lZJ4VW5iNrTry8f9ORB74Piq2VK LIQaJzXCVKPU1VQVnMreIr6jF4BQXJ0= ARC-Authentication-Results: i=1; imf02.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=sw5tfxPQ; spf=pass (imf02.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 951635C5620; Tue, 12 Nov 2024 16:45:20 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7B272C4CECD; Tue, 12 Nov 2024 16:46:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1731429964; bh=WR+aOSyYwrgldXqeUgY/GrhfFKL6OmuAO/PaK1Z+ZLM=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=sw5tfxPQpykxtH4qrAnt4kFGBs/rMGI0o05HWTaMivXx6/Pn/oSB1g5dDI5o7JsaJ mtNhDR0dcExCRJ9S8K8d/t2G/9DHbjR77+kK4zeZOfv5XlLsXVkzWCLfWW7OiuN1Wq CarqRsV4zeXbslmRRByvjyi6fJ9ksyFjzCNc/gOo= Date: Tue, 12 Nov 2024 08:46:03 -0800 From: Andrew Morton To: "Liam R. Howlett" Cc: linux-mm@kvack.org, maple-tree@lists.infradead.org, stable@vger.kernel.org, Hajime Tazaki Subject: Re: [PATCH] nommu: pass NULL argument to vma_iter_prealloc() Message-Id: <20241112084603.1c4e351fe21c9602422bf052@linux-foundation.org> In-Reply-To: References: <20241108222834.3625217-1-thehajime@gmail.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: 075768001F X-Stat-Signature: k8xrwu4uosywnhzcmksczfyu6gxdh3f9 X-HE-Tag: 1731429886-630008 X-HE-Meta: U2FsdGVkX1/kZsULDEiV8TBYTXCQ/F1wrqQh1oAtVIII2BRsI0mAolVjJXx7PKH4slpuD4VMoSk4elJBnQ66E/33Oqp9RkBxFqC8+HeM2NbrRioaXV5z05GIfKuNO424tAAIndtHeUWyDlDFI4EIMyuZ9U8c+SYWT6TBieOsbctZEMSdK7lAqxxiByoGeTk3QvA5Ee76ht2SwIZUMkyrNgZu0Dsn2Bo+C/VfnjVAGu4FlGULlMtQaO/v02tXoJqC5qNPWzrxdZLTBhcykujav3S9TKHLRPhoE7mZncqzJ3XoXGJnjypKa25bNgKHMSp+ZGiV+CvLLfrQseT+2J8Mpo21edAJ9nxk7MRyugNGvOvTdONxg6dx9PIRS/ka9X4vzRjUProTzkcKDQ4hlqvEb5fCKxbZUuKzXcqjC7LrXiEnsVisfif3MtgnvIyFZJ+UarIzXvXtgeNY7D8fKRJh1viiVMTepEQ1tYIRIjqngFby5EPYMDttWE089KkVv6X1DIxE4xlOYvKKQ23hP2miaiKOQcGlWyXIWOg2A5NC+RxwflRdqnABeXvUX3DnobmOtvlZ73S1UHqmU9hYqna55xnGtQ64e8BuugjAIO0XVdxvXFFMWqhdWs0QZWcwATdkplyyz52tRWjnSA6IVIAW16L7/cY6Xc+6sBu77fG9HnR3gVErChHlheY0goX1b7ndXRZX1SxBNlkki503sdFVpVj/j1bCV3ok629D/QQwIOo+dny+GOgzkKPEEysNScWNVbXVud3iOTJibSMjTfopsOG/U41BKIlfFjEPupkegrW6UHOJguVF9OcjmZxn49lbYODrrDNV4GLf3Yvc5jjTJ1VJQBBCXh6ufvlkw23gYmfNT34TJBUpVMNSVmzlusTu8E/Nz/fIJmLw42EjuZjSiKpSTRHccPWAmjqcqtINvENR2UD/DAxELbgsRM+hnPVJ0GWEIOkuvL/bqo5AI3h nvPDfFqw Q3O2mQ4boZxumzQv6x2aff7BJ5RBmtvmLYMGjUpDkBIqmqLw56UALwmFnNoK4Y49CGKXmMPiK77tvXMM6WDi3wBZmFyOF2BUFzY8O2gW7TxHQG4nYvhD4IzQIKwaj0neVCnO0jezErOotA3zm1dnE7CZWWP0gXQVJpjvESMKFFM4ZuLkAraMrit80yRemeRAiMyGk1Lu5CflhkFINQIj+D5wq71vvoBjJwZT5ij1h6u5Zy0Yb/8/WzrEkZrv6TiZ/Q9n1t+dwtjmYBo5tEL75UzHcaoHrLwJnmGjStGt84xZ79Ys7tdDyzLCUqhKd0OC29pyBDVf33+/GuAPzBD3HNA+2t1Qx00Wid4/SB+9mbPLklhY= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Nov 2024 07:46:18 -0500 "Liam R. Howlett" wrote: > Andrew, > > Just in case you didn't notice, this patch was reviewed on another list. > > Thanks, > Liam > > * Hajime Tazaki [241108 17:29]: > > When deleting a vma entry from a maple tree, it has to pass NULL to > > vma_iter_prealloc() in order to calculate internal state of the tree, > > but it passed a wrong argument. As a result, nommu kernels crashed upon > > accessing a vma iterator, such as acct_collect() reading the size of > > vma entries after do_munmap(). > > > > This commit fixes this issue by passing a right argument to the > > preallocation call. > > > > Fixes: b5df09226450 ("mm: set up vma iterator for vma_iter_prealloc() calls") > > Cc: stable@vger.kernel.org > > Reviewed-by: Liam R. Howlett > > Signed-off-by: Hajime Tazaki Yep, thanks, 247d720b2c5d in mm-hotfixes-stable.