From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 729E2D41D55 for ; Tue, 12 Nov 2024 06:01:18 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9FC0C6B00C8; Tue, 12 Nov 2024 01:01:17 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 983836B00CA; Tue, 12 Nov 2024 01:01:17 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 7B12D6B00F0; Tue, 12 Nov 2024 01:01:17 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id 514AD6B00C8 for ; Tue, 12 Nov 2024 01:01:17 -0500 (EST) Received: from smtpin07.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay06.hostedemail.com (Postfix) with ESMTP id 9FF0FAD5DA for ; Tue, 12 Nov 2024 06:01:16 +0000 (UTC) X-FDA: 82776393252.07.022B148 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf19.hostedemail.com (Postfix) with ESMTP id E4DFC1A0017 for ; Tue, 12 Nov 2024 06:00:22 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731391188; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=25oXpcZ2jkS0BbcUFsntK7m8dNPJ0WJqodki5oK1oFE=; b=MAqjLK4ahGP1lZ8vctXIrFDjTudelxf1zfwJVjIiupqUEmIACsvPDjkt2uVHHvGQkJGall x8QQigCpAssQbozViEsTWFvXKqr/orPstGPzNNO+3m6kJ5cCPJKXinB5ZKe8IdvxdKPyzX 5qaKwjbFS3kGRq7yIw9PZbf91c1O4Is= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf19.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731391188; a=rsa-sha256; cv=none; b=ppjqbRtjo0iPIhBJNef8loHbDI3qKcMYoB1tEFsFd3Kdc7BtLpFZrAJdZz3yCrF94OHtYU XD/2jd3aJryNmHr7KfrCJRXyK4kXVzD5gV/qIwZiCILLugHu2SstGpdHeCKsntgL+w8e99 Twro9pRLn0GJnqqQYvGjcuFmJxIwsaQ= Received: by verein.lst.de (Postfix, from userid 2407) id A286768D09; Tue, 12 Nov 2024 07:01:08 +0100 (CET) Date: Tue, 12 Nov 2024 07:01:08 +0100 From: Christoph Hellwig To: Jason Gunthorpe Cc: Christoph Hellwig , Robin Murphy , Leon Romanovsky , Jens Axboe , Joerg Roedel , Will Deacon , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org, matthew.brost@intel.com, Thomas.Hellstrom@linux.intel.com, brian.welty@intel.com, himal.prasad.ghimiray@intel.com, krishnaiah.bommu@intel.com, niranjana.vishwanathapura@intel.com Subject: Re: [PATCH v1 00/17] Provide a new two step DMA mapping API Message-ID: <20241112060108.GA10056@lst.de> References: <20241104095831.GA28751@lst.de> <20241105195357.GI35848@ziepe.ca> <20241107083256.GA9071@lst.de> <20241107132808.GK35848@ziepe.ca> <20241107135025.GA14996@lst.de> <20241108150226.GM35848@ziepe.ca> <20241108150500.GA10102@lst.de> <20241108152537.GN35848@ziepe.ca> <20241108152956.GA12130@lst.de> <20241108153846.GO35848@ziepe.ca> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241108153846.GO35848@ziepe.ca> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: E4DFC1A0017 X-Stat-Signature: 1t3s11iwhkqt3fa63yp9sfex1ap7zg1m X-HE-Tag: 1731391222-347701 X-HE-Meta: U2FsdGVkX1/QCUM00fFyfwOh817Y9608EZtx6nEaOsZ8sotG8sTKc8T7/qdfgQzlqscq5RMzCJCQ8/pRPiDYd4Nj9RCKwQm9vzQMCanyGHUP3Sc1gSEhua6wDAF9Uqszn/UnvZzuXC19dRbiufM+VXgsy9ewXV2NWg1VtzA5B0U0A3Ua4BeSE2SydPKSBoQTUJnDeuXTLv3SDdZwQtVU28dovc8Sk7FPuZdBTr/M01oEi9e4Z94TswLhFp9GMxmd8tklPSCwJeh98vUsZUyqEllOe4nxMsWSd00OeOPQm5sGHznjId7aRkvxXi0ir4/g5Fwt8xqOaaZkzZxZLaxfBgggS/0a5ckVBV0bqN4JkpAnqnjDvRMvS2Og4cu8qiLAJHt0o6wvFYAj3SkCioF3B3e04flr4hxfTfH06CDLFgt3+Kf5dsJnHLlSnyCvPGg2UYri9ZWh4+2mEDqC3c+372jZ2iRo3nyPTqGFH3CInM+ApdnI38jtSd6hAYxYhhJ8/F2dQGsgeK3a3zEJ/dWVB/UWeSsJ/2kFIcCtDrIguhv0iRVJMvyHAcr/z269CGsnw3quFONYTMyPINi0EkF3Lg9FuZTB8o0piFHUlQl5EJBb0NdAaj4RZbTo8VsbzqM9dnbA1zBSViu4vG+kIcRvNdTuuP8A9WLW20WLryDnTa7F/oW5oO3GLTGoO6d86sPTVD1DgiS8a1PRzoVY+5Mcy0WbTv5iUZBCvwQbtMCcebQOxBNvas9V/W9CQ9LtdMHTZZJLhWwt+kQdvvxOq4YD9Bq9lPFvGW+9zpNqKV+wFOx3j/KnTYEYhyCn0FlzMt3CVc9TZmjEVD8WTaFSnkOVOKlSGcDfKr9onCts2dKtBC0+JPqzhsSiUnXjzeVePB5xc5Qp5OTIg13FQxrukH7OPPuNyXKUSX9gxvopZDQ/OJU6BuNlwTlf1UyFuk0hS0IPcxS/+2UclKYqRwzunp0 KXQrH1I+ rPJ87d+IlSn5QuHXtM9Ska/tp7SXJXIxtxPTf6Kta0BAt1QjySZhvolGP382QG5a2c8I2segoXL3uU7M= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, Nov 08, 2024 at 11:38:46AM -0400, Jason Gunthorpe wrote: > > > What I'm thinking about is replacing code like the above with something like: > > > > > > if (p2p_provider) > > > return DMA_MAPPING_ERROR; > > > > > > And the caller is the one that would have done is_pci_p2pdma_page() > > > and either passes p2p_provider=NULL or page->pgmap->p2p_provider. > > > > And where do you get that one from? > > Which one? The p2p_provider thing (whatever that will actually be).