From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31304D3ABF4 for ; Mon, 11 Nov 2024 21:28:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id B854E6B00AA; Mon, 11 Nov 2024 16:28:20 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id B0DDC6B00B1; Mon, 11 Nov 2024 16:28:20 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9D5A06B00B4; Mon, 11 Nov 2024 16:28:20 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id 804646B00AA for ; Mon, 11 Nov 2024 16:28:20 -0500 (EST) Received: from smtpin30.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id EC9DA81112 for ; Mon, 11 Nov 2024 21:28:19 +0000 (UTC) X-FDA: 82775101500.30.DB8D2DB Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf06.hostedemail.com (Postfix) with ESMTP id 27D4A180018 for ; Mon, 11 Nov 2024 21:27:49 +0000 (UTC) Authentication-Results: imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tX65SyWB; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731360323; a=rsa-sha256; cv=none; b=GCVm9rto2GKejHNnzeOLmq8fNbZgYNUoN5vfsycG7f05JBZsEuAyEmOkwgvpZnJTjH/cAi +3SDKE5uNGN3PdUDSPMazOJtb7rqKXjD4si0p6ZVzrAiZjijc9PGyxhsVwerkse166x2UZ nwnF3w+qU8Ev9jIKReqVW/7BufSEv9A= ARC-Authentication-Results: i=1; imf06.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=tX65SyWB; dmarc=none; spf=pass (imf06.hostedemail.com: domain of akpm@linux-foundation.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731360323; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=APw42YBxIk3oQzfthC3YJM5ctx90nl6NDsT+fWQX4oQ=; b=EMQQ0l4wpBjryEAjl0ba+VOmDClZ5etEC5QrVN7MpGn5hjjLzjFq6yr2euFsvp09BcAlcF xua6sBxYKEHb8dS18BCxz/qs7meBnI1IykBJYO+KyboJNBXtA48bYfDqIIefVE7bUc9vOz iyLpIZPm12cg/0gQanTLdiSirH1OmcA= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 2C80FA40C8C; Mon, 11 Nov 2024 21:26:23 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id EE69AC4CECF; Mon, 11 Nov 2024 21:28:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1731360497; bh=MKck0WUr9zrFyVFMoMvEBe3dlfrJSiXJMGBFvq360Ww=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=tX65SyWB6wVv47GbKniMWDNmqVNJczsuJLWohiA7q0kSPx93uoeltKz/wbbZRnemS 88IY7qlveQG4RCl1B986fdQWw+MWB2+CCwxbFG+eiDiMMIOLVXZ6ug0d08ozsHMUFs YzIhdR9buTrSfY3DQC5OxqMBVgC33cbFCK9EOc6E= Date: Mon, 11 Nov 2024 13:28:16 -0800 From: Andrew Morton To: Kemeng Shi Cc: willy@infradead.org, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH RESEND V2 0/5] Fixes and cleanups to xarray Message-Id: <20241111132816.3dcbb113241353e9a544adab@linux-foundation.org> In-Reply-To: <20241111215359.246937-1-shikemeng@huaweicloud.com> References: <20241111215359.246937-1-shikemeng@huaweicloud.com> X-Mailer: Sylpheed 3.7.0 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-Stat-Signature: nxwwn6i13dssi6g8eppn5gch37q5s63w X-Rspamd-Queue-Id: 27D4A180018 X-Rspamd-Server: rspam08 X-Rspam-User: X-HE-Tag: 1731360469-866465 X-HE-Meta: U2FsdGVkX19J1qt5WGAlGxEydf0IRPh0ab0LUenFNV8bxCLNFSqog/CRF4s//C1dO1i5CYfQJVRBqnMWZfY1VrNR3rAA93WjW5Yets7B+/3N/fQAMTLUY6VstUo5aGEOCA6zkM8dYP2/MdOwJQTGghJyfrQCjJ4LPbhiA/QhRoas2yFEKrF6kNlgN8Z8d4ACkMEpqQBBmcZGaKG+W2mZyxgxF139QzFXLd1yhMH/km/eU31eoWCKv3Ug2bodAYOu9HL80lNzhzJy1it9bw8lga0koWdt6rsIOsggjyejjp//BFDRHc0dPzsLQgPgYuj0n2OliZe6N6iO2q/BXNLNZRQgCtB/oYLbBxaYM22CFFPJIB1JdY/btmhtWOX6+4jAVcXtaN9C8lXFzllW5e+DDDkDhqWO+zdFyF3R0oBpi7HHVhKXE3CeDNTajxfVEbE4MSxe5oyS78UdYwF5knTGBEu6ZPMCf+hvoevQo75X48tJa90suWDhkiZhyBf9/+u5LCa/FAOEHmlYMqQnwsSQS0yWFAIqEjDut2hysxzj7N9dWbBwn7gggUcI61xSLNW7DaDdyj7Svx3dWCTdnOsmpfKIMhJEi0unAxDumc/hpOtCbYLHzQvwUl4R+wKAnJHc+NwZaGl7SvoPcPWnuEh4XRAmSDY5nACOpncdOuet/fJUHuEHn+S02C2cvGLgz5N9vYLRM/ZpqPmBDVCIivBzbuIfVH8742DM4MmIW7rnNrOhnUFoxGyml1DxxTlgvZHzv8JPVDtcAw8Ju4oVfIRs/L4IaGcUt/J/1k4axdcgGXp79iIzVY1Qq0ZoegO+I941cH0hbL0b4cOOlEHwTgOaUvkctfbLZS0PxT92Nk+3FNhAJB2LDHwFV2Pr/OhZOLH2CL89kMVwDbz0elOTu5wYn4LQvvxVBosMvDQXnFVHsI4zyvaRs8zvMUMX2I0bl+kRe53KZOavHB4PWGdSi3n 7mr98w/A b7GS58pbJsqs6m/mb883pj8cwcThZFoYFW/X8XLdjlI/IlzoWqaMUHFsd9dFo5R9NLP87dkAJQaqdFlcfHLj9yMzKQFuDSW3vZQeIfHjQ95snv4boIcgp2658E3xv4p+5OARdESf/yDoWFrOLuO3pxHTJA9VBqLJmnbiY1C2YsnNZJ69wZDevDQrcSPQJoVa6DlRQd5zQdkcE7EGYh+KX2deoidBQZy0T42ASoy4gA71w2q3tL1yb3nUkzLqFTzOlXeOzrzx3mSMtU9g= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Tue, 12 Nov 2024 05:53:54 +0800 Kemeng Shi wrote: > This series contains some random fixes and cleanups to xarray. Patch 1-3 > are fixes and patch 4-5 are cleanups. More details can be found in > respective patches. As we're at -rc7 I'm looking to stash low-priority things away for consideration after 6.13-r1. But I don't know if all of these are low-priority things. Because you didn't tell me! Please please always always describe the possible userspace-visible effects of all fixes. And all non-fixes, come to that. So. Please go through all of the patches in this series and redo the changelogs, describing the impact each patch might have for our users. If any of these patches should, in your opinion, be included in 6.12 and/or backported into -stable trees then it would be better to separate them into a different patch series. But a single patch series is acceptable - I can figure this stuff out, if I'm given the necessary information! Thanks.