From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 253CDD12D78 for ; Mon, 11 Nov 2024 06:39:38 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id ABFDB6B007B; Mon, 11 Nov 2024 01:39:37 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id A486D6B0083; Mon, 11 Nov 2024 01:39:37 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 8E9C06B0085; Mon, 11 Nov 2024 01:39:37 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0011.hostedemail.com [216.40.44.11]) by kanga.kvack.org (Postfix) with ESMTP id 72E8D6B007B for ; Mon, 11 Nov 2024 01:39:37 -0500 (EST) Received: from smtpin14.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 1B6A11C74AD for ; Mon, 11 Nov 2024 06:39:37 +0000 (UTC) X-FDA: 82772862816.14.0594FC5 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) by imf14.hostedemail.com (Postfix) with ESMTP id C66DA100004 for ; Mon, 11 Nov 2024 06:38:50 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731307034; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=oNsOYhwe3JW6hSfJ5efdvKMwFIkCKEG0xoFj9AtdPRE=; b=RnI87MxoZmGYGL5BjrnQdBZMvrFDsTCnFiDN4wazFcCBimwMh2Aiuy6WSMnoU45E4A1Gs/ MCjhUkk1ajUxNnS26RdEDfVYSvIXpIkI23eIkY/NUEbBwtcm5YZpvQBDKyN4dCa7tLY7q8 pfseFHuNDsjvoiFU61/dLJ9k6ENlQl4= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731307034; a=rsa-sha256; cv=none; b=tKmww7ndJ4qvVyu8YiP9zh1LokxzgDkMrQ2ZWqo1lS76cUATQc5hQFMiHyehuQ6dF4d4TJ alArxE4JZNFNJuIf6opcRmwBuVvwOX/kKN4CwREJHWMf/os3/QLyM6uCO+Th14LhNwIcs4 5FcDEKyzTGznpgqsO+DykPjZj0gdwmY= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf14.hostedemail.com: domain of hch@lst.de designates 213.95.11.211 as permitted sender) smtp.mailfrom=hch@lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 3F82B68C7B; Mon, 11 Nov 2024 07:39:32 +0100 (CET) Date: Mon, 11 Nov 2024 07:39:32 +0100 From: Christoph Hellwig To: Zhu Yanjun Cc: Leon Romanovsky , Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Leon Romanovsky , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 04/17] dma-mapping: Add check if IOVA can be used Message-ID: <20241111063932.GC23992@lst.de> References: <9515f330b9615de92a1864ab46acbd95e32634b6.1730298502.git.leon@kernel.org> <5ea594b3-7451-4553-92c1-2590c8baef20@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5ea594b3-7451-4553-92c1-2590c8baef20@linux.dev> User-Agent: Mutt/1.5.17 (2007-11-01) X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: C66DA100004 X-Stat-Signature: 6mn7gb7rww63xud4o8orx7czhh7ecziy X-HE-Tag: 1731307130-983971 X-HE-Meta: U2FsdGVkX1/VORaoIVkmuhjcvoOeQWam7CopvYVp5viTHb+2tmXz0TNTfyte48pJsRAZJYkHAskyzydFrVCvYAaDUZLxrmgpbEMuFMc4J6J5dV5JmtTOPhYJfeJL1RRmtOPJWbpDXAG6jkbT5h3PISJQj+2ttUHb/i/o2+Jc1ar0HWPIJEvb+FXjq9f1IGMJ8QVgrm95ZHBy2dBRmhnLoHeKlRz9HG44hfqUWWajO/TClGNBfxSohQJQVlwBsMrFwCfGOQeBlfjU4I/qfhApHAakBNO7MIcY60ZvPGangSr+FE2PbT0s7fo37VC14wSwFsLlXDgeSn/ZBLLNCVKoi8JirqE6fMMB66sP3ZHOdPOuJapqrvZhPLw50iv1pfB2CBEVHjdrGEZMxy9UcO/3fnNgOuKtoVTOyoDGOr7u9jB+BBXsuHsg+Qo5GY+yRpX/DaD0ja/xzJ71zyVabZQ/byjqbteeUxhMw6LTLOX+MUa6BlVSQDj1uc00412Uz6gZJH47pwOVOQgfdYiXVr9X/KKnu9bH9lyJoQLMa/twu1GY3eWmuHvXkZY9j6cbpXywT+/ccIr6JR2o4h2yGMz1QxM5LGaV7yPXgJVH1cjer/i9g8L7uuv7YNIwC/3PZkVa2sjIOiNoR1AVWUgEktNd29rXxk7HLT4ZOCQfIBPcEft7QAAeojK3PG31TFWewu1yF0UXzl4FpyTmEIVG4QW0iwDTeSVm5VZgY1LTezctB4E4zy2SJrc+76ylFssz5/ELEFQci6GdOmz4RBKQ6w5mM8CsY5XjYHv9Bc9l10iB34vEHfICjaFw5rYRbBacKuOFhR5d24Pg9KrDSvWyeLf4pOsb+FIHUDIc4hZxhuez5bV+0Q29o+aU4c3Il39xbYH0iR94akWZWR/ynJjuNXlbDyqaMGgozPk6Cx+1orZHq2lEHysw6P+DWeKKP0zC7YIl10h/KqFuvGvc1XuMARm tdEcickV xkipqcZxdSEhyQv4QNq0dKvYojaWtXnehECzNeygzyB9WhTD5Gb0b3/SGWokb8H/+Nnx1SI0LkWxsK3c= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 10, 2024 at 04:09:11PM +0100, Zhu Yanjun wrote: >> + >> +/* >> + * Use the high bit to mark if we used swiotlb for one or more ranges. >> + */ >> +#define DMA_IOVA_USE_SWIOTLB (1ULL << 63) > > A trivial problem. > In the above macro, using BIT_ULL(63) is better? No, and can people please stop suggesting it? That macro is so fucking pointless that it's revolting,