From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id E4D87D12D42 for ; Sun, 10 Nov 2024 15:19:49 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 749906B009B; Sun, 10 Nov 2024 10:19:49 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 6D1AB6B009D; Sun, 10 Nov 2024 10:19:49 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 54C066B009F; Sun, 10 Nov 2024 10:19:49 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0016.hostedemail.com [216.40.44.16]) by kanga.kvack.org (Postfix) with ESMTP id 30BE26B009B for ; Sun, 10 Nov 2024 10:19:49 -0500 (EST) Received: from smtpin21.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay04.hostedemail.com (Postfix) with ESMTP id B8E521A123C for ; Sun, 10 Nov 2024 15:19:48 +0000 (UTC) X-FDA: 82770543996.21.A9BEFC8 Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf30.hostedemail.com (Postfix) with ESMTP id CED0080010 for ; Sun, 10 Nov 2024 15:18:32 +0000 (UTC) Authentication-Results: imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OEubWIUH; spf=pass (imf30.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731251846; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=bZXP2yihv6IerTKJaFvhM4c7I5X+7QFebNGRQrBrpL8=; b=5hTWKoD+ytUYpsMM8jqCHdzhlDj6hgCa5BwRjB3xY+lweX27gOGN6giTtXTWs0yFhh2s+R mdMfz6cblifp3EGc6ktSmpJt12R6iz6Z54Agv4zmzzaW/7Igy9xoqFMrjWzwnHaQvrUMci bVXu26/jXCMtulb/Psf5uPD0fECfOao= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731251846; a=rsa-sha256; cv=none; b=pSptSlYh7Wnw0h0eV3xKwax5YDRjW3UFbW6b9ckbVqMCHvYVXcI0Jv0E6wV1NV48lmlPYB Jx2wusYkq5NPpjHdpcusjXueDj4I5XbPFNOV/9C5g3TdiXnh+VQSM8fT5O+6WkNDCryMjw m0RCg0eRIcyVymqlum58wZBPA7+P6Mk= ARC-Authentication-Results: i=1; imf30.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=OEubWIUH; spf=pass (imf30.hostedemail.com: domain of leon@kernel.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=leon@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 5D0A85C57BD; Sun, 10 Nov 2024 15:19:01 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 533D2C4CECD; Sun, 10 Nov 2024 15:19:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731251985; bh=+nLpqVqlmI0rwfYB+x9XOLb4b4JCkJV7DCNS7yvGo5Y=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=OEubWIUHaUCtjGJxYJ5nWYcTl4O7jXvmZxRC78OdoHXOSPdpN7Yve6E8unqrE3xw7 noGkSTSEj5WPLytJfdaJwps42VXBFU7yRdOMwjAgfBjhgBg0Dd/EC2D8tewNsUak80 h12aWQlWql/HCLFHYJOCSy2Bgc3Sbx2TdUGdPaz5txbu3gg84O+qg0yKH/aU32e81v 7eKJu7lxrjbuPwLHgJwoib4PK0Ffn2owR8TwOlpUaUruiqAVwpjo6Q1dbyJlxpXA3X 03rsXv5Mmeha22biNs41oOfjNv3RZB8IxRhyqfLwzMScjSb64oiAJc2mVMc/sMWUE8 X3YK8Swfv+C7Q== Date: Sun, 10 Nov 2024 17:19:38 +0200 From: Leon Romanovsky To: Zhu Yanjun Cc: Jens Axboe , Jason Gunthorpe , Robin Murphy , Joerg Roedel , Will Deacon , Christoph Hellwig , Sagi Grimberg , Keith Busch , Bjorn Helgaas , Logan Gunthorpe , Yishai Hadas , Shameer Kolothum , Kevin Tian , Alex Williamson , Marek Szyprowski , =?iso-8859-1?B?Suly9G1l?= Glisse , Andrew Morton , Jonathan Corbet , linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org, linux-block@vger.kernel.org, linux-rdma@vger.kernel.org, iommu@lists.linux.dev, linux-nvme@lists.infradead.org, linux-pci@vger.kernel.org, kvm@vger.kernel.org, linux-mm@kvack.org Subject: Re: [PATCH v1 04/17] dma-mapping: Add check if IOVA can be used Message-ID: <20241110151938.GA71181@unreal> References: <9515f330b9615de92a1864ab46acbd95e32634b6.1730298502.git.leon@kernel.org> <5ea594b3-7451-4553-92c1-2590c8baef20@linux.dev> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <5ea594b3-7451-4553-92c1-2590c8baef20@linux.dev> X-Rspam-User: X-Rspamd-Server: rspam12 X-Rspamd-Queue-Id: CED0080010 X-Stat-Signature: 4dr3zrwsxptqx3rn436qemej8h5ak6uf X-HE-Tag: 1731251912-38617 X-HE-Meta: U2FsdGVkX1/f1jPCMwbiovVb1w/RmSP1KwrTYZUCZlOI2jxRD1AJLgoikVhmy/pBscnarAWAPCrMWBAkkBGdFUtabjXvudOsLBKgBKgRdZhh4ToIqiu1kgnLx5MJfyWzpv/SWwbsxqkyBIN9GkIxwzB8QcbL9GPCaSm7T3UW0aS99jO1lr8pg3UXCzzeq/1CIIzikPOA/dh6SPs9hcJllq4genXbuwYIUSEDEoIReX4eSj2cBnsoBoxSh2ZbSNkzU4zeAHvNjS7jgvUMvdBlJHknCgXs++lE72BfWegzh1lA3pKd+NOc1hbqQqcAp9GLuL8ajjt/tuYVlHGOngC9dQeubxbGwGFh0u3MyuA93UNcr+NYOQLbfgDnJIoMcTlCLdltxEH/TqWaV9/MdXtsrkLbyhXShQsT177028x1I0MWKMBPj66ZHszMwkhrBsKkwxRr2wkjXRXmA5nOTPWDad/8pwDLuU21Q/xZmaB/RBtrIBBndxgy6etbTvnlmllkszEBX42tBqvCxovt1O1F+sB/FJxfE/n4fDqUN8SQYScIvxZ4jcX7N3nAUpz3hf13+Sr8rXaJluNhi22zYIHSPTBh5/HpFkCVCPvOjW97Mwp9uQMIYRU0cXAAOe9E7PgaXo0z4ihfwnwxFPPOvX+8Wrxw+s3kcuj8DMJ8yW328dvv+OKreaZ/gM80JfMJ3aFQZckiPXap+shpLgwANC3gaV2qXhHZXl9kp5+fPnTxcO/Vnq23icHUPwu6mqSAMDMWSW0+MyPR6Zoi0XoJoOvE8Mqj6s+HX9XsihZMXfBW/ohvPdMcgGQjgKXhc5C2xuIagTXL22CLeaBTBx8qYrnSdzDzcameXUrCRRvRqPbZycvcUsG+Kt8BUz+T4JlcCmo1i+bybrYC+eWqyBxZB3pxdvt41RiJgVB/ezFutWSJcd30yQLi9+diS5KJ1vlJesQn+A1WzT6/3ezE0N9IImF Mw+QCoUt aYaT5MwfSiRh1wklK5FE9LFRDNfGC6CVyh53hVe19ZcZtBifaEW2jrhzyuuIFgNMTEr4LfKbAa9BHktLFJCPpa3G4FWRlF0RGPQzKOcGUTkEAQ24cURNRJY0erhn82uuDBc+fg61Yw5IRbXZBIve2j6HzwZAYpJfwNmw0+ixZnHwERmdICYt2rYX+fqqh4KPSRQCe6/hlBbQBvUoq3kZ6H7esh4VzAb06nd9jWeyOmQPvvMwlaXvkCeoR7eFjXhcnR8MCXwdGbIowvT34/iYSELA4vcY4m3VMrScwVFGMV2F4fFqmdFpzfBhP/122I2KRlzOzYesoPjN2I/E= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sun, Nov 10, 2024 at 04:09:11PM +0100, Zhu Yanjun wrote: > 在 2024/10/30 16:12, Leon Romanovsky 写道: > > From: Leon Romanovsky > > > > This patch adds a check if IOVA can be used for the specific > > transaction. > > > > In the new API a DMA mapping transaction is identified by a > > struct dma_iova_state, which holds some recomputed information > > for the transaction which does not change for each page being > > mapped. > > > > Signed-off-by: Leon Romanovsky > > --- > > include/linux/dma-mapping.h | 33 +++++++++++++++++++++++++++++++++ > > 1 file changed, 33 insertions(+) > > > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > > index 1524da363734..6075e0708deb 100644 > > --- a/include/linux/dma-mapping.h > > +++ b/include/linux/dma-mapping.h > > @@ -76,6 +76,20 @@ > > #define DMA_BIT_MASK(n) (((n) == 64) ? ~0ULL : ((1ULL<<(n))-1)) > > +struct dma_iova_state { > > + size_t __size; > > +}; > > + > > +/* > > + * Use the high bit to mark if we used swiotlb for one or more ranges. > > + */ > > +#define DMA_IOVA_USE_SWIOTLB (1ULL << 63) > > A trivial problem. > In the above macro, using BIT_ULL(63) is better? You already asked same question and the answer is also the same. https://lore.kernel.org/all/20241103151946.GA99170@unreal/ > > Zhu Yanjun