From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id CC95CD5E39B for ; Sun, 10 Nov 2024 06:20:07 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DA3456B0082; Sun, 10 Nov 2024 01:20:06 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D52E76B0083; Sun, 10 Nov 2024 01:20:06 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C41A26B0085; Sun, 10 Nov 2024 01:20:06 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0013.hostedemail.com [216.40.44.13]) by kanga.kvack.org (Postfix) with ESMTP id A2E306B0082 for ; Sun, 10 Nov 2024 01:20:06 -0500 (EST) Received: from smtpin04.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay03.hostedemail.com (Postfix) with ESMTP id 1E0C6A137E for ; Sun, 10 Nov 2024 06:20:06 +0000 (UTC) X-FDA: 82769184456.04.6E0580F Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217]) by imf19.hostedemail.com (Postfix) with ESMTP id 940141A000E for ; Sun, 10 Nov 2024 06:19:15 +0000 (UTC) Authentication-Results: imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ciDAwooz; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731219374; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=tL2eRl5csW16vCH4rRx0/Vlxl10ZNnaGvoP6qWw5phg=; b=KE0g7VED4+oEdZTqlPuqn5mDDpWYC2S73YHMkfXw5EWDYxhCGrB7ohmuZcrbU3+/U66tKR nTs1VgNtpIWQ7M/A/zsJHiyYWX1Tf2+TuiZ1SHkHTwGRaXtTIi2kM8iJ4d1cUO4HA/MKTa sLTOpzlzh8x/qkfWb8y6wTcCZj7/XA4= ARC-Authentication-Results: i=1; imf19.hostedemail.com; dkim=pass header.d=linux-foundation.org header.s=korg header.b=ciDAwooz; spf=pass (imf19.hostedemail.com: domain of akpm@linux-foundation.org designates 139.178.84.217 as permitted sender) smtp.mailfrom=akpm@linux-foundation.org; dmarc=none ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731219374; a=rsa-sha256; cv=none; b=mE7UP6QMctIfUm8347hu/k60ln1THqJ2hsBAY/R/Wg0AibPs/PUA+Gdk/uSdP3PfC2hBf+ eiS7SZ82ibK6iDG88i+Z6jzdaca15k6vCgrxwnMR2pBeOWEgG9dPPNxxRaXbV07S4wKgxI Y8ZZall4kWi1wqAHPyAtMLfPFI37jkQ= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id AE63B5C4957; Sun, 10 Nov 2024 06:19:18 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6C4B9C4CECD; Sun, 10 Nov 2024 06:20:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1731219602; bh=tL2eRl5csW16vCH4rRx0/Vlxl10ZNnaGvoP6qWw5phg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=ciDAwoozsT++uHW1vmYRbx3D6iUintz/XeMvZv8HRwMv0foJiN/lOEaHdAEeyo+7H TzqWfqsap4ySh7lh+4m9lN3gTGRC8BWCxu1dz9BmyzA+SFaHwJ3DJ1HrwcSjsyQZsw nW9ipCax3ZPbGpNOBYffZNUmXR/MvF6uqg4sVn2Y= Date: Sat, 9 Nov 2024 22:20:01 -0800 From: Andrew Morton To: Muhammad Usama Anjum Cc: Donet Tom , Shuah Khan , kernel@collabora.com, linux-mm@kvack.org, linux-kselftest@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] selftests: hugetlb_dio: Check for initial conditions to skip in the start Message-Id: <20241109222001.f4272214f90c72458c1c09ec@linux-foundation.org> In-Reply-To: References: <20241101141557.3159432-1-usama.anjum@collabora.com> <5883b1c0-13c6-4593-9dd5-17f34c1319fe@linux.ibm.com> <13a96176-1bfa-4567-8ce5-a2b75b110afc@linux.ibm.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 940141A000E X-Stat-Signature: fd63emyat4dbf7tq67obbocfi311o4oo X-Rspam-User: X-HE-Tag: 1731219555-270992 X-HE-Meta: U2FsdGVkX1//8s7ktK0iW4zczP830x22q1qwucvGeoYue4gkuXdbAluK2hY4FgdSHQ085d3xpSyKDBozeMGKEP7yH8DATC3LPhBW6vf3WVMLU1ZN6DFH6WvnL/b+Zr0pXBxsQ7TN+SPmGRddV2qo7flHgmc2WVyui51tD8byxiUeAW1G+vle6igkpxGY/D2UuRAk8F0Z+PLnjAuylVzkXio50L0HF5YilUXazixX1AC1/aj3G8T80Ck8Q+bNxPhQK8TitiFmWBo1kvWESlSRSaTwYZsdiNSu7blH/ciECUTmrT++PjJF69re/YKCHGWtAhOrYxVDepv1yqoSYeuRwOQsrc/rpwDVRdsMEZbxdu+4QTJdsrFauwivstU80o0ykqHHOfUaZ0WLuRCuOTVDwb+tgK+UFu1GzFFQ20xr3ALm0RH/dX13+R39nDeGqCPNFl8qKnBRnzaMv/bHf8gqJL5vbZVS/tl2+NLhB3PKArLvO/IQig7F1AcmL064E0zUIYqTso2ATD4nPR+9vBhGvpep+2XWQqIIUHR9WSZ0cw5/VPVWOvYQ/t+AB6CX4X7ZBEPVdR3ezFSIz1jqPZF6TvnE7FONhinRNSU8u2zV5RkiyejJL7eURp1tKEYLq3pPBkq7WK0mk4nFhJs/KXGa52AWHGrTZ0hkt9GJwbvEPShDgDiHIUjMSTOhdeGIU536rNKREO8s/bCnKOtbAYRG9jwvbfQNQP/DMKuwJZ72a7e0Q/2sRqQgSOItVsgWuRB/I1gLGzgGeIppoOqMHJdE0bBVYr/zcbpwTKsCwf3pf3mb4i2iRuJ+HS8dUwOIyAnd3+/gERkRIVko3nYjLH+OCmJ1wwDGfoKxCw9wkfl2dm9YdcugjRTPr9xeZYV7d0xx5PA6Xmgt4OG5WEiMWWQz6Kran8sTh1YQ+aAYs8vJWW1EsmNrdsL2WwBqWKuUXLu2AO7nL9j3UvG2sZOgHq/ hgq7G1QC sfvAeHMNclbOR5/CIUUgYoLemVSK0E+Z1wslEKZ+bsOf69LnOPL/4qnK0oqT83YBNX0wgbEFM/1KG7FdlO2/hKINgHbZIfbB3tUONR42h9LmOg5vxmHNWbVRz9Mr/lpOtVhadI67iUqJGPAR+XoVN8CGd1Zs9sLLt9w4n59m3Z7gXtMXQkpy9aEmI5RY3DrCshnC4fb6s98HHotFSFl6AVVZEdxsCKj8CSFBVojdPToGGZrDUwMzEMW2QDvOb0HDD0TF+G1nid12U3MkD/jBJhW1DZTIApBfCf7A8LRZc6c8CdRf9y4BqI8E9EQJS26F8+WU6aBt1m5AoBHgETzFtAZCgRgAeMqVdjSLq X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Fri, 8 Nov 2024 19:13:04 +0500 Muhammad Usama Anjum wrote: > On 11/8/24 3:49 PM, Donet Tom wrote: >=20 > > I think below changes are required. > >=20 > > iff --git a/tools/testing/selftests/mm/hugetlb_dio.c b/tools/testing/se= lftests/mm/hugetlb_dio.c > > index 60001c142ce9..4b52106b8124 100644 > > --- a/tools/testing/selftests/mm/hugetlb_dio.c > > +++ b/tools/testing/selftests/mm/hugetlb_dio.c > > @@ -44,6 +44,9 @@ void run_dio_using_hugetlb(unsigned int start_off, un= signed int end_off) > > =A0=A0=A0=A0=A0=A0=A0 if (fd < 0) > > =A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0=A0 ksft_exit_fail_perror("Er= ror opening file\n"); > > =A0 > > +=A0=A0=A0=A0=A0=A0 /* Get the free huge pages before allocation */ > > +=A0=A0=A0=A0=A0=A0 free_hpage_b =3D get_free_hugepages(); > > + > > =A0=A0=A0=A0=A0=A0=A0 /* Allocate a hugetlb page */ > >=20 > > =A0=A0=A0=A0=A0=A0=A0 orig_buffer =3D mmap(NULL, h_pagesize, mmap_prot,= mmap_flags, -1, 0); > >=20 > > =A0=A0=A0=A0=A0=A0=A0 if (orig_buffer =3D=3D MAP_FAILED) { > Please can you send a fixup patch as you have working test setup? > Otherwise I'll take it up and try to test on working setup before > posting the fixup patch. Please let me know. I've removed this patch from mm-hotfixes-stable.