From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 07370D5E37F for ; Sat, 9 Nov 2024 20:52:39 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 16DA96B0092; Sat, 9 Nov 2024 15:52:39 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 11E976B0096; Sat, 9 Nov 2024 15:52:39 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F277F6B0099; Sat, 9 Nov 2024 15:52:38 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0010.hostedemail.com [216.40.44.10]) by kanga.kvack.org (Postfix) with ESMTP id D41156B0092 for ; Sat, 9 Nov 2024 15:52:38 -0500 (EST) Received: from smtpin27.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay08.hostedemail.com (Postfix) with ESMTP id 58DE21408B4 for ; Sat, 9 Nov 2024 20:52:38 +0000 (UTC) X-FDA: 82767753558.27.ED64FBF Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf14.hostedemail.com (Postfix) with ESMTP id 02763100003 for ; Sat, 9 Nov 2024 20:51:53 +0000 (UTC) Authentication-Results: imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FahV0Uy0; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731185386; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=upzhyvhbjDMrhjqJ9bX6cuugoljk288Ki3fPvusy9/E=; b=W8HdGDyXpn+iBDpO2MHa5MA7zZyRvLuTuqLNcKE+Vszpp3OmcZ2XhUfenJCp3H6PcmOd+a s48Kcv86C1QNsKtS95FOzMYpTZUNj30lHHnNkdmYKYa6OjQ+fe3a96TtZcdM8MkllIlXGO ljUP+JTtfFxMHh3yP4o03ZW+gGPtWm4= ARC-Authentication-Results: i=1; imf14.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=FahV0Uy0; spf=pass (imf14.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731185386; a=rsa-sha256; cv=none; b=Sj5b1Qp882D6fLhnaoFTJzDJtfj0vLI/AQifIRPg0GZAtga75Gv/d3h8iB7QHSSmLGvUZj 9B6GuGYC4E8+uw3hdaiQly27sGnJkYLdOYp7FKRVFV3juBwGysgm+OBmUUGFd3gvwnLwe0 h1F2KyXgS1TLZRXmgDP6LO902fOX30o= Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 3119DA404B2; Sat, 9 Nov 2024 20:50:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 33A71C4CECE; Sat, 9 Nov 2024 20:52:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731185545; bh=zdOeCmaMe34oEAA+P0JfFajw5QPzRbbfNWxey4/9g3M=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=FahV0Uy09KaUAf7sz8RZAmtap8BL37OG8OSYKIzEz7begyzkm0PlyeGms+SpJ3JUe EgYdPUqyEi2ztoXO/gy+onZdha/WJgKPLj52xnxRr6Surj1lob4OX8LcAYKxGoDUoJ j1aJJteDjw4XeeEF56jRhRMI1hn7yioFIb/zhZDRfutEjYuC6M/U318+v4EEfInPOg 9rlbnUL93GSpC0wqulyFW8gc5aJA0YsCRjGzJrgZEa014O18dFxDZ4E23jOXuEpUgT 6vSCGVOzz077Lgek1MiVbNMp/hEX/KIAXSR3X64xxrdrZOcDmTZN27g+Um7LzxXRwx g5UACP4WnbksA== From: SeongJae Park To: Joshua Hahn Cc: SeongJae Park , shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 2/3] memcg/hugetlb: Introduce mem_cgroup_charge_hugetlb Date: Sat, 9 Nov 2024 12:52:22 -0800 Message-Id: <20241109205222.88428-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: References: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam09 X-Rspamd-Queue-Id: 02763100003 X-Stat-Signature: sq9jpb986c7b88k94oq31npcykpfghre X-Rspam-User: X-HE-Tag: 1731185513-695958 X-HE-Meta: U2FsdGVkX1+EvsKAHN33G1+E6D4Ml1eK+nyrNZhv2XtaAyX52JffFw/lDzZwvf3vuxrJIPKEuVOuHemUE1PSENkMMdSTXmzDE2hb69B03Xo+94pm0zYF14kFBFCWg+WlilAFWbqT7qSFElS5grHpNOzVrc28mwcB4ZycS42jn3GT9fB12+hvcvSHNJaEbMlKmQx56zsRnz2myJoTUhwJOfdcLQNyOHmNf53WXwhSRe4ccgMddtWN7Gno9gZpGVzqcNez6hlIzdbbe+C+9HV70N1Yok+yx0iahXcXYcIh0/xMRayo5etuPOxkwTkYeJlvNCjIeZu5Q0l4vurHxRKEK5U6XJV0GzZqARNjU6xN+3fdy6xfqiqtq5flzO5cdqdcEJYV8rihF1lZUX2tIICqP8Yb7cDQvzU8oiUY7D2bhWNwmpkiP9Cja9yX9YuIv8aR99Py4EHgtMtxj7d1eXG+U+zaFwbIT6kaIXBxGdi3CdR5PoJT4P6AJgUvNcVlclg0e1GsqXsmIonLenW+kRMOhaRTtoJxz+oim6lXm8C1DtPOMYrjYVrBGNoiRlzuwUjTQSrOwGeQyAJMv+iO4jsCH5ypOnKpWM7SVWvGyobTxKXcD5ibXkUW5s6Cx9WFk9TtxPxLZPQu3uLf09lt9GToset3IMqghDy6bUdKeA7o9ydR/pznwO5nfDZ62VUC0hkHp8Zbw2xRd7/vjoXD8abCIelrwDJzUVUPfj21BTlDEoytC3NoFZbHa1L45G/gOVkzgtXpOhvwThU0INukw/4zd93HDh4UhRpyoA9bgDXpQfU5Icvh6T9zmh36e+21MLsH7AnLBMW5CnMSe18CcgIWux9XphgilDUAoOnCljtsJY4du9WCbDN5lT1WbXtqFzXOsH/3dftGwk2Au+QHZUKmFeDJesJGxe+sXRTNVFL59kWelIyLEHjVoykDmtPguWX8VCqpFaTITTfMrvgGk6b PU+PYY/J phhQ8gSI7+6Tfc4XZe3w9W43Pv1abLJ/7labqK3pf/ePtIV7C5Z2AnAeVqdQXUQo3vzeVuFAEVPy1if1vsfsSRsG2xEb/YEl0BueyBki9ukERRuhcUAYGDDAni5LHg7bNMsWPaQiV1wu2Ph+eoHiMWq8bqTKkhyxoyEUkzvrHeaU2jXjcTD74us+GEYdVEAgpTXY9UrdUHggQ8AlifruzPVfU+2MrhK8wiV8LC9jJX+6QSgaRzoGeB+3MNb59mM78Ne9Z575zXe3nulMzwHhNf7R929Cr5H5/zY+2h6KXUfr43JXaVCuVtD0yHgOci1o0C1TGp+yrwymxciLG3pBDOerIN5EQirpD7i2nyZmFzmq6Csn9yHh3yvo/ZAEPJbFHd6NksdQ9yOLW/Xg6ZY8n/BSyfo5yL8p7CF6i X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Sat, 9 Nov 2024 13:41:31 -0500 Joshua Hahn wrote: > Hello SJ, thank you for reviewing my patch! > > On Fri, Nov 8, 2024 at 8:03 PM SeongJae Park wrote: > > > > Hi Joshua, > > > > On Fri, 8 Nov 2024 13:29:45 -0800 Joshua Hahn wrote: > > > > > This patch introduces mem_cgroup_charge_hugetlb, which combines the > > > logic of mem_cgroup{try,commit}_hugetlb. This reduces the footprint of > > > > Nit. Seems the regular expression is not technically correct? > > I see, I will change it expand it out to include both. What I meant to > say is that it combines the functionality of both the functions, but > I think there was a typo there. I will just expand it out so that it is > more clear to readers! Thank you :) > > > > +int mem_cgroup_charge_hugetlb(struct folio *folio, gfp_t gfp) > > > > Can we add a kernel-doc comment for this function? Maybe that for > > mem_cgroup_hugetlb_try_charge() can be stolen with only small updates? > > Yes, I can definitely add a kernel-doc for this function. Would > you mind expanding on the "stolen only with small updates" part? > Do you mean that instead of writing a completely new section > in the kernel-doc, I can just change the name of the section > and modify small parts of the description? You're right. I just thought that might save some of your time if that makes sense. I don't really mind about this, so do whatever as you prefer :) Thanks, SJ [...]