From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4996AD64076 for ; Sat, 9 Nov 2024 01:03:21 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 7DA0E6B00A0; Fri, 8 Nov 2024 20:03:19 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 763BD6B00B5; Fri, 8 Nov 2024 20:03:19 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 546CA6B00BB; Fri, 8 Nov 2024 20:03:19 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0015.hostedemail.com [216.40.44.15]) by kanga.kvack.org (Postfix) with ESMTP id 1F4796B00A0 for ; Fri, 8 Nov 2024 20:03:19 -0500 (EST) Received: from smtpin08.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay05.hostedemail.com (Postfix) with ESMTP id 979994091A for ; Sat, 9 Nov 2024 01:03:18 +0000 (UTC) X-FDA: 82764756396.08.FB8C646 Received: from nyc.source.kernel.org (nyc.source.kernel.org [147.75.193.91]) by imf16.hostedemail.com (Postfix) with ESMTP id C3FC9180008 for ; Sat, 9 Nov 2024 01:02:39 +0000 (UTC) Authentication-Results: imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z+xYkVCO; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731114111; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=fCuWwW/KvR64YZajszY51VmIPTM8fu9Y0OjRPBboWQM=; b=M22g7O7DGLhtqwcHtBwEimjPsOn29NIaLvWj8yefDAIIySm+QTCObTJw0vbUqgcV+84BPN lEprHW/cM5zWr6qdwMfb/s9lURvlhF3qIyBZRNyhoP5xy0T4eFX7T1t8AZJTCpfcI1I1nG BuvadI8eoq/m00doSwlXlcnRjF3KNBg= ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731114111; a=rsa-sha256; cv=none; b=1hDgpF/k2kHwTMMD/xBmPBcHzheSApsl33M2NApIZHeQRVu6KnTsU+5JdzqaSP1mdHyGsK mv8FFPXNcQs0sVWfXBhY4Wa8a98Ag+1bNcP707xhvwHy0bQeyXdpRHnxDv/Gjanpx3jPbr b27MfMxlTPLihMY+vWbSeOcF4TwjR4Q= ARC-Authentication-Results: i=1; imf16.hostedemail.com; dkim=pass header.d=kernel.org header.s=k20201202 header.b=Z+xYkVCO; spf=pass (imf16.hostedemail.com: domain of sj@kernel.org designates 147.75.193.91 as permitted sender) smtp.mailfrom=sj@kernel.org; dmarc=pass (policy=quarantine) header.from=kernel.org Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by nyc.source.kernel.org (Postfix) with ESMTP id 7AE46A4521A; Sat, 9 Nov 2024 01:01:21 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8946C4CECD; Sat, 9 Nov 2024 01:03:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1731114195; bh=1dSZzFv9gjZ3IpUjNzhwfDSwFdOHj6V1+qdMKNvcbD8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Z+xYkVCOiU5+M26HAGC7DG6u5Ie9AMnuq7R1FImR6FsnzbkF+f562hQmMg+LgdObJ c6tAZTzKluIkcSafKJq7DVoTKfrjAQ9GSNZPLwbbhe1OPjtVNHUYpAwvWhyUPrYX3B 53SHbZ8/NM3Iq6ainLaJgdwZ0qVrvpEPLT7/biY4FLsqN6EAKFTaEIHu2OLa73an9C 9UMrayu7e8cd+MQeRgT4vWuVVPa6Z/OgYJI8dyfaHTrVMJfv2RIxKNxGhpSZoqPHsS GjJywuhd4eA748fN+ASwD/ihtkQpSZuueR568ikCmiULopVIN2DaKh6wgLUu/3H5IS WLuQgv11QRmkQ== From: SeongJae Park To: Joshua Hahn Cc: SeongJae Park , shakeel.butt@linux.dev, hannes@cmpxchg.org, mhocko@kernel.org, roman.gushchin@linux.dev, muchun.song@linux.dev, akpm@linux-foundation.org, cgroups@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, kernel-team@meta.com Subject: Re: [PATCH 2/3] memcg/hugetlb: Introduce mem_cgroup_charge_hugetlb Date: Fri, 8 Nov 2024 17:03:07 -0800 Message-Id: <20241109010307.74840-1-sj@kernel.org> X-Mailer: git-send-email 2.39.5 In-Reply-To: <20241108212946.2642085-3-joshua.hahnjy@gmail.com> References: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspamd-Server: rspam10 X-Stat-Signature: hp3pmmxjackkm61xkj7youyuo1zimngc X-Rspamd-Queue-Id: C3FC9180008 X-Rspam-User: X-HE-Tag: 1731114159-339163 X-HE-Meta: U2FsdGVkX18Rg3iHsYkGLwdeqRBXKfJnbknd+6WwmsIoLfJ1ESjFYcffNeXBiXjhF7TTiibp+7dWHSbci3VXaMajhj8Hlj1UZnoTevhcyGcOovmIBJIZwMnhOm1noXG0XYNhpqTFa6qd3sCdMTUwKMD8qM/NkVrQXJmIiGVlbkIUBNAoug4PLWeiUdeMBjBH/iL0/KpHQqi4ZE38CcQXi02YnDRg/846w5JaipWx6+IMQZHL2PaIiO+aBF1ErDbWEJ5q0K+sOcS8p7LU79T4+WYMn4BqvwMq467fEWcfjafvlSFYOs4zafh/91ReTw34TThfTGn+gJhbIyXgA+BwrWCh30PtLYBepgv3ybm30q+RKauSf0UC2PoUiF8mI6KD1LJi0gfSABnXhyTCeX+PtF+Vut7PJ0xNykTaC39rAqHX/vhJJmfFFOiIgOdl93QQL8kJBrz59vnbLOPQSbll/C85vGauXUCSJnpNZj/+pvUvLmx3t8IUvD+l7M/Bj4nxjW6ZlKVlc0rm3BNpluPkJajf/GaRz/AR5Ev2pHvoeebHZb2WtmPoOwvsOZp3+t6Mz0BW+g43nsolh/U34DHo75r2YnlRQUM4tRtfT99CZx/UMsZMD+mgdpItSyPACDOn+4nzd0nneP2tAZo+UNKL/Mxj+k84ok2X5+KQIGjkW76VXRDkRRC0z0HYd6+8xulDOJx6afpbULOLULxB2RyAAOsuYD5LOm3MTfA+HdAhRCg8rW/85PlY/nB3MvWovVUDJj5lcvUWuPUO1eHkXj4DC078Md6HOFL9AvjPE8ufHUxPY3MKpFU30iLoIwH9Lf8/05L3PZni0ZXdExCD1nt2AL7+71W82cW8bxYqckXQ2gsvf9CUGSbSWjVc7qPlOPGKYykCT/pPMnOPcwTzKu7e2no1UBD8qsa4rCXBCcdERcZX7WvjIyWmo255DgBN7R1zP9uLV5VFYHfLcZUdzsv uzxAcZoT 9mNYwcQ5pGyiQimTcyFGsdv4HJ9ttyfgtEt1MdSK5DLXqQllW6Wj/+b68CH+l4JqMHjZeQlD+V5BXLpT4UQh93RfGEczok7X9tgIezA/n8CrH/2km63JOrtsFKkPVTqawI20jXXDEhDN+zkXZPjauIUMYzFMCnFUDRCa47Q1c71CRfu3EU+GaNOGbUKGlrPtN6f8zlZnb+Di4zTF82EXrCGh/y2nw6VhB917x5iRxzd2YM66Wgq+OJxAhnTRwJEwaqEwXPAxtsXiArczZnfAb3BuCBb5xk6/JbijZdpAjxUfaxCCONOWLRtsdQxmV3D84fUjFW5RBiTA48PphRSKe+mj1aKO5WF5ZVvn2 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: Hi Joshua, On Fri, 8 Nov 2024 13:29:45 -0800 Joshua Hahn wrote: > This patch introduces mem_cgroup_charge_hugetlb, which combines the > logic of mem_cgroup{try,commit}_hugetlb. This reduces the footprint of Nit. Seems the regular expression is not technically correct? > memcg in hugetlb code, and also consolidates the error path that memcg > can take into just one point. > > Signed-off-by: Joshua Hahn > > --- > include/linux/memcontrol.h | 2 ++ > mm/hugetlb.c | 34 ++++++++++++---------------------- > mm/memcontrol.c | 19 +++++++++++++++++++ > 3 files changed, 33 insertions(+), 22 deletions(-) [...] > diff --git a/mm/memcontrol.c b/mm/memcontrol.c > index 97f63ec9c9fb..95ee77fe27af 100644 > --- a/mm/memcontrol.c > +++ b/mm/memcontrol.c > @@ -4529,6 +4529,25 @@ int mem_cgroup_hugetlb_try_charge(struct mem_cgroup *memcg, gfp_t gfp, > return 0; > } > > +int mem_cgroup_charge_hugetlb(struct folio *folio, gfp_t gfp) Can we add a kernel-doc comment for this function? Maybe that for mem_cgroup_hugetlb_try_charge() can be stolen with only small updates? > +{ > + struct mem_cgroup *memcg = get_mem_cgroup_from_current(); > + int ret = 0; > + > + if (mem_cgroup_disabled() || !memcg_accounts_hugetlb() || > + !memcg || !cgroup_subsys_on_dfl(memory_cgrp_subsys)) { > + ret = -EOPNOTSUPP; > + goto out; > + } > + > + if (charge_memcg(folio, memcg, gfp)) > + ret = -ENOMEM; > + > +out: > + mem_cgroup_put(memcg); > + return ret; > +} > + > /** > * mem_cgroup_swapin_charge_folio - Charge a newly allocated folio for swapin. > * @folio: folio to charge. > -- > 2.43.5 Thanks, SJ