From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 1CBA1D64099 for ; Fri, 8 Nov 2024 23:29:22 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 9E4C26B00AD; Fri, 8 Nov 2024 18:29:21 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 9931C6B00CC; Fri, 8 Nov 2024 18:29:21 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 859EF6B00CD; Fri, 8 Nov 2024 18:29:21 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0014.hostedemail.com [216.40.44.14]) by kanga.kvack.org (Postfix) with ESMTP id 642EC6B00AD for ; Fri, 8 Nov 2024 18:29:21 -0500 (EST) Received: from smtpin24.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 135501C6CF6 for ; Fri, 8 Nov 2024 23:29:21 +0000 (UTC) X-FDA: 82764520230.24.EBA6D21 Received: from mail115-79.sinamail.sina.com.cn (mail115-79.sinamail.sina.com.cn [218.30.115.79]) by imf09.hostedemail.com (Postfix) with ESMTP id 08AFF140007 for ; Fri, 8 Nov 2024 23:28:51 +0000 (UTC) Authentication-Results: imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of hdanton@sina.com designates 218.30.115.79 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731108474; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sbqnw+YP9qlRJd5I+77XH+bZzDt9zoLp6AnYr0PYYFs=; b=tcb3+MBUPYkbUfjfmVryGuPMso1BGKACfObQsIFlqeFNA2RBmBJoRQi620QBPkjw2xKJD1 qRHLnTeCm+wfsKJfSVo+vXmianHIS+Yl8pfju5wh67d5Zud3Ln52gBceGjYvBbQvJYA9Hr KJ9ICEPxhY1cIClabGdTYpRAGtiyR9Q= ARC-Authentication-Results: i=1; imf09.hostedemail.com; dkim=none; dmarc=none; spf=pass (imf09.hostedemail.com: domain of hdanton@sina.com designates 218.30.115.79 as permitted sender) smtp.mailfrom=hdanton@sina.com ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731108474; a=rsa-sha256; cv=none; b=3ACFAYHi4h3nTttK21DwCnUaNltPP5D5K8NzO8EsyBj+Cxb/jEk1WP9zpFjatOXn4PkVKS Dh/Km0YQ8CihUaBKHQgTKZel/qDxXvRO1+/KqlbhfjB81gHewd+DyuV4c0UM6nVa2PQteq Mll09pUrnrjMcvfofWbtt+UL/vQ0+Wk= X-SMAIL-HELO: localhost.localdomain Received: from unknown (HELO localhost.localdomain)([116.24.10.37]) by sina.com (10.185.250.22) with ESMTP id 672E9EC500002876; Fri, 9 Nov 2024 07:29:13 +0800 (CST) X-Sender: hdanton@sina.com X-Auth-ID: hdanton@sina.com X-SMAIL-MID: 1008147602647 X-SMAIL-UIID: A42BBD2DC59F46A78B6BCC9E5FA1A1AA-20241109-072913-1 From: Hillf Danton To: syzbot Cc: Johannes Weiner , linux-kernel@vger.kernel.org, linux-mm@kvack.org, syzkaller-bugs@googlegroups.com, Kairui Song , Daan De Meyer Subject: Re: [syzbot] [mm?] general protection fault in swap_reclaim_full_clusters Date: Sat, 9 Nov 2024 07:29:01 +0800 Message-Id: <20241108232901.3631-1-hdanton@sina.com> In-Reply-To: <20241107142335.GB1172372@cmpxchg.org> References: <672ac50b.050a0220.2edce.1517.GAE@google.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Rspam-User: X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 08AFF140007 X-Stat-Signature: 61h45usm4se5fy136nbunb8e6zro115d X-HE-Tag: 1731108531-383985 X-HE-Meta: U2FsdGVkX1+kHlTpaf34ZXdaOTYL5kNJopBblKVQHgoXLyYDUhySD8yBY6vJ184l1siC1+fDbNODzttmzSHAw2tzQmH/1jzbAMMJMdv29gfdjs9bD2xGslYXkiYB1HmQkjLzva3pY4hw2SCqHUkCTFByEykqnVKNl/hezSAT5lXYU5q93eHlz2FoZJAopGhciMbYFB7o/75gMoyikTExWg+h7/0yi67oZQQq9nzSYR1ZIzyC7/WWhALeYVAQJLz7qNV6DzNhg/iHKTQjwQsKV/vvEZSFvvryeUQdpTV+rX+3QV0fujxhThwz4lx/CfngcJqq6ulzrLpHhDF6JZLqtG2sAwBBNc7HsFrG1Z3aQo421TZcWajaYD9fxmlCduuy2k36JbabJcMr7bt4iF84eJ67zPjeoSlH7z8uBaT0WVDydT8EuFxErCjOjIyfNGTwNaHuQui4yigrSFKWSnqxFgzmSTtNWDXhmOzrTJfQYM0PE8VTmOt/+CIM7Na7vi1smcut4LuF6MKLO30oTx93tgmOZE0HpWRg465QEoBvlgK5Xu5vlKLFo+PCvVTrBVS4iQEwK0l+1Oo77HQNcS+Ne7HivEWKbCcUhDjFundnUCQUnThJJ+EvBAdxqTxBVR4l1FWQvjJOIGSbGMk/6zvYfh1HQrtBV+Dyp3rpem81N/59ieABan/KNPQ0DWW5s/linVZ3mrnKWGeFqO8ieqg28SoA3fGg4myhqX9Hh8dL9Wvn83Lrm8zJaDp3DXm/p4RDzBOz6CZuomvE6mcD4lEwSZ7VkYt/RhYEroIcI9FK85dCEBu5gU+9Sq1UIk2ELLG08MztWYHb9eJhEpP9KHtrCafGzQHh/NXw88n3lIz+L/t1bbzAtrJbpQhR317s9WtK8kT1nCthgrLFne26Nbzlcy9PkECKmdJ1Q5oRY2ijX0pQRQB/5o1GPwdW15DByalNqEeo5f9PcJL8S11OYVm MDlR0M1s D9h2k0oUxadJAYbGzzVvuCwl3QAJWP6yBFm8PDbXffUYpQ+Z98y376fqEupLFeDwvw23kcHt1YuuUZDABck66aiS3iwHmeSuimx0Ooa+oYnD2EH1ShLLReutPR14RZ5CoX8GzRBfMZ/85s7tkQw4ExrjkCnGMrr61yzY34YFi5XPbBtrijgtTi4WddK6W9BmTRL1MgSrK5Co3QteVUXgcSb5Iqliqx2z+rNGWyxZlMPLq4KLQd0iA7cDu4klfSkPcfRRiQuit7sjjhV/l7W4fjysmCnbScV18kecm7QPv3k9wIGsSZlpGjqh+AqXWb/5fJ7Hk6PyviAuRsKm9lorb4gbcrh3nzYG2DLfmYSf4HFeisX1o8kIOMbBG/T8pNdUPPuSqDbnrZJf0bUTMwSMR96CfDXDcMhqc2Y4XlXuBCV3XNWyCT92PIMusK2Ly7Tzfu+3XL4oo2YbPT1/AZvSDX4dHW3J8jAA+/sErd8v+b2LqsyapRHhb3AZH2JNd8z6TA2yhXwzzsD9vpN45eJcsgbNVqnbHWKVn+Kdb1OcYlibM25kvmuwq6v3vx4IJ2ylWCsfQPcXFrGuZktKhTIFqumZQZx6rFD3kVlCd23NJM/8/cmNfNYDC1B3jX4hs4DFwiJ3Z4R/GTYA5KcxyG6Uy77Klom3qPfUV6K0ezGZiVhvMukNfifOoSdqlTQ== X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Thu, 7 Nov 2024 09:23:35 -0500 Johannes Weiner > On Tue, Nov 05, 2024 at 05:23:23PM -0800, syzbot wrote: > > Hello, > > > > syzbot found the following issue on: > > > > HEAD commit: 59b723cd2adb Linux 6.12-rc6 > > git tree: upstream > > console output: https://syzkaller.appspot.com/x/log.txt?x=1076c740580000 > > kernel config: https://syzkaller.appspot.com/x/.config?x=b77c8a55ccf1d9e2 > > dashboard link: https://syzkaller.appspot.com/bug?extid=078be8bfa863cb9e0c6b > > compiler: gcc (Debian 12.2.0-14) 12.2.0, GNU ld (GNU Binutils for Debian) 2.40 > > syz repro: https://syzkaller.appspot.com/x/repro.syz?x=167aa1f7980000 > > C reproducer: https://syzkaller.appspot.com/x/repro.c?x=110d86a7980000 #syz test The syzbot console output indicates a virtual environment where swapfile is on a rotational device. In this case, clusters aren't actually used, and si->full_clusters is not initialized. Daan's report is from qemu, so likely rotational too. Make sure to only schedule the cluster reclaim work when clusters are actually in use. Link: https://lore.kernel.org/lkml/672ac50b.050a0220.2edce.1517.GAE@google.com/ Link: https://github.com/systemd/systemd/issues/35044 Fixes: 5168a68eb78f ("mm, swap: avoid over reclaim of full clusters") Reported-by: syzbot+078be8bfa863cb9e0c6b@syzkaller.appspotmail.com Reported-by: Daan De Meyer Signed-off-by: Johannes Weiner --- mm/swapfile.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/swapfile.c b/mm/swapfile.c index 46bd4b1a3c07..9c85bd46ab7f 100644 --- a/mm/swapfile.c +++ b/mm/swapfile.c @@ -929,7 +929,7 @@ static void swap_range_alloc(struct swap_info_struct *si, unsigned long offset, si->highest_bit = 0; del_from_avail_list(si); - if (vm_swap_full()) + if (si->cluster_info && vm_swap_full()) schedule_work(&si->reclaim_work); } } -- 2.47.0