From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org
Cc: "Paul E. McKenney" <paulmck@kernel.org>,
Boqun Feng <boqun.feng@gmail.com>, Marco Elver <elver@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Tomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com,
longman@redhat.com, penberg@kernel.org, rientjes@google.com,
sfr@canb.auug.org.au,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Subject: [PATCH v3 3/4] scftorture: Move memory allocation outside of preempt_disable region.
Date: Fri, 8 Nov 2024 11:39:33 +0100 [thread overview]
Message-ID: <20241108104217.3759904-4-bigeasy@linutronix.de> (raw)
In-Reply-To: <20241108104217.3759904-1-bigeasy@linutronix.de>
Memory allocations can not happen within regions with explicit disabled
preemption PREEMPT_RT. The problem is that the locking structures
underneath are sleeping locks.
Move the memory allocation outside of the preempt-disabled section. Keep
the GFP_ATOMIC for the allocation to behave like a "ememergncy
allocation".
Tested-by: Paul E. McKenney <paulmck@kernel.org>
Signed-off-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
---
kernel/scftorture.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/kernel/scftorture.c b/kernel/scftorture.c
index 654702f75c54b..e3c60f6dd5477 100644
--- a/kernel/scftorture.c
+++ b/kernel/scftorture.c
@@ -320,10 +320,6 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra
struct scf_check *scfcp = NULL;
struct scf_selector *scfsp = scf_sel_rand(trsp);
- if (use_cpus_read_lock)
- cpus_read_lock();
- else
- preempt_disable();
if (scfsp->scfs_prim == SCF_PRIM_SINGLE || scfsp->scfs_wait) {
scfcp = kmalloc(sizeof(*scfcp), GFP_ATOMIC);
if (!scfcp) {
@@ -337,6 +333,10 @@ static void scftorture_invoke_one(struct scf_statistics *scfp, struct torture_ra
scfcp->scfc_rpc = false;
}
}
+ if (use_cpus_read_lock)
+ cpus_read_lock();
+ else
+ preempt_disable();
switch (scfsp->scfs_prim) {
case SCF_PRIM_RESCHED:
if (IS_BUILTIN(CONFIG_SCF_TORTURE_TEST)) {
--
2.45.2
next prev parent reply other threads:[~2024-11-08 10:42 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-08 10:39 [PATCH v3 0/4] scftorture: Avoid kfree from IRQ context Sebastian Andrzej Siewior
2024-11-08 10:39 ` [PATCH v3 1/4] scftorture: Avoid additional div operation Sebastian Andrzej Siewior
2024-11-08 10:39 ` [PATCH v3 2/4] scftorture: Wait until scf_cleanup_handler() completes Sebastian Andrzej Siewior
2024-11-08 10:39 ` Sebastian Andrzej Siewior [this message]
2024-11-08 10:39 ` [PATCH v3 4/4] scftorture: Use a lock-less list to free memory Sebastian Andrzej Siewior
2024-11-08 17:46 ` [PATCH v3 0/4] scftorture: Avoid kfree from IRQ context Boqun Feng
2024-11-08 18:33 ` Paul E. McKenney
2024-11-08 18:45 ` Sebastian Andrzej Siewior
2024-11-08 19:01 ` Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108104217.3759904-4-bigeasy@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=cl@linux.com \
--cc=elver@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=paulmck@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox