From: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
To: Boqun Feng <boqun.feng@gmail.com>
Cc: kasan-dev@googlegroups.com, linux-kernel@vger.kernel.org,
linux-mm@kvack.org, "Paul E. McKenney" <paulmck@kernel.org>,
Marco Elver <elver@google.com>,
Peter Zijlstra <peterz@infradead.org>,
Tomas Gleixner <tglx@linutronix.de>,
Vlastimil Babka <vbabka@suse.cz>,
akpm@linux-foundation.org, cl@linux.com, iamjoonsoo.kim@lge.com,
longman@redhat.com, penberg@kernel.org, rientjes@google.com,
sfr@canb.auug.org.au
Subject: Re: [PATCH v2 3/3] scftorture: Use a lock-less list to free memory.
Date: Fri, 8 Nov 2024 11:32:52 +0100 [thread overview]
Message-ID: <20241108103252.4EVzazwC@linutronix.de> (raw)
In-Reply-To: <Zy0m5TBz3Ne55syG@Boquns-Mac-mini.local>
On 2024-11-07 12:45:25 [-0800], Boqun Feng wrote:
> > @@ -538,6 +567,8 @@ static void scf_torture_cleanup(void)
> >
> > end:
> > torture_cleanup_end();
> > + for (i = 0; i < nthreads; i++)
>
> This needs to be:
>
> for (i = 0; i < nr_cpu_ids; i++)
>
> because nthreads can be larger than nr_cpu_ids, and it'll access a
> out-of-bound percpu section.
And I though I learned my lesson last time.
Thank you.
> Regards,
> Boqun
Sebastian
next prev parent reply other threads:[~2024-11-08 10:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-07 11:13 [PATCH v2 0/3] scftorture: Avoid kfree from IRQ context Sebastian Andrzej Siewior
2024-11-07 11:13 ` [PATCH v2 1/3] scftorture: Avoid additional div operation Sebastian Andrzej Siewior
2024-11-07 11:13 ` [PATCH v2 2/3] scftorture: Move memory allocation outside of preempt_disable region Sebastian Andrzej Siewior
2024-11-07 11:13 ` [PATCH v2 3/3] scftorture: Use a lock-less list to free memory Sebastian Andrzej Siewior
2024-11-07 18:31 ` Paul E. McKenney
2024-11-07 20:45 ` Boqun Feng
2024-11-07 21:53 ` Paul E. McKenney
2024-11-08 10:32 ` Sebastian Andrzej Siewior [this message]
2024-11-07 15:27 ` [PATCH v2 4/3] scftorture: Wait until scf_cleanup_handler() completes Sebastian Andrzej Siewior
2024-11-07 19:05 ` [PATCH v2 0/3] scftorture: Avoid kfree from IRQ context Paul E. McKenney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241108103252.4EVzazwC@linutronix.de \
--to=bigeasy@linutronix.de \
--cc=akpm@linux-foundation.org \
--cc=boqun.feng@gmail.com \
--cc=cl@linux.com \
--cc=elver@google.com \
--cc=iamjoonsoo.kim@lge.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=longman@redhat.com \
--cc=paulmck@kernel.org \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=sfr@canb.auug.org.au \
--cc=tglx@linutronix.de \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox