From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8E4C0D5D67D for ; Thu, 7 Nov 2024 17:31:33 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 0F6F36B007B; Thu, 7 Nov 2024 12:31:33 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0A6C76B0083; Thu, 7 Nov 2024 12:31:33 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id EB04D6B0085; Thu, 7 Nov 2024 12:31:32 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (smtprelay0012.hostedemail.com [216.40.44.12]) by kanga.kvack.org (Postfix) with ESMTP id CD7506B007B for ; Thu, 7 Nov 2024 12:31:32 -0500 (EST) Received: from smtpin09.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay01.hostedemail.com (Postfix) with ESMTP id 794CB1C6146 for ; Thu, 7 Nov 2024 17:31:32 +0000 (UTC) X-FDA: 82759988850.09.B253074 Received: from mail-qv1-f41.google.com (mail-qv1-f41.google.com [209.85.219.41]) by imf10.hostedemail.com (Postfix) with ESMTP id 7D17FC0007 for ; Thu, 7 Nov 2024 17:31:14 +0000 (UTC) Authentication-Results: imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=EjARuGIA; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=hostedemail.com; s=arc-20220608; t=1731000504; h=from:from:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:content-transfer-encoding: in-reply-to:in-reply-to:references:references:dkim-signature; bh=/52dHnIzYVGUdsWhfYMIa1Gi94aRC9NLX3XTIQyp/vE=; b=6TFqrCznCWqhjERf0SDMKBXnibgs/qVQquhbPrVsLyYXdqMORNk/Z7wyTSwXWL5jakWwVB wRErh+jtSKWu8dzxV71k0WtGtBl8TZToOwPrwbIoQzrOaNK58s0m3smNBn65hdKsK9f2Sk jBQnrBxBc5OdS1PV+gPSbx1RbN3wGOQ= ARC-Authentication-Results: i=1; imf10.hostedemail.com; dkim=pass header.d=cmpxchg-org.20230601.gappssmtp.com header.s=20230601 header.b=EjARuGIA; spf=pass (imf10.hostedemail.com: domain of hannes@cmpxchg.org designates 209.85.219.41 as permitted sender) smtp.mailfrom=hannes@cmpxchg.org; dmarc=pass (policy=none) header.from=cmpxchg.org ARC-Seal: i=1; s=arc-20220608; d=hostedemail.com; t=1731000504; a=rsa-sha256; cv=none; b=1SJZBshEvLsszIkjVnVFJGNthUfIQGjULhQVnjrg9S0vmjHrJLx8p45G1aquOHSFOucIBb K7ozrv2s+3hs6Xg76OaL6iNcaiLx8ngreD+gjho8C+HgSOKZc6ritJ3/WufRDh9gXDoelv Bw7o7rHNrldZgAWe6V6R0Tf3b7e4ync= Received: by mail-qv1-f41.google.com with SMTP id 6a1803df08f44-6cbe9914487so7776316d6.1 for ; Thu, 07 Nov 2024 09:31:30 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=cmpxchg-org.20230601.gappssmtp.com; s=20230601; t=1731000689; x=1731605489; darn=kvack.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=/52dHnIzYVGUdsWhfYMIa1Gi94aRC9NLX3XTIQyp/vE=; b=EjARuGIAb/1nXZBNrw7r3vEXKfjqvLam2Z4/Er2TUgLNkjW+tXfaLv8ibcC+XkZfDO HUBHeKOxmupnAqFM6ddSvYjybE+o7JbkFkief3hfF6GXz2XTyn9nqUcpiX+IWjP5r6/9 RbXqMJlrmDPgageMpRAxMQcahQtA0NAnDkEilnh8IBwuqwCt4fLXrsfFVT2buZjOWcG/ gPH98vIryROr8zV4n3VVJtEzSXWcr1k+294WVi9xDe24Qbql8/umcCQVjZmvbRK4cWa6 90U49qXloEjPqgDem3ODH/RlQ9tLQUgLtVQoKucBPePCPLw/hlKtfKV+2UZ+xZl2+gJI ZG8Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1731000689; x=1731605489; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=/52dHnIzYVGUdsWhfYMIa1Gi94aRC9NLX3XTIQyp/vE=; b=pQPRJvKmWBPOvuCiAKk+zpKkddC+S6f3eT3efQ+k+ft9YH9oZImlm7eK0XLAQegQ1X o25HjH9Pk2omKcmPaJQFEebqNVAAqC+TmDBCXXXd8c2ZLhFBCdXmuJ9ezRXq/fZBeVoB u44zyPPRY6FYYblvIyYvOwg1/M4IB1P37e95LGqJl5kvxVQY1R/iYMmVr6IR+G1lEUxN OSJhyZisyAj1X10BC8UEuCDTKpYmJSSRtE/S/aOJlIBCy2n1PIluacozwx5ms2i6IwKK o6WAyi4+IV9bkTgIVcH+NL4jaySTHhZcYtn4esGtk/ZV0hYRevDS1IyVyAyf+Xybzp8Z n4kQ== X-Forwarded-Encrypted: i=1; AJvYcCUkZeyBx84mkphAAciEyvkbOoOcENv7Z7v+Kk1vOG1I8erekuGS+zL6OByf32YR88hXAzt7cwM8xA==@kvack.org X-Gm-Message-State: AOJu0YyGNfH8bXVb6BHwsBMGcRrYE5Q1BeXhmSajQ3NefRSCpusLoMim ht8v8+dv1yUqNrpP8ahIjAOu1iURVUDper+A7HQFY7B3lqPbhEzJsJk2TWQ0fDo= X-Google-Smtp-Source: AGHT+IEZ6SHobqwmBLku5T22g3qb1tqmYJPcUGBA8+Da3y8UJVplvgda5z5x27uRTa0Tc+2qWv1/fg== X-Received: by 2002:a05:6214:329:b0:6d3:9dad:6869 with SMTP id 6a1803df08f44-6d39dad6888mr801246d6.16.1731000689463; Thu, 07 Nov 2024 09:31:29 -0800 (PST) Received: from localhost ([2603:7000:c01:2716:da5e:d3ff:fee7:26e7]) by smtp.gmail.com with ESMTPSA id 6a1803df08f44-6d396637613sm9658116d6.116.2024.11.07.09.31.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 07 Nov 2024 09:31:28 -0800 (PST) Date: Thu, 7 Nov 2024 12:31:24 -0500 From: Johannes Weiner To: Kanchana P Sridhar Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, yosryahmed@google.com, nphamcs@gmail.com, chengming.zhou@linux.dev, usamaarif642@gmail.com, ryan.roberts@arm.com, ying.huang@intel.com, 21cnbao@gmail.com, akpm@linux-foundation.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, clabbe@baylibre.com, ardb@kernel.org, ebiggers@google.com, surenb@google.com, kristen.c.accardi@intel.com, zanussi@kernel.org, wajdi.k.feghali@intel.com, vinodh.gopal@intel.com Subject: Re: [PATCH v3 11/13] mm: zswap: Allocate acomp_batch_ctx resources for a given zswap_pool. Message-ID: <20241107173124.GD1172372@cmpxchg.org> References: <20241106192105.6731-1-kanchana.p.sridhar@intel.com> <20241106192105.6731-12-kanchana.p.sridhar@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20241106192105.6731-12-kanchana.p.sridhar@intel.com> X-Rspamd-Server: rspam07 X-Rspamd-Queue-Id: 7D17FC0007 X-Stat-Signature: gtf3z9pegge13zj8grj5ztgowkrpu3b9 X-Rspam-User: X-HE-Tag: 1731000674-945048 X-HE-Meta: U2FsdGVkX19KIMiVUQBJx2aac+X+c0EkgBmXHTAyFDrmmmA7JcrvFjv0kkoap+HOc1e3gDXsaFC/YtPKR1nPbAscVUCb6j/mhjnzS5A9k3rf6WSSw7uDdchmxaXeD7VO+dtBbyw2biGAADSWs17XJDiwgDD6qdBNLT3/gRGUIu8bMwNVxEY8Bb1g/90NWfVpTwHB/DuoaOPqaRb3Dbfu4CU50ySbOgUkf+VHhUHiw5LgwaJuj56VZR+qGF4VwgluqJkxVlMhyPNUB/pFgCDecnqEIluVMB4/FbC3rQLi8l1VOMeNYaQpov5jwRG+ImVhw1cOA8J3pd9qcaHp5V+8qSlIL4hUBsOHcqcFooUt7ss/lD00Yw0Y2/E0VoTw1qVIal6cZBJHj4DJoJMlrk2PR7Gm7Vz5DmwY16CepkE0drdXqXqf3P1mC1QTXHMiaMaYSw/ZBr44FKhNSiWvxaiMLFkcLy1t50E+H55SsoJ0+OETOBqPDmMe6lG56Hr+EjWmhTpaKHUkuy1ubPFYhYtV2TZNaasnV/dgcL99jFf78CUZbivikUFZn7AvtY7GyrTna2RLoCW2k7KVMeFFvIUtearXwxJpxaz4ad3ziv6uE9VV8OPyh61nHUq+qWkWAuILLWc2d27YMWDFXdIBBgJqD+BSNiT6LN5sW46kfCZvh+c3wI/LItuy1PAAVgIxbRk1NmiGojvlaK9afSmMMd7AZhNZsIp2+8kvsiPgjGD5ffxBm++qlRsXiKXKzdAk0+2SY0SgNhhwW3fzfdpvapMBAlws/Fmzoa98G421uha7GxMwUDII9MEzvdwSVoxtBPoaY4HqqRucU1iNHaNOvP4vEiG0wYnY3Z3xGAmigWKI2Tj91Bwaik7QdeAWzk+9SZA4zVfVNLTUpW1v2+3SnUrPpXZwuBCP2fOczMGdfQAmJoUQLJKtYZbbmlBr58DU5E4yUff5ka3aH9XmqYdizJb Vjgyr2md YYOFfPQSIZYZSCZUA452dxyYFnLA1BM2wAqnaSqU6p5GN8uFSEDbCh41I5IyK9SgpvLI76GrdhbZVG300s8LLi/9FyOhAl8s7Of9sNxp4vpTz61QjVKsPlm6AyjJumwkufONrf5c/bgxx2oQafxAyvjk4ThuHItr5iOC2bKNc7KKAcJNC/g5+kSTwqLejD6cUpR0gq43ir/vK393Yw6gq74u3gPZujdIstRNr6LWAdQlV92cCXcCPQ1A6qmh6NU5WLxEeVd+oz/8E2eIAcfw5r0UlSyUSVp8Wndu3VGb5xyMaySlzgHg17yVK1N5kdVy0r3dgiN+ebG1AC2TAyxRnWgZaeBBy77NCYVtfMf1nUPTUzBmHz1fqgf+cUTexk/FT2FmyGRoRyAP/crD/D5mbnbDnLFFHnS+v+avuuTtT6jgHZHHBY2vOEO+UyehRBDSYLh2cLhHsJmRdiVWj5v5rb1Uvqiyj0TYIep7EjLwI4pC/OBwuFX8k8pSyKOWFPLC+I9409LpBrvrwNQaBoWIlXQ/jy/8CKBa1WCmk2NtPB9a26zM= X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: List-Subscribe: List-Unsubscribe: On Wed, Nov 06, 2024 at 11:21:03AM -0800, Kanchana P Sridhar wrote: > If the zswap_pool is associated with an acomp_alg/crypto_acomp that has > registered batch_compress() and batch_decompress() API, we can allocate the > necessary batching resources for the pool's acomp_batch_ctx. > > This patch makes the above determination on incurring the per-cpu memory > footprint cost for batching, and if so, goes ahead and allocates > SWAP_CRYPTO_BATCH_SIZE (i.e. 8) acomp_reqs/buffers for the > pool->acomp_batch_ctx on that specific cpu. > > It also "remembers" the pool's batching readiness as a result of the above, > through a new > > enum batch_comp_status can_batch_comp; > > member added to struct zswap_pool, for fast retrieval during > zswap_store(). > > This allows us a way to only incur the memory footprint cost of the > pool->acomp_batch_ctx resources for a given cpu on which zswap_store() > needs to process a large folio. > > Suggested-by: Yosry Ahmed > Suggested-by: Ying Huang > Signed-off-by: Kanchana P Sridhar A general observation: this is a lot of code for a hardware specific feature that many CPUs and architectures do not support. Please keep the code self-contained, and wrap struct members and functions in a new CONFIG option, so that not everybody has to compile this in.